* Re: [PATCH] iwlwifi:Fix incorrect fallthrough in switch statement in the function iwl_mvm_check_running_scans
@ 2015-10-08 8:30 ` Coelho, Luciano
0 siblings, 0 replies; 3+ messages in thread
From: Coelho, Luciano @ 2015-10-08 8:30 UTC (permalink / raw)
To: xerofoify@gmail.com, Berg, Johannes
Cc: linux-kernel@vger.kernel.org, Spinadel, David, Dreyfuss, Haim,
Bondar, Alexander, ilw@linux.intel.com, kvalo@codeaurora.org,
Stern, Avraham, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, Grumbach, Emmanuel
On Tue, 2015-09-22 at 20:24 -0400, Nicholas Krause wrote:
> This fixes incorrect fallthrough in the switch statment checking
> the scan type passed by the caller to iwl_mvm_check_running_scans
> for the switch case IWL_MVM_SCAN_SCHED to return directly after
> the call to iwl_mvm_scan_stop in order to avoid fallthrough into
> the next case and incorrectly return zero indicating success to
> the caller even if the function call to iwl_mvm_scan_stop fails.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
Applied to our internal tree with a modified commit message.
Thanks!
--
Luca.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iwlwifi:Fix incorrect fallthrough in switch statement in the function iwl_mvm_check_running_scans
@ 2015-10-08 8:30 ` Coelho, Luciano
0 siblings, 0 replies; 3+ messages in thread
From: Coelho, Luciano @ 2015-10-08 8:30 UTC (permalink / raw)
To: xerofoify@gmail.com, Berg, Johannes
Cc: linux-kernel@vger.kernel.org, Spinadel, David, Dreyfuss, Haim,
Bondar, Alexander, ilw@linux.intel.com, kvalo@codeaurora.org,
Stern, Avraham, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, Grumbach, Emmanuel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 763 bytes --]
On Tue, 2015-09-22 at 20:24 -0400, Nicholas Krause wrote:
> This fixes incorrect fallthrough in the switch statment checking
> the scan type passed by the caller to iwl_mvm_check_running_scans
> for the switch case IWL_MVM_SCAN_SCHED to return directly after
> the call to iwl_mvm_scan_stop in order to avoid fallthrough into
> the next case and incorrectly return zero indicating success to
> the caller even if the function call to iwl_mvm_scan_stop fails.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
Applied to our internal tree with a modified commit message.
Thanks!
--
Luca.ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 3+ messages in thread