From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Alex Williamson <alex.williamson@redhat.com>
Cc: Frank Blaschka <frank.blaschka@de.ibm.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] vfio: make an array larger
Date: Wed, 04 Nov 2015 16:40:19 +0000 [thread overview]
Message-ID: <1446655219.21133.48.camel@perches.com> (raw)
In-Reply-To: <20151104132624.GC20966@mwanda>
On Wed, 2015-11-04 at 16:26 +0300, Dan Carpenter wrote:
> Smatch complains about a possible out of bounds error:
>
> drivers/vfio/pci/vfio_pci_config.c:1241 vfio_cap_init()
> error: buffer overflow 'pci_cap_length' 20 <= 20
>
> Fix this by making the array larger.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
[]
> @@ -46,7 +46,7 @@
> * 0: Removed from the user visible capability list
> * FF: Variable length
> */
> -static u8 pci_cap_length[] = {
> +static u8 pci_cap_length[PCI_CAP_ID_MAX + 1] = {
> [PCI_CAP_ID_BASIC] = PCI_STD_HEADER_SIZEOF, /* pci config header */
> [PCI_CAP_ID_PM] = PCI_PM_SIZEOF,
> [PCI_CAP_ID_AGP] = PCI_AGP_SIZEOF,
Doesn't the same thing happen with pci_ext_cap_length?
Both array declarations might be better as const.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Alex Williamson <alex.williamson@redhat.com>
Cc: Frank Blaschka <frank.blaschka@de.ibm.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] vfio: make an array larger
Date: Wed, 04 Nov 2015 08:40:19 -0800 [thread overview]
Message-ID: <1446655219.21133.48.camel@perches.com> (raw)
In-Reply-To: <20151104132624.GC20966@mwanda>
On Wed, 2015-11-04 at 16:26 +0300, Dan Carpenter wrote:
> Smatch complains about a possible out of bounds error:
>
> drivers/vfio/pci/vfio_pci_config.c:1241 vfio_cap_init()
> error: buffer overflow 'pci_cap_length' 20 <= 20
>
> Fix this by making the array larger.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
[]
> @@ -46,7 +46,7 @@
> * 0: Removed from the user visible capability list
> * FF: Variable length
> */
> -static u8 pci_cap_length[] = {
> +static u8 pci_cap_length[PCI_CAP_ID_MAX + 1] = {
> [PCI_CAP_ID_BASIC] = PCI_STD_HEADER_SIZEOF, /* pci config header */
> [PCI_CAP_ID_PM] = PCI_PM_SIZEOF,
> [PCI_CAP_ID_AGP] = PCI_AGP_SIZEOF,
Doesn't the same thing happen with pci_ext_cap_length?
Both array declarations might be better as const.
next prev parent reply other threads:[~2015-11-04 16:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 13:26 [patch] vfio: make an array larger Dan Carpenter
2015-11-04 13:26 ` Dan Carpenter
2015-11-04 16:40 ` Joe Perches [this message]
2015-11-04 16:40 ` Joe Perches
2015-11-04 18:23 ` Dan Carpenter
2015-11-04 18:23 ` Dan Carpenter
2015-11-04 16:54 ` Alex Williamson
2015-11-04 16:54 ` Alex Williamson
2015-11-04 18:20 ` Dan Carpenter
2015-11-04 18:20 ` Dan Carpenter
2015-11-04 18:28 ` Alex Williamson
2015-11-04 18:28 ` Alex Williamson
2015-11-09 12:24 ` [patch v2] vfio/pci: " Dan Carpenter
2015-11-09 12:24 ` Dan Carpenter
2015-11-10 19:03 ` Alex Williamson
2015-11-10 19:03 ` Alex Williamson
2015-11-04 21:39 ` [patch] vfio: " walter harms
2015-11-04 21:39 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446655219.21133.48.camel@perches.com \
--to=joe@perches.com \
--cc=alex.williamson@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=frank.blaschka@de.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.