From: Alex Williamson <alex.williamson@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Sean O. Stalley" <sean.stalley@intel.com>,
Mark Rustad <mark.d.rustad@intel.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] vfio/pci: make an array larger
Date: Tue, 10 Nov 2015 19:03:52 +0000 [thread overview]
Message-ID: <1447182232.4925.116.camel@redhat.com> (raw)
In-Reply-To: <20151109122455.GA28870@mwanda>
On Mon, 2015-11-09 at 15:24 +0300, Dan Carpenter wrote:
> Smatch complains about a possible out of bounds error:
>
> drivers/vfio/pci/vfio_pci_config.c:1241 vfio_cap_init()
> error: buffer overflow 'pci_cap_length' 20 <= 20
>
> The problem is that pci_cap_length[] was defined as large enough to
> hold "PCI_CAP_ID_AF + 1" elements. The code in vfio_cap_init() assumes
> it has PCI_CAP_ID_MAX + 1 elements. Originally, PCI_CAP_ID_AF and
> PCI_CAP_ID_MAX were the same but then we introduced PCI_CAP_ID_EA in
> f80b0ba95964 ('PCI: Add Enhanced Allocation register entries') so now
> the array is too small.
>
> Let's fix this by making the array size PCI_CAP_ID_MAX + 1. And let's
> make a similar change to pci_ext_cap_length[] for consistency. Also
> both these arrays can be made const.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Applied to next for v4.4. Thanks!
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alex Williamson <alex.williamson@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Sean O. Stalley" <sean.stalley@intel.com>,
Mark Rustad <mark.d.rustad@intel.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] vfio/pci: make an array larger
Date: Tue, 10 Nov 2015 12:03:52 -0700 [thread overview]
Message-ID: <1447182232.4925.116.camel@redhat.com> (raw)
In-Reply-To: <20151109122455.GA28870@mwanda>
On Mon, 2015-11-09 at 15:24 +0300, Dan Carpenter wrote:
> Smatch complains about a possible out of bounds error:
>
> drivers/vfio/pci/vfio_pci_config.c:1241 vfio_cap_init()
> error: buffer overflow 'pci_cap_length' 20 <= 20
>
> The problem is that pci_cap_length[] was defined as large enough to
> hold "PCI_CAP_ID_AF + 1" elements. The code in vfio_cap_init() assumes
> it has PCI_CAP_ID_MAX + 1 elements. Originally, PCI_CAP_ID_AF and
> PCI_CAP_ID_MAX were the same but then we introduced PCI_CAP_ID_EA in
> f80b0ba95964 ('PCI: Add Enhanced Allocation register entries') so now
> the array is too small.
>
> Let's fix this by making the array size PCI_CAP_ID_MAX + 1. And let's
> make a similar change to pci_ext_cap_length[] for consistency. Also
> both these arrays can be made const.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Applied to next for v4.4. Thanks!
Alex
next prev parent reply other threads:[~2015-11-10 19:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 13:26 [patch] vfio: make an array larger Dan Carpenter
2015-11-04 13:26 ` Dan Carpenter
2015-11-04 16:40 ` Joe Perches
2015-11-04 16:40 ` Joe Perches
2015-11-04 18:23 ` Dan Carpenter
2015-11-04 18:23 ` Dan Carpenter
2015-11-04 16:54 ` Alex Williamson
2015-11-04 16:54 ` Alex Williamson
2015-11-04 18:20 ` Dan Carpenter
2015-11-04 18:20 ` Dan Carpenter
2015-11-04 18:28 ` Alex Williamson
2015-11-04 18:28 ` Alex Williamson
2015-11-09 12:24 ` [patch v2] vfio/pci: " Dan Carpenter
2015-11-09 12:24 ` Dan Carpenter
2015-11-10 19:03 ` Alex Williamson [this message]
2015-11-10 19:03 ` Alex Williamson
2015-11-04 21:39 ` [patch] vfio: " walter harms
2015-11-04 21:39 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447182232.4925.116.camel@redhat.com \
--to=alex.williamson@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.d.rustad@intel.com \
--cc=sean.stalley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.