All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
	Frank Blaschka <frank.blaschka@de.ibm.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] vfio: make an array larger
Date: Wed, 04 Nov 2015 18:23:43 +0000	[thread overview]
Message-ID: <20151104182343.GO18797@mwanda> (raw)
In-Reply-To: <1446655219.21133.48.camel@perches.com>

On Wed, Nov 04, 2015 at 08:40:19AM -0800, Joe Perches wrote:
> Doesn't the same thing happen with pci_ext_cap_length?

pci_ext_cap_length is fine as-is but you're right that we probably
should make the size explicit as well.  I will fix and resend.

> Both array declarations might be better as const.

Sure.  I will do this as well.

regards,
dan carpenter


WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
	Frank Blaschka <frank.blaschka@de.ibm.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] vfio: make an array larger
Date: Wed, 4 Nov 2015 21:23:43 +0300	[thread overview]
Message-ID: <20151104182343.GO18797@mwanda> (raw)
In-Reply-To: <1446655219.21133.48.camel@perches.com>

On Wed, Nov 04, 2015 at 08:40:19AM -0800, Joe Perches wrote:
> Doesn't the same thing happen with pci_ext_cap_length?

pci_ext_cap_length is fine as-is but you're right that we probably
should make the size explicit as well.  I will fix and resend.

> Both array declarations might be better as const.

Sure.  I will do this as well.

regards,
dan carpenter

  reply	other threads:[~2015-11-04 18:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 13:26 [patch] vfio: make an array larger Dan Carpenter
2015-11-04 13:26 ` Dan Carpenter
2015-11-04 16:40 ` Joe Perches
2015-11-04 16:40   ` Joe Perches
2015-11-04 18:23   ` Dan Carpenter [this message]
2015-11-04 18:23     ` Dan Carpenter
2015-11-04 16:54 ` Alex Williamson
2015-11-04 16:54   ` Alex Williamson
2015-11-04 18:20   ` Dan Carpenter
2015-11-04 18:20     ` Dan Carpenter
2015-11-04 18:28     ` Alex Williamson
2015-11-04 18:28       ` Alex Williamson
2015-11-09 12:24       ` [patch v2] vfio/pci: " Dan Carpenter
2015-11-09 12:24         ` Dan Carpenter
2015-11-10 19:03         ` Alex Williamson
2015-11-10 19:03           ` Alex Williamson
2015-11-04 21:39 ` [patch] vfio: " walter harms
2015-11-04 21:39   ` walter harms

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151104182343.GO18797@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=alex.williamson@redhat.com \
    --cc=frank.blaschka@de.ibm.com \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.