All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: open list <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer
Date: Tue, 31 May 2016 15:09:13 +0200	[thread overview]
Message-ID: <1464700153.5978.107.camel@redhat.com> (raw)
In-Reply-To: <20160531123622.GT4329@intel.com>

On Di, 2016-05-31 at 15:36 +0300, Ville Syrjälä wrote:

> Why store it in the fb and not eg. the plane state?

Well, drm_plane_state is allocated by drm_atomic_helper_update_plane.

When sticking the hotspot into the the plane state we have to add hot_x
and hot_y parameters to drm_plane_funcs->update_plane() and cause quite
some churn all over the drm tree.

Or create a separate code path for cursor updates which uses a special
drm_atomic_helper_update_plane version, which doesn't look very
attractive too due to code duplication.

Sticking it into the drm_framebuffer instead looks like a reasonable
alternative.

I'm open to better suggestions.

cheers,
  Gerd


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer
Date: Tue, 31 May 2016 15:09:13 +0200	[thread overview]
Message-ID: <1464700153.5978.107.camel@redhat.com> (raw)
In-Reply-To: <20160531123622.GT4329@intel.com>

On Di, 2016-05-31 at 15:36 +0300, Ville Syrjälä wrote:

> Why store it in the fb and not eg. the plane state?

Well, drm_plane_state is allocated by drm_atomic_helper_update_plane.

When sticking the hotspot into the the plane state we have to add hot_x
and hot_y parameters to drm_plane_funcs->update_plane() and cause quite
some churn all over the drm tree.

Or create a separate code path for cursor updates which uses a special
drm_atomic_helper_update_plane version, which doesn't look very
attractive too due to code duplication.

Sticking it into the drm_framebuffer instead looks like a reasonable
alternative.

I'm open to better suggestions.

cheers,
  Gerd

  reply	other threads:[~2016-05-31 13:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 10:53 [PATCH 0/5] virtio-gpu: atomic fixes Gerd Hoffmann
2016-05-31 10:53 ` [PATCH 1/5] virtio-gpu: fix output lookup Gerd Hoffmann
2016-05-31 10:53   ` Gerd Hoffmann
2016-05-31 10:53 ` Gerd Hoffmann
2016-05-31 10:53 ` [PATCH 2/5] virtio-gpu: add atomic_commit function Gerd Hoffmann
2016-05-31 10:53 ` Gerd Hoffmann
2016-05-31 10:53   ` Gerd Hoffmann
2016-05-31 10:53 ` [PATCH 3/5] virtio-gpu: switch to atomic cursor interfaces Gerd Hoffmann
2016-05-31 10:53   ` Gerd Hoffmann
2016-05-31 10:53 ` Gerd Hoffmann
2016-05-31 10:53 ` [PATCH 4/5] add cursor hotspot to drm_framebuffer Gerd Hoffmann
2016-05-31 10:53   ` Gerd Hoffmann
2016-05-31 10:58   ` Daniel Vetter
2016-05-31 12:36   ` Ville Syrjälä
2016-05-31 12:36     ` Ville Syrjälä
2016-05-31 13:09     ` Gerd Hoffmann [this message]
2016-05-31 13:09       ` Gerd Hoffmann
2016-05-31 13:54       ` Ville Syrjälä
2016-05-31 13:54         ` Ville Syrjälä
2016-05-31 10:53 ` [PATCH 5/5] virtio-gpu: pick up hotspot from framebuffer Gerd Hoffmann
2016-05-31 10:53   ` Gerd Hoffmann
2016-05-31 10:53 ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464700153.5978.107.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.