All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: open list <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer
Date: Tue, 31 May 2016 15:36:22 +0300	[thread overview]
Message-ID: <20160531123622.GT4329@intel.com> (raw)
In-Reply-To: <1464691994-5704-5-git-send-email-kraxel@redhat.com>

On Tue, May 31, 2016 at 12:53:12PM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  drivers/gpu/drm/drm_crtc.c | 2 ++
>  include/drm/drm_crtc.h     | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index d2a6d95..ce5a280 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -2977,6 +2977,8 @@ static int drm_mode_cursor_universal(struct drm_crtc *crtc,
>  				DRM_DEBUG_KMS("failed to wrap cursor buffer in drm framebuffer\n");
>  				return PTR_ERR(fb);
>  			}
> +			fb->hot_x = req->hot_x;
> +			fb->hot_y = req->hot_y;
>  		} else {
>  			fb = NULL;
>  		}
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index d1559cd..1460f66 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -253,6 +253,8 @@ struct drm_framebuffer {
>  	int bits_per_pixel;
>  	int flags;
>  	uint32_t pixel_format; /* fourcc format */
> +	int hot_x;
> +	int hot_y;
>  	struct list_head filp_head;
>  };

Why store it in the fb and not eg. the plane state?

>  
> -- 
> 1.8.3.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: dri-devel@lists.freedesktop.org,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer
Date: Tue, 31 May 2016 15:36:22 +0300	[thread overview]
Message-ID: <20160531123622.GT4329@intel.com> (raw)
In-Reply-To: <1464691994-5704-5-git-send-email-kraxel@redhat.com>

On Tue, May 31, 2016 at 12:53:12PM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  drivers/gpu/drm/drm_crtc.c | 2 ++
>  include/drm/drm_crtc.h     | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index d2a6d95..ce5a280 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -2977,6 +2977,8 @@ static int drm_mode_cursor_universal(struct drm_crtc *crtc,
>  				DRM_DEBUG_KMS("failed to wrap cursor buffer in drm framebuffer\n");
>  				return PTR_ERR(fb);
>  			}
> +			fb->hot_x = req->hot_x;
> +			fb->hot_y = req->hot_y;
>  		} else {
>  			fb = NULL;
>  		}
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index d1559cd..1460f66 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -253,6 +253,8 @@ struct drm_framebuffer {
>  	int bits_per_pixel;
>  	int flags;
>  	uint32_t pixel_format; /* fourcc format */
> +	int hot_x;
> +	int hot_y;
>  	struct list_head filp_head;
>  };

Why store it in the fb and not eg. the plane state?

>  
> -- 
> 1.8.3.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC

  parent reply	other threads:[~2016-05-31 12:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 10:53 [PATCH 0/5] virtio-gpu: atomic fixes Gerd Hoffmann
2016-05-31 10:53 ` [PATCH 1/5] virtio-gpu: fix output lookup Gerd Hoffmann
2016-05-31 10:53 ` Gerd Hoffmann
2016-05-31 10:53   ` Gerd Hoffmann
2016-05-31 10:53 ` [PATCH 2/5] virtio-gpu: add atomic_commit function Gerd Hoffmann
2016-05-31 10:53   ` Gerd Hoffmann
2016-05-31 10:53 ` Gerd Hoffmann
2016-05-31 10:53 ` [PATCH 3/5] virtio-gpu: switch to atomic cursor interfaces Gerd Hoffmann
2016-05-31 10:53 ` Gerd Hoffmann
2016-05-31 10:53   ` Gerd Hoffmann
2016-05-31 10:53 ` [PATCH 4/5] add cursor hotspot to drm_framebuffer Gerd Hoffmann
2016-05-31 10:53   ` Gerd Hoffmann
2016-05-31 10:58   ` Daniel Vetter
2016-05-31 12:36   ` Ville Syrjälä [this message]
2016-05-31 12:36     ` Ville Syrjälä
2016-05-31 13:09     ` Gerd Hoffmann
2016-05-31 13:09       ` Gerd Hoffmann
2016-05-31 13:54       ` Ville Syrjälä
2016-05-31 13:54         ` Ville Syrjälä
2016-05-31 10:53 ` [PATCH 5/5] virtio-gpu: pick up hotspot from framebuffer Gerd Hoffmann
2016-05-31 10:53 ` Gerd Hoffmann
2016-05-31 10:53   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160531123622.GT4329@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.