From: Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev)
To: linux-snps-arc@lists.infradead.org
Subject: dmatest no longer works on ARC SDP with DW DMAC
Date: Wed, 10 Aug 2016 11:06:50 +0000 [thread overview]
Message-ID: <1470827209.21247.12.camel@synopsys.com> (raw)
dmatest on ARC SDP with DW DMAC became broken after df5c7386
("dmaengine: dw: some Intel devices has no memcpy support") and
30cb2639 ("dmaengine: dw: don't override platform data with autocfg")
commits.
* After df5c7386 commit "DMA_MEMCPY" capability option doesn't
get set correctly in platform driver version.
* After 30cb2639 commit
"data_width" and "nollp" parameters don't get set correctly in platform
driver version.
This happens because in old driver version there are three sources?
of parameters: pdata, device tree and autoconfig hardware registers.?
Some parameters were read from pdata and others from autoconfig
hardware registers. If pdata was absent some pdata structure?
fields were filled with parameters from device tree. But 30cb2639
commit disabled overriding pdata with autocfg, so if we use platform
driver version without pdata some parameters will not be set.
I'm wondering what would be the best way to fix this situation?
Should we strictly read parameters from only one source (pdata/device
tree/autoconfig) or we may mix some of them (for example getting
missing data from autoconf regs)?
WARNING: multiple messages have this Message-ID (diff)
From: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
To: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Cc: "vinod.koul@intel.com" <vinod.koul@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vlad Zakharov <Vladislav.Zakharov@synopsys.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
Nelson Pereira <Nelson.Pereira@synopsys.com>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>
Subject: dmatest no longer works on ARC SDP with DW DMAC
Date: Wed, 10 Aug 2016 11:06:50 +0000 [thread overview]
Message-ID: <1470827209.21247.12.camel@synopsys.com> (raw)
dmatest on ARC SDP with DW DMAC became broken after df5c7386
("dmaengine: dw: some Intel devices has no memcpy support") and
30cb2639 ("dmaengine: dw: don't override platform data with autocfg")
commits.
* After df5c7386 commit "DMA_MEMCPY" capability option doesn't
get set correctly in platform driver version.
* After 30cb2639 commit
"data_width" and "nollp" parameters don't get set correctly in platform
driver version.
This happens because in old driver version there are three sources
of parameters: pdata, device tree and autoconfig hardware registers.
Some parameters were read from pdata and others from autoconfig
hardware registers. If pdata was absent some pdata structure
fields were filled with parameters from device tree. But 30cb2639
commit disabled overriding pdata with autocfg, so if we use platform
driver version without pdata some parameters will not be set.
I'm wondering what would be the best way to fix this situation?
Should we strictly read parameters from only one source (pdata/device
tree/autoconfig) or we may mix some of them (for example getting
missing data from autoconf regs)?
next reply other threads:[~2016-08-10 11:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 11:06 Eugeniy Paltsev [this message]
2016-08-10 11:06 ` dmatest no longer works on ARC SDP with DW DMAC Eugeniy Paltsev
2016-08-10 12:15 ` Andy Shevchenko
2016-08-10 12:15 ` Andy Shevchenko
2016-08-10 12:22 ` Alexey Brodkin
2016-08-10 12:22 ` Alexey Brodkin
2016-08-10 12:46 ` Andy Shevchenko
2016-08-10 12:46 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470827209.21247.12.camel@synopsys.com \
--to=eugeniy.paltsev@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.