From: Keith Busch <keith.busch@intel.com>
To: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Merlin <marc@merlins.org>, Keith Busch <keith.busch@intel.com>
Subject: [PATCH 3/6] nvme/pci: Start queues after tagset is updated
Date: Wed, 4 Jan 2017 17:41:08 -0500 [thread overview]
Message-ID: <1483569671-1462-4-git-send-email-keith.busch@intel.com> (raw)
In-Reply-To: <1483569671-1462-1-git-send-email-keith.busch@intel.com>
We need to leave the block queues stopped if we're changing the tagset's
number of queues.
Signed-off-by: Keith Busch <keith.busch@intel.com>
---
drivers/nvme/host/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 19beeb7..a94fbcb 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1813,8 +1813,8 @@ static void nvme_reset_work(struct work_struct *work)
nvme_kill_queues(&dev->ctrl);
nvme_remove_namespaces(&dev->ctrl);
} else {
- nvme_start_queues(&dev->ctrl);
nvme_dev_add(dev);
+ nvme_start_queues(&dev->ctrl);
}
if (!nvme_change_ctrl_state(&dev->ctrl, NVME_CTRL_LIVE)) {
--
2.5.5
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 3/6] nvme/pci: Start queues after tagset is updated
Date: Wed, 4 Jan 2017 17:41:08 -0500 [thread overview]
Message-ID: <1483569671-1462-4-git-send-email-keith.busch@intel.com> (raw)
In-Reply-To: <1483569671-1462-1-git-send-email-keith.busch@intel.com>
We need to leave the block queues stopped if we're changing the tagset's
number of queues.
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
drivers/nvme/host/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 19beeb7..a94fbcb 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1813,8 +1813,8 @@ static void nvme_reset_work(struct work_struct *work)
nvme_kill_queues(&dev->ctrl);
nvme_remove_namespaces(&dev->ctrl);
} else {
- nvme_start_queues(&dev->ctrl);
nvme_dev_add(dev);
+ nvme_start_queues(&dev->ctrl);
}
if (!nvme_change_ctrl_state(&dev->ctrl, NVME_CTRL_LIVE)) {
--
2.5.5
next prev parent reply other threads:[~2017-01-04 22:41 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 22:41 [PATCH 0/6] NVMe related fixes Keith Busch
2017-01-04 22:41 ` Keith Busch
2017-01-04 22:41 ` [PATCH 1/6] irq/affinity: Assign all online CPUs to vectors Keith Busch
2017-01-04 22:41 ` Keith Busch
2017-01-13 20:21 ` Sagi Grimberg
2017-01-13 20:21 ` Sagi Grimberg
2017-01-23 18:30 ` Christoph Hellwig
2017-01-23 18:30 ` Christoph Hellwig
2017-01-04 22:41 ` [PATCH 2/6] irq/affinity: Assign offline CPUs a vector Keith Busch
2017-01-04 22:41 ` Keith Busch
2017-01-08 10:01 ` Christoph Hellwig
2017-01-08 10:01 ` Christoph Hellwig
2017-01-13 20:26 ` Sagi Grimberg
2017-01-13 20:26 ` Sagi Grimberg
2017-01-04 22:41 ` Keith Busch [this message]
2017-01-04 22:41 ` [PATCH 3/6] nvme/pci: Start queues after tagset is updated Keith Busch
2017-01-13 20:38 ` Sagi Grimberg
2017-01-13 20:38 ` Sagi Grimberg
2017-01-23 18:31 ` Christoph Hellwig
2017-01-23 18:31 ` Christoph Hellwig
2017-01-04 22:41 ` [PATCH 4/6] blk-mq: Update queue map when changing queue count Keith Busch
2017-01-04 22:41 ` Keith Busch
2017-01-13 20:39 ` Sagi Grimberg
2017-01-13 20:39 ` Sagi Grimberg
2017-01-23 18:32 ` Christoph Hellwig
2017-01-23 18:32 ` Christoph Hellwig
2017-01-04 22:41 ` [PATCH 5/6] blk-mq: Fix queue freeze deadlock Keith Busch
2017-01-04 22:41 ` Keith Busch
2017-01-05 7:33 ` Bart Van Assche
2017-01-05 7:33 ` Bart Van Assche
2017-01-17 17:53 ` Keith Busch
2017-01-17 17:53 ` Keith Busch
2017-01-13 21:05 ` Sagi Grimberg
2017-01-13 21:05 ` Sagi Grimberg
2017-01-17 18:00 ` Keith Busch
2017-01-17 18:00 ` Keith Busch
2017-01-19 7:54 ` Sagi Grimberg
2017-01-19 7:54 ` Sagi Grimberg
2017-01-04 22:41 ` [PATCH 6/6] blk-mq: Remove unused variable Keith Busch
2017-01-04 22:41 ` Keith Busch
2017-01-08 10:02 ` Christoph Hellwig
2017-01-08 10:02 ` Christoph Hellwig
2017-01-13 21:05 ` Sagi Grimberg
2017-01-13 21:05 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483569671-1462-4-git-send-email-keith.busch@intel.com \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marc@merlins.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.