All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <keith.busch@intel.com>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: "hch@lst.de" <hch@lst.de>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"axboe@fb.com" <axboe@fb.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"marc@merlins.org" <marc@merlins.org>
Subject: Re: [PATCH 5/6] blk-mq: Fix queue freeze deadlock
Date: Tue, 17 Jan 2017 12:53:13 -0500	[thread overview]
Message-ID: <20170117175312.GA8989@localhost.localdomain> (raw)
In-Reply-To: <1483601585.2811.5.camel@sandisk.com>

On Thu, Jan 05, 2017 at 07:33:22AM +0000, Bart Van Assche wrote:
> This patch adds a second code path to the blk-mq core for running queues and
> hence will make the blk-mq core harder to maintain. Have you considered to
> implement this functionality by introducing a new "fail all requests" flag
> for hctx queues such that blk_mq_abandon_stopped_requests() can reuse the
> existing mechanism for running a queue?

Thanks for the suggestion. I'll look into that. I wanted to avoid more
flags to test for in the fast-path, but I see that a special queue run
method is problematic for maintenance.

WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 5/6] blk-mq: Fix queue freeze deadlock
Date: Tue, 17 Jan 2017 12:53:13 -0500	[thread overview]
Message-ID: <20170117175312.GA8989@localhost.localdomain> (raw)
In-Reply-To: <1483601585.2811.5.camel@sandisk.com>

On Thu, Jan 05, 2017@07:33:22AM +0000, Bart Van Assche wrote:
> This patch adds a second code path to the blk-mq core for running queues and
> hence will make the blk-mq core harder to maintain. Have you considered to
> implement this functionality by introducing a new "fail all requests" flag
> for hctx queues such that blk_mq_abandon_stopped_requests() can reuse the
> existing mechanism for running a queue?

Thanks for the suggestion. I'll look into that. I wanted to avoid more
flags to test for in the fast-path, but I see that a special queue run
method is problematic for maintenance.

  reply	other threads:[~2017-01-17 17:53 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-04 22:41 [PATCH 0/6] NVMe related fixes Keith Busch
2017-01-04 22:41 ` Keith Busch
2017-01-04 22:41 ` [PATCH 1/6] irq/affinity: Assign all online CPUs to vectors Keith Busch
2017-01-04 22:41   ` Keith Busch
2017-01-13 20:21   ` Sagi Grimberg
2017-01-13 20:21     ` Sagi Grimberg
2017-01-23 18:30   ` Christoph Hellwig
2017-01-23 18:30     ` Christoph Hellwig
2017-01-04 22:41 ` [PATCH 2/6] irq/affinity: Assign offline CPUs a vector Keith Busch
2017-01-04 22:41   ` Keith Busch
2017-01-08 10:01   ` Christoph Hellwig
2017-01-08 10:01     ` Christoph Hellwig
2017-01-13 20:26     ` Sagi Grimberg
2017-01-13 20:26       ` Sagi Grimberg
2017-01-04 22:41 ` [PATCH 3/6] nvme/pci: Start queues after tagset is updated Keith Busch
2017-01-04 22:41   ` Keith Busch
2017-01-13 20:38   ` Sagi Grimberg
2017-01-13 20:38     ` Sagi Grimberg
2017-01-23 18:31   ` Christoph Hellwig
2017-01-23 18:31     ` Christoph Hellwig
2017-01-04 22:41 ` [PATCH 4/6] blk-mq: Update queue map when changing queue count Keith Busch
2017-01-04 22:41   ` Keith Busch
2017-01-13 20:39   ` Sagi Grimberg
2017-01-13 20:39     ` Sagi Grimberg
2017-01-23 18:32   ` Christoph Hellwig
2017-01-23 18:32     ` Christoph Hellwig
2017-01-04 22:41 ` [PATCH 5/6] blk-mq: Fix queue freeze deadlock Keith Busch
2017-01-04 22:41   ` Keith Busch
2017-01-05  7:33   ` Bart Van Assche
2017-01-05  7:33     ` Bart Van Assche
2017-01-17 17:53     ` Keith Busch [this message]
2017-01-17 17:53       ` Keith Busch
2017-01-13 21:05   ` Sagi Grimberg
2017-01-13 21:05     ` Sagi Grimberg
2017-01-17 18:00     ` Keith Busch
2017-01-17 18:00       ` Keith Busch
2017-01-19  7:54       ` Sagi Grimberg
2017-01-19  7:54         ` Sagi Grimberg
2017-01-04 22:41 ` [PATCH 6/6] blk-mq: Remove unused variable Keith Busch
2017-01-04 22:41   ` Keith Busch
2017-01-08 10:02   ` Christoph Hellwig
2017-01-08 10:02     ` Christoph Hellwig
2017-01-13 21:05   ` Sagi Grimberg
2017-01-13 21:05     ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170117175312.GA8989@localhost.localdomain \
    --to=keith.busch@intel.com \
    --cc=Bart.VanAssche@sandisk.com \
    --cc=axboe@fb.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=marc@merlins.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.