From: Keith Busch <keith.busch@intel.com>
To: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Merlin <marc@merlins.org>, Keith Busch <keith.busch@intel.com>
Subject: [PATCH 4/6] blk-mq: Update queue map when changing queue count
Date: Wed, 4 Jan 2017 17:41:09 -0500 [thread overview]
Message-ID: <1483569671-1462-5-git-send-email-keith.busch@intel.com> (raw)
In-Reply-To: <1483569671-1462-1-git-send-email-keith.busch@intel.com>
The queue map needs to match how many hardware queues exist, otherwise
it may indicate a less than optimal mapping, contain a hctx_id that
was freed, or attempt to initialize a request map for invalid context.
Signed-off-by: Keith Busch <keith.busch@intel.com>
---
block/blk-mq.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index a8e67a1..9b7ed03 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -2223,7 +2223,6 @@ static void blk_mq_queue_reinit(struct request_queue *q,
* we should change hctx numa_node according to new topology (this
* involves free and re-allocate memory, worthy doing?)
*/
-
blk_mq_map_swqueue(q, online_mask);
blk_mq_sysfs_register(q);
@@ -2481,6 +2480,11 @@ void blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set, int nr_hw_queues)
blk_mq_freeze_queue(q);
set->nr_hw_queues = nr_hw_queues;
+ if (set->ops->map_queues)
+ set->ops->map_queues(set);
+ else
+ blk_mq_map_queues(set);
+
list_for_each_entry(q, &set->tag_list, tag_set_list) {
blk_mq_realloc_hw_ctxs(set, q);
--
2.5.5
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 4/6] blk-mq: Update queue map when changing queue count
Date: Wed, 4 Jan 2017 17:41:09 -0500 [thread overview]
Message-ID: <1483569671-1462-5-git-send-email-keith.busch@intel.com> (raw)
In-Reply-To: <1483569671-1462-1-git-send-email-keith.busch@intel.com>
The queue map needs to match how many hardware queues exist, otherwise
it may indicate a less than optimal mapping, contain a hctx_id that
was freed, or attempt to initialize a request map for invalid context.
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
block/blk-mq.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index a8e67a1..9b7ed03 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -2223,7 +2223,6 @@ static void blk_mq_queue_reinit(struct request_queue *q,
* we should change hctx numa_node according to new topology (this
* involves free and re-allocate memory, worthy doing?)
*/
-
blk_mq_map_swqueue(q, online_mask);
blk_mq_sysfs_register(q);
@@ -2481,6 +2480,11 @@ void blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set, int nr_hw_queues)
blk_mq_freeze_queue(q);
set->nr_hw_queues = nr_hw_queues;
+ if (set->ops->map_queues)
+ set->ops->map_queues(set);
+ else
+ blk_mq_map_queues(set);
+
list_for_each_entry(q, &set->tag_list, tag_set_list) {
blk_mq_realloc_hw_ctxs(set, q);
--
2.5.5
next prev parent reply other threads:[~2017-01-04 22:41 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 22:41 [PATCH 0/6] NVMe related fixes Keith Busch
2017-01-04 22:41 ` Keith Busch
2017-01-04 22:41 ` [PATCH 1/6] irq/affinity: Assign all online CPUs to vectors Keith Busch
2017-01-04 22:41 ` Keith Busch
2017-01-13 20:21 ` Sagi Grimberg
2017-01-13 20:21 ` Sagi Grimberg
2017-01-23 18:30 ` Christoph Hellwig
2017-01-23 18:30 ` Christoph Hellwig
2017-01-04 22:41 ` [PATCH 2/6] irq/affinity: Assign offline CPUs a vector Keith Busch
2017-01-04 22:41 ` Keith Busch
2017-01-08 10:01 ` Christoph Hellwig
2017-01-08 10:01 ` Christoph Hellwig
2017-01-13 20:26 ` Sagi Grimberg
2017-01-13 20:26 ` Sagi Grimberg
2017-01-04 22:41 ` [PATCH 3/6] nvme/pci: Start queues after tagset is updated Keith Busch
2017-01-04 22:41 ` Keith Busch
2017-01-13 20:38 ` Sagi Grimberg
2017-01-13 20:38 ` Sagi Grimberg
2017-01-23 18:31 ` Christoph Hellwig
2017-01-23 18:31 ` Christoph Hellwig
2017-01-04 22:41 ` Keith Busch [this message]
2017-01-04 22:41 ` [PATCH 4/6] blk-mq: Update queue map when changing queue count Keith Busch
2017-01-13 20:39 ` Sagi Grimberg
2017-01-13 20:39 ` Sagi Grimberg
2017-01-23 18:32 ` Christoph Hellwig
2017-01-23 18:32 ` Christoph Hellwig
2017-01-04 22:41 ` [PATCH 5/6] blk-mq: Fix queue freeze deadlock Keith Busch
2017-01-04 22:41 ` Keith Busch
2017-01-05 7:33 ` Bart Van Assche
2017-01-05 7:33 ` Bart Van Assche
2017-01-17 17:53 ` Keith Busch
2017-01-17 17:53 ` Keith Busch
2017-01-13 21:05 ` Sagi Grimberg
2017-01-13 21:05 ` Sagi Grimberg
2017-01-17 18:00 ` Keith Busch
2017-01-17 18:00 ` Keith Busch
2017-01-19 7:54 ` Sagi Grimberg
2017-01-19 7:54 ` Sagi Grimberg
2017-01-04 22:41 ` [PATCH 6/6] blk-mq: Remove unused variable Keith Busch
2017-01-04 22:41 ` Keith Busch
2017-01-08 10:02 ` Christoph Hellwig
2017-01-08 10:02 ` Christoph Hellwig
2017-01-13 21:05 ` Sagi Grimberg
2017-01-13 21:05 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483569671-1462-5-git-send-email-keith.busch@intel.com \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marc@merlins.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.