All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "dan.j.williams@intel.com" <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	"david@fromorbit.com" <david@fromorbit.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH v4] DAX: enable iostat for read/write
Date: Tue, 10 Jan 2017 23:54:54 +0000	[thread overview]
Message-ID: <1484095838.2029.1.camel@hpe.com> (raw)
In-Reply-To: <CAPcyv4gBtLB1GmKuPyJ257Hej+sEH54624Tuhq6OobV3ZZVawA@mail.gmail.com>

On Tue, 2017-01-10 at 15:41 -0800, Dan Williams wrote:
> On Tue, Jan 10, 2017 at 4:11 PM, Toshi Kani <toshi.kani@hpe.com>
> wrote:
 :
> > 
> > +       if (blk_queue_io_stat(disk->queue)) {
> > +               int sec = iov_iter_count(iter) >> 9;
> > +
> > +               start = jiffies;
> > +               generic_start_io_acct(iov_iter_rw(iter),
> > +                                     (!sec) ? 1 : sec, &disk-
> > >part0);
> > +       }
> > +
> >         while (iov_iter_count(iter)) {
> >                 ret = iomap_apply(inode, pos, iov_iter_count(iter),
> > flags, ops,
> >                                 iter, dax_iomap_actor);
> > @@ -1073,6 +1083,9 @@ dax_iomap_rw(struct kiocb *iocb, struct
> > iov_iter *iter,
> >                 done += ret;
> >         }
> > 
> > +       if (start)
> > +               generic_end_io_acct(iov_iter_rw(iter), &disk-
> > >part0, start);
> > +
> 
> I think we can afford to add a separate flag that indicates whether
> we called generic_start_io_acct(). Just in case 'start' is '0' after
> 'jiffies' rolls over.

Good point. I will add a flag to account such a case.

Thanks,
-Toshi
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "dan.j.williams@intel.com" <dan.j.williams@intel.com>
Cc: "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"david@fromorbit.com" <david@fromorbit.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] DAX: enable iostat for read/write
Date: Tue, 10 Jan 2017 23:54:54 +0000	[thread overview]
Message-ID: <1484095838.2029.1.camel@hpe.com> (raw)
In-Reply-To: <CAPcyv4gBtLB1GmKuPyJ257Hej+sEH54624Tuhq6OobV3ZZVawA@mail.gmail.com>

On Tue, 2017-01-10 at 15:41 -0800, Dan Williams wrote:
> On Tue, Jan 10, 2017 at 4:11 PM, Toshi Kani <toshi.kani@hpe.com>
> wrote:
 :
> > 
> > +       if (blk_queue_io_stat(disk->queue)) {
> > +               int sec = iov_iter_count(iter) >> 9;
> > +
> > +               start = jiffies;
> > +               generic_start_io_acct(iov_iter_rw(iter),
> > +                                     (!sec) ? 1 : sec, &disk-
> > >part0);
> > +       }
> > +
> >         while (iov_iter_count(iter)) {
> >                 ret = iomap_apply(inode, pos, iov_iter_count(iter),
> > flags, ops,
> >                                 iter, dax_iomap_actor);
> > @@ -1073,6 +1083,9 @@ dax_iomap_rw(struct kiocb *iocb, struct
> > iov_iter *iter,
> >                 done += ret;
> >         }
> > 
> > +       if (start)
> > +               generic_end_io_acct(iov_iter_rw(iter), &disk-
> > >part0, start);
> > +
> 
> I think we can afford to add a separate flag that indicates whether
> we called generic_start_io_acct(). Just in case 'start' is '0' after
> 'jiffies' rolls over.

Good point. I will add a flag to account such a case.

Thanks,
-Toshi

WARNING: multiple messages have this Message-ID (diff)
From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "dan.j.williams@intel.com" <dan.j.williams@intel.com>
Cc: "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"david@fromorbit.com" <david@fromorbit.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
	"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] DAX: enable iostat for read/write
Date: Tue, 10 Jan 2017 23:54:54 +0000	[thread overview]
Message-ID: <1484095838.2029.1.camel@hpe.com> (raw)
In-Reply-To: <CAPcyv4gBtLB1GmKuPyJ257Hej+sEH54624Tuhq6OobV3ZZVawA@mail.gmail.com>

On Tue, 2017-01-10 at 15:41 -0800, Dan Williams wrote:
> On Tue, Jan 10, 2017 at 4:11 PM, Toshi Kani <toshi.kani@hpe.com>
> wrote:
 :
> > 
> > +       if (blk_queue_io_stat(disk->queue)) {
> > +               int sec = iov_iter_count(iter) >> 9;
> > +
> > +               start = jiffies;
> > +               generic_start_io_acct(iov_iter_rw(iter),
> > +                                     (!sec) ? 1 : sec, &disk-
> > >part0);
> > +       }
> > +
> >         while (iov_iter_count(iter)) {
> >                 ret = iomap_apply(inode, pos, iov_iter_count(iter),
> > flags, ops,
> >                                 iter, dax_iomap_actor);
> > @@ -1073,6 +1083,9 @@ dax_iomap_rw(struct kiocb *iocb, struct
> > iov_iter *iter,
> >                 done += ret;
> >         }
> > 
> > +       if (start)
> > +               generic_end_io_acct(iov_iter_rw(iter), &disk-
> > >part0, start);
> > +
> 
> I think we can afford to add a separate flag that indicates whether
> we called generic_start_io_acct(). Just in case 'start' is '0' after
> 'jiffies' rolls over.

Good point. I will add a flag to account such a case.

Thanks,
-Toshi

  reply	other threads:[~2017-01-10 23:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11  0:11 [PATCH v4] DAX: enable iostat for read/write Toshi Kani
2017-01-11  0:11 ` Toshi Kani
2017-01-11  0:11 ` Toshi Kani
2017-01-10 23:41 ` Dan Williams
2017-01-10 23:41   ` Dan Williams
2017-01-10 23:41   ` Dan Williams
2017-01-10 23:54   ` Kani, Toshimitsu [this message]
2017-01-10 23:54     ` Kani, Toshimitsu
2017-01-10 23:54     ` Kani, Toshimitsu
2017-01-11  4:36 ` Joe Perches
2017-01-11  4:36   ` Joe Perches
2017-01-11  4:36   ` Joe Perches
2017-01-11 16:29   ` Kani, Toshimitsu
2017-01-11 16:29     ` Kani, Toshimitsu
2017-01-11 16:29     ` Kani, Toshimitsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484095838.2029.1.camel@hpe.com \
    --to=toshi.kani@hpe.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=david@fromorbit.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.