All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "joe@perches.com" <joe@perches.com>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	"viro@zenihttp.domain.invalid" <viro@zenihttp.domain.invalid>,
	"david@fromorbit.com" <david@fromorbit.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v4] DAX: enable iostat for read/write
Date: Wed, 11 Jan 2017 16:29:21 +0000	[thread overview]
Message-ID: <1484155504.2029.3.camel@hpe.com> (raw)
In-Reply-To: <1484109363.12006.19.camel@perches.com>

On Tue, 2017-01-10 at 20:36 -0800, Joe Perches wrote:
> > 
On Tue, 2017-01-10 at 17:11 -0700, Toshi Kani wrote:
> > DAX IO path does not support iostat, but its metadata IO path does.
> > Therefore, iostat shows metadata IO statistics only, which has been
> > confusing to users.
> 
> []
> > diff --git a/fs/dax.c b/fs/dax.c
> 
> []
> > @@ -1058,12 +1058,22 @@ dax_iomap_rw(struct kiocb *iocb, struct
> > iov_iter *iter,
> 
> []
> > +	if (blk_queue_io_stat(disk->queue)) {
> > +		int sec = iov_iter_count(iter) >> 9;
> > +
> > +		start = jiffies;
> > +		generic_start_io_acct(iov_iter_rw(iter),
> > +				      (!sec) ? 1 : sec, &disk-
> > >part0);
> > +	}
> 
> There is a signed/unsigned conversion of sec
> It may be better to use something like:
> 
> 		size_t sec  = iov_iter_count(iter) >> 9;
> 		[...]
> 		generic_start_io_acct(iov_iter_rw(iter),
> 				      min_t(unsigned long, 1, sec),
> 				      &disk->part0);

Good catch. I will change as you suggested, and use 'sector_t' for
'sec'. 

Thanks,
-Toshi
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "joe@perches.com" <joe@perches.com>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "viro@zenihttp.domain.invalid" <viro@zenihttp.domain.invalid>,
	"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
	"david@fromorbit.com" <david@fromorbit.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v4] DAX: enable iostat for read/write
Date: Wed, 11 Jan 2017 16:29:21 +0000	[thread overview]
Message-ID: <1484155504.2029.3.camel@hpe.com> (raw)
In-Reply-To: <1484109363.12006.19.camel@perches.com>

On Tue, 2017-01-10 at 20:36 -0800, Joe Perches wrote:
> > 
On Tue, 2017-01-10 at 17:11 -0700, Toshi Kani wrote:
> > DAX IO path does not support iostat, but its metadata IO path does.
> > Therefore, iostat shows metadata IO statistics only, which has been
> > confusing to users.
> 
> []
> > diff --git a/fs/dax.c b/fs/dax.c
> 
> []
> > @@ -1058,12 +1058,22 @@ dax_iomap_rw(struct kiocb *iocb, struct
> > iov_iter *iter,
> 
> []
> > +	if (blk_queue_io_stat(disk->queue)) {
> > +		int sec = iov_iter_count(iter) >> 9;
> > +
> > +		start = jiffies;
> > +		generic_start_io_acct(iov_iter_rw(iter),
> > +				      (!sec) ? 1 : sec, &disk-
> > >part0);
> > +	}
> 
> There is a signed/unsigned conversion of sec
> It may be better to use something like:
> 
> 		size_t sec  = iov_iter_count(iter) >> 9;
> 		[...]
> 		generic_start_io_acct(iov_iter_rw(iter),
> 				      min_t(unsigned long, 1, sec),
> 				      &disk->part0);

Good catch. I will change as you suggested, and use 'sector_t' for
'sec'. 

Thanks,
-Toshi

WARNING: multiple messages have this Message-ID (diff)
From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "joe@perches.com" <joe@perches.com>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "viro@zenihttp.domain.invalid" <viro@zenihttp.domain.invalid>,
	"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
	"david@fromorbit.com" <david@fromorbit.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v4] DAX: enable iostat for read/write
Date: Wed, 11 Jan 2017 16:29:21 +0000	[thread overview]
Message-ID: <1484155504.2029.3.camel@hpe.com> (raw)
In-Reply-To: <1484109363.12006.19.camel@perches.com>

On Tue, 2017-01-10 at 20:36 -0800, Joe Perches wrote:
> > 
On Tue, 2017-01-10 at 17:11 -0700, Toshi Kani wrote:
> > DAX IO path does not support iostat, but its metadata IO path does.
> > Therefore, iostat shows metadata IO statistics only, which has been
> > confusing to users.
> 
> []
> > diff --git a/fs/dax.c b/fs/dax.c
> 
> []
> > @@ -1058,12 +1058,22 @@ dax_iomap_rw(struct kiocb *iocb, struct
> > iov_iter *iter,
> 
> []
> > +	if (blk_queue_io_stat(disk->queue)) {
> > +		int sec = iov_iter_count(iter) >> 9;
> > +
> > +		start = jiffies;
> > +		generic_start_io_acct(iov_iter_rw(iter),
> > +				      (!sec) ? 1 : sec, &disk-
> > >part0);
> > +	}
> 
> There is a signed/unsigned conversion of sec
> It may be better to use something like:
> 
> 		size_t sec  = iov_iter_count(iter) >> 9;
> 		[...]
> 		generic_start_io_acct(iov_iter_rw(iter),
> 				      min_t(unsigned long, 1, sec),
> 				      &disk->part0);

Good catch. I will change as you suggested, and use 'sector_t' for
'sec'. 

Thanks,
-Toshi

  reply	other threads:[~2017-01-11 16:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11  0:11 [PATCH v4] DAX: enable iostat for read/write Toshi Kani
2017-01-11  0:11 ` Toshi Kani
2017-01-11  0:11 ` Toshi Kani
2017-01-10 23:41 ` Dan Williams
2017-01-10 23:41   ` Dan Williams
2017-01-10 23:41   ` Dan Williams
2017-01-10 23:54   ` Kani, Toshimitsu
2017-01-10 23:54     ` Kani, Toshimitsu
2017-01-10 23:54     ` Kani, Toshimitsu
2017-01-11  4:36 ` Joe Perches
2017-01-11  4:36   ` Joe Perches
2017-01-11  4:36   ` Joe Perches
2017-01-11 16:29   ` Kani, Toshimitsu [this message]
2017-01-11 16:29     ` Kani, Toshimitsu
2017-01-11 16:29     ` Kani, Toshimitsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484155504.2029.3.camel@hpe.com \
    --to=toshi.kani@hpe.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=david@fromorbit.com \
    --cc=joe@perches.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=viro@zenihttp.domain.invalid \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.