From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "bblock@linux.vnet.ibm.com" <bblock@linux.vnet.ibm.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH v4 0/6] Avoid that scsi-mq and dm-mq queue processing stalls sporadically
Date: Wed, 12 Apr 2017 18:11:25 +0000 [thread overview]
Message-ID: <1492020683.2764.9.camel@sandisk.com> (raw)
In-Reply-To: <20170412105538.GB22576@bblock-ThinkPad-W530>
On Wed, 2017-04-12 at 12:55 +0200, Benjamin Block wrote:
> On Fri, Apr 07, 2017 at 11:16:48AM -0700, Bart Van Assche wrote:
> > The six patches in this patch series fix the queue lockup I reported
> > recently on the linux-block mailing list. Please consider these patches
> > for inclusion in the upstream kernel.
>=20
> just out of curiosity. Is this maybe related to similar stuff happening
> when CPUs are hot plugged - at least in that the stack gets stuck? Like
> in this thread here:
> https://www.mail-archive.com/linux-block@vger.kernel.org/msg06057.html
>=20
> Would be interesting, because we recently saw similar stuff happening.
Hello Benjamin,
My proposal is to repeat that test with Jens' for-next branch. If the issue
still occurs with that tree then please check the contents of
/sys/kernel/debug/block/*/mq/*/{dispatch,*/rq_list}. That will allow to
determine whether or not any block layer requests are still pending. If
running the command below resolves the deadlock then it means that a
trigger to run a block layer queue is still missing somewhere:
for a in /sys/kernel/debug/block/*/mq/state; do echo run >$a;=A0done
See also git://git.kernel.dk/linux-block.git.
Bart.=
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "bblock@linux.vnet.ibm.com" <bblock@linux.vnet.ibm.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH v4 0/6] Avoid that scsi-mq and dm-mq queue processing stalls sporadically
Date: Wed, 12 Apr 2017 18:11:25 +0000 [thread overview]
Message-ID: <1492020683.2764.9.camel@sandisk.com> (raw)
In-Reply-To: <20170412105538.GB22576@bblock-ThinkPad-W530>
On Wed, 2017-04-12 at 12:55 +0200, Benjamin Block wrote:
> On Fri, Apr 07, 2017 at 11:16:48AM -0700, Bart Van Assche wrote:
> > The six patches in this patch series fix the queue lockup I reported
> > recently on the linux-block mailing list. Please consider these patches
> > for inclusion in the upstream kernel.
>
> just out of curiosity. Is this maybe related to similar stuff happening
> when CPUs are hot plugged - at least in that the stack gets stuck? Like
> in this thread here:
> https://www.mail-archive.com/linux-block@vger.kernel.org/msg06057.html
>
> Would be interesting, because we recently saw similar stuff happening.
Hello Benjamin,
My proposal is to repeat that test with Jens' for-next branch. If the issue
still occurs with that tree then please check the contents of
/sys/kernel/debug/block/*/mq/*/{dispatch,*/rq_list}. That will allow to
determine whether or not any block layer requests are still pending. If
running the command below resolves the deadlock then it means that a
trigger to run a block layer queue is still missing somewhere:
for a in /sys/kernel/debug/block/*/mq/state; do echo run >$a; done
See also git://git.kernel.dk/linux-block.git.
Bart.
next prev parent reply other threads:[~2017-04-12 18:11 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 18:16 [PATCH v4 0/6] Avoid that scsi-mq and dm-mq queue processing stalls sporadically Bart Van Assche
2017-04-07 18:16 ` Bart Van Assche
2017-04-07 18:16 ` [PATCH v4 1/6] blk-mq: Make it safe to use RCU to iterate over blk_mq_tag_set.tag_list Bart Van Assche
2017-04-07 18:16 ` Bart Van Assche
2017-04-10 7:10 ` Christoph Hellwig
2017-04-07 18:16 ` [PATCH v4 2/6] blk-mq: Restart a single queue if tag sets are shared Bart Van Assche
2017-04-07 18:16 ` Bart Van Assche
2017-04-10 7:11 ` Christoph Hellwig
2017-04-07 18:16 ` [PATCH v4 3/6] blk-mq: Clarify comments in blk_mq_dispatch_rq_list() Bart Van Assche
2017-04-07 18:16 ` Bart Van Assche
2017-04-10 7:11 ` Christoph Hellwig
2017-04-07 18:16 ` [PATCH v4 4/6] blk-mq: Introduce blk_mq_delay_run_hw_queue() Bart Van Assche
2017-04-07 18:16 ` Bart Van Assche
2017-04-10 7:12 ` Christoph Hellwig
2017-04-10 15:02 ` Jens Axboe
2017-04-07 18:16 ` [PATCH v4 5/6] scsi: Avoid that SCSI queues get stuck Bart Van Assche
2017-04-07 18:16 ` Bart Van Assche
2017-04-10 7:12 ` Christoph Hellwig
2017-04-07 18:16 ` [PATCH v4 6/6] dm rq: Avoid that request processing stalls sporadically Bart Van Assche
2017-04-07 18:16 ` Bart Van Assche
2017-04-11 16:09 ` Mike Snitzer
2017-04-11 16:09 ` Mike Snitzer
2017-04-11 16:26 ` Bart Van Assche
2017-04-11 16:26 ` Bart Van Assche
2017-04-11 17:47 ` Mike Snitzer
2017-04-11 17:51 ` Bart Van Assche
2017-04-11 17:51 ` Bart Van Assche
2017-04-11 18:03 ` Mike Snitzer
2017-04-11 18:03 ` Mike Snitzer
2017-04-11 18:18 ` Bart Van Assche
2017-04-11 18:18 ` Bart Van Assche
2017-04-12 3:42 ` Ming Lei
2017-04-12 3:42 ` Ming Lei
2017-04-12 18:38 ` Bart Van Assche
2017-04-12 18:38 ` Bart Van Assche
2017-04-12 18:38 ` Bart Van Assche
2017-04-13 2:20 ` Ming Lei
2017-04-13 2:20 ` Ming Lei
2017-04-13 16:59 ` Bart Van Assche
2017-04-14 1:13 ` Ming Lei
2017-04-14 17:12 ` Bart Van Assche
2017-04-14 17:12 ` Bart Van Assche
2017-04-16 10:21 ` Ming Lei
2017-04-07 18:23 ` [PATCH v4 0/6] Avoid that scsi-mq and dm-mq queue " Jens Axboe
2017-04-07 18:33 ` Bart Van Assche
2017-04-07 18:33 ` Bart Van Assche
2017-04-07 18:39 ` Bart Van Assche
2017-04-07 18:39 ` Bart Van Assche
2017-04-07 18:51 ` Jens Axboe
2017-04-12 10:55 ` Benjamin Block
2017-04-12 10:55 ` Benjamin Block
2017-04-12 18:11 ` Bart Van Assche [this message]
2017-04-12 18:11 ` Bart Van Assche
2017-04-13 12:23 ` Benjamin Block
2017-04-13 12:23 ` Benjamin Block
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492020683.2764.9.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@kernel.dk \
--cc=bblock@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.