All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
Cc: Zhentao Guo <zhentao.guo@amlogic.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH RFC v4 1/4] media: dt-bindings: Add Amlogic V4L2 video decoder
Date: Fri, 13 Feb 2026 12:30:49 +0100	[thread overview]
Message-ID: <14ee2088-032d-4cd4-8703-fd2f2d304b5b@kernel.org> (raw)
In-Reply-To: <D93350ED-72E3-43B5-BA4F-42E0FE491B2A@gmail.com>

On 13/02/2026 12:14, Piotr Oniszczuk wrote:
>>
>>>>> In short, canvas is a hardware IP inside the Amlogic SoC. The decoder IP
>>>>> needs to access DDR through canvas IP, so we need to reference the
>>>> Why decoder cannot access DDR directly?
>>> The internal topology of the S4 chip is designed this way, we don't know 
>>> why our VLSI colleauges designed like this. But similar designs have 
>>> been removed in subsequent chips, eliminating the need to rely on a 
>>> common hardware IP.
>>
>> Quite poor explanation. Based on this, this as well could be entry in
>> device reg lists.
>>
>> Anyway, I am done guessing, explain properly the hardware instead of
>> answering with half-baked responses just so I will go away.
>>
>>
>> Best regards,
>> Krzysztof
>>
> 
> Krzysztof,
> 
> May you pls explain me: what added value - to upstreaming aml video decoder - will be provided by giving NAK .... because canvas/DDR access details explanations are not enough detailed FOR YOU?

NAK is a disagreement with this patch being merged, so there is no added
value in it. What sort of added value do you expect from NAKs?

Best regards,
Krzysztof

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
Cc: Zhentao Guo <zhentao.guo@amlogic.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH RFC v4 1/4] media: dt-bindings: Add Amlogic V4L2 video decoder
Date: Fri, 13 Feb 2026 12:30:49 +0100	[thread overview]
Message-ID: <14ee2088-032d-4cd4-8703-fd2f2d304b5b@kernel.org> (raw)
In-Reply-To: <D93350ED-72E3-43B5-BA4F-42E0FE491B2A@gmail.com>

On 13/02/2026 12:14, Piotr Oniszczuk wrote:
>>
>>>>> In short, canvas is a hardware IP inside the Amlogic SoC. The decoder IP
>>>>> needs to access DDR through canvas IP, so we need to reference the
>>>> Why decoder cannot access DDR directly?
>>> The internal topology of the S4 chip is designed this way, we don't know 
>>> why our VLSI colleauges designed like this. But similar designs have 
>>> been removed in subsequent chips, eliminating the need to rely on a 
>>> common hardware IP.
>>
>> Quite poor explanation. Based on this, this as well could be entry in
>> device reg lists.
>>
>> Anyway, I am done guessing, explain properly the hardware instead of
>> answering with half-baked responses just so I will go away.
>>
>>
>> Best regards,
>> Krzysztof
>>
> 
> Krzysztof,
> 
> May you pls explain me: what added value - to upstreaming aml video decoder - will be provided by giving NAK .... because canvas/DDR access details explanations are not enough detailed FOR YOU?

NAK is a disagreement with this patch being merged, so there is no added
value in it. What sort of added value do you expect from NAKs?

Best regards,
Krzysztof


  reply	other threads:[~2026-02-13 11:31 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13  5:12 [PATCH RFC v4 0/4] Add Amlogic stateless H.264 video decoder for S4 Zhentao Guo
2026-02-13  5:12 ` Zhentao Guo via B4 Relay
2026-02-13  5:12 ` Zhentao Guo via B4 Relay
2026-02-13  5:12 ` [PATCH RFC v4 1/4] media: dt-bindings: Add Amlogic V4L2 video decoder Zhentao Guo
2026-02-13  5:12   ` Zhentao Guo via B4 Relay
2026-02-13  5:12   ` Zhentao Guo via B4 Relay
2026-02-13  7:35   ` Krzysztof Kozlowski
2026-02-13  7:35     ` Krzysztof Kozlowski
2026-02-13  8:04     ` Zhentao Guo
2026-02-13  8:04       ` Zhentao Guo
2026-02-13  8:17       ` Krzysztof Kozlowski
2026-02-13  8:17         ` Krzysztof Kozlowski
     [not found]     ` <75e55ceb-e6dd-47b5-a829-66f6fbb3e13e@amlogic.com>
2026-02-13  8:16       ` Krzysztof Kozlowski
2026-02-13  8:16         ` Krzysztof Kozlowski
2026-02-13  8:31         ` Zhentao Guo
2026-02-13  8:31           ` Zhentao Guo
2026-02-13  8:55           ` Krzysztof Kozlowski
2026-02-13  8:55             ` Krzysztof Kozlowski
2026-02-13  9:14             ` Zhentao Guo
2026-02-13  9:14               ` Zhentao Guo
2026-02-13 11:14             ` Piotr Oniszczuk
2026-02-13 11:14               ` Piotr Oniszczuk
2026-02-13 11:30               ` Krzysztof Kozlowski [this message]
2026-02-13 11:30                 ` Krzysztof Kozlowski
2026-03-05 11:01             ` Zhentao Guo
2026-03-05 11:01               ` Zhentao Guo
2026-03-05 11:08               ` Krzysztof Kozlowski
2026-03-05 11:08                 ` Krzysztof Kozlowski
2026-03-05 11:35                 ` Neil Armstrong
2026-03-05 11:35                   ` Neil Armstrong
2026-03-05 11:53                   ` Krzysztof Kozlowski
2026-03-05 11:53                     ` Krzysztof Kozlowski
2026-03-05 15:57                     ` Neil Armstrong
2026-03-05 15:57                       ` Neil Armstrong
2026-02-13  5:12 ` [PATCH RFC v4 2/4] decoder: Add V4L2 stateless H.264 decoder driver Zhentao Guo
2026-02-13  5:12   ` Zhentao Guo via B4 Relay
2026-02-13  5:12   ` Zhentao Guo via B4 Relay
2026-02-16  1:10   ` kernel test robot
2026-02-13  5:12 ` [PATCH RFC v4 3/4] arm64: dts: amlogic: Add video decoder driver support for S4 SOCs Zhentao Guo
2026-02-13  5:12   ` Zhentao Guo via B4 Relay
2026-02-13  5:12   ` Zhentao Guo via B4 Relay
2026-02-13  5:12 ` [PATCH RFC v4 4/4] arm64: defconfig: Enable VDEC driver for Amlogic SoCs Zhentao Guo
2026-02-13  5:12   ` Zhentao Guo via B4 Relay
2026-02-13  5:12   ` Zhentao Guo via B4 Relay
2026-02-13  7:33   ` Krzysztof Kozlowski
2026-02-13  7:33     ` Krzysztof Kozlowski
2026-02-13  8:06     ` Zhentao Guo
2026-02-13  8:06       ` Zhentao Guo
2026-02-13  8:18       ` Krzysztof Kozlowski
2026-02-13  8:18         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14ee2088-032d-4cd4-8703-fd2f2d304b5b@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=mchehab@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=piotr.oniszczuk@gmail.com \
    --cc=robh@kernel.org \
    --cc=zhentao.guo@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.