All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Mike Kravetz <mike.kravetz@oracle.com>,
	Florian Weimer <fweimer@redhat.com>,
	linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, colm@allcosts.net, akpm@linux-foundation.org,
	keescook@chromium.org, luto@amacapital.net, wad@chromium.org,
	mingo@kernel.org, kirill@shutemov.name, dave.hansen@intel.com
Subject: Re: [PATCH v2 0/2] mm,fork,security: introduce MADV_WIPEONFORK
Date: Tue, 08 Aug 2017 11:46:08 -0400	[thread overview]
Message-ID: <1502207168.6577.25.camel@redhat.com> (raw)
In-Reply-To: <0324df31-717d-32c1-95ef-351c5b23105f@oracle.com>

On Tue, 2017-08-08 at 08:19 -0700, Mike Kravetz wrote:

> The other question I was trying to bring up is "What does
> MADV_WIPEONFORK
> mean for various types of mappings?"A A For example, if we allow
> MADV_WIPEONFORK on a file backed mapping what does that mapping look
> like in the child after fork?A A Does it have any connection at all to
> the
> file?A A Or, do we drop all references to the file and essentially
> transform
> it to a private (or shared?) anonymous mapping after fork.A A What
> about
> System V shared memory?A A What about hugetlb?

My current patch turns any file-backed VMA into an empty
anonymous VMA if MADV_WIPEONFORK was used on that VMA.

> If the use case is fairly specific, then perhaps it makes sense to
> make MADV_WIPEONFORK not applicable (EINVAL) for mappings where the
> result is 'questionable'.

That would be a question for Florian and Colm.

If they are OK with MADV_WIPEONFORK only working on
anonymous VMAs (no file mapping), that certainly could
be implemented.

On the other hand, I am not sure that introducing cases
where MADV_WIPEONFORK does not implement wipe-on-fork
semantics would reduce user confusion...

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Mike Kravetz <mike.kravetz@oracle.com>,
	Florian Weimer <fweimer@redhat.com>,
	linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, colm@allcosts.net, akpm@linux-foundation.org,
	keescook@chromium.org, luto@amacapital.net, wad@chromium.org,
	mingo@kernel.org, kirill@shutemov.name, dave.hansen@intel.com
Subject: Re: [PATCH v2 0/2] mm,fork,security: introduce MADV_WIPEONFORK
Date: Tue, 08 Aug 2017 11:46:08 -0400	[thread overview]
Message-ID: <1502207168.6577.25.camel@redhat.com> (raw)
In-Reply-To: <0324df31-717d-32c1-95ef-351c5b23105f@oracle.com>

On Tue, 2017-08-08 at 08:19 -0700, Mike Kravetz wrote:

> The other question I was trying to bring up is "What does
> MADV_WIPEONFORK
> mean for various types of mappings?"  For example, if we allow
> MADV_WIPEONFORK on a file backed mapping what does that mapping look
> like in the child after fork?  Does it have any connection at all to
> the
> file?  Or, do we drop all references to the file and essentially
> transform
> it to a private (or shared?) anonymous mapping after fork.  What
> about
> System V shared memory?  What about hugetlb?

My current patch turns any file-backed VMA into an empty
anonymous VMA if MADV_WIPEONFORK was used on that VMA.

> If the use case is fairly specific, then perhaps it makes sense to
> make MADV_WIPEONFORK not applicable (EINVAL) for mappings where the
> result is 'questionable'.

That would be a question for Florian and Colm.

If they are OK with MADV_WIPEONFORK only working on
anonymous VMAs (no file mapping), that certainly could
be implemented.

On the other hand, I am not sure that introducing cases
where MADV_WIPEONFORK does not implement wipe-on-fork
semantics would reduce user confusion...

  parent reply	other threads:[~2017-08-08 15:46 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-06 14:04 [PATCH v2 0/2] mm,fork,security: introduce MADV_WIPEONFORK riel
2017-08-06 14:04 ` riel
2017-08-06 14:04 ` [PATCH 1/2] x86,mpx: make mpx depend on x86-64 to free up VMA flag riel
2017-08-06 14:04   ` riel
2017-08-06 14:04 ` [PATCH 2/2] mm,fork: introduce MADV_WIPEONFORK riel
2017-08-06 14:04   ` riel
2017-08-10 15:23   ` Michal Hocko
2017-08-10 15:23     ` Michal Hocko
2017-08-11 15:23     ` Rik van Riel
2017-08-11 15:23       ` Rik van Riel
2017-08-11 16:36       ` Mike Kravetz
2017-08-11 16:36         ` Mike Kravetz
2017-08-11 16:59         ` Rik van Riel
2017-08-11 16:59           ` Rik van Riel
2017-08-11 17:07           ` Mike Kravetz
2017-08-11 17:07             ` Mike Kravetz
2017-08-07 13:22 ` [PATCH v2 0/2] mm,fork,security: " Michal Hocko
2017-08-07 13:22   ` Michal Hocko
     [not found]   ` <20170807132257.GH32434-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-08-07 13:46     ` Michal Hocko
2017-08-07 13:46       ` Michal Hocko
2017-08-07 13:46       ` Michal Hocko
2017-08-07 14:19       ` Florian Weimer
2017-08-07 14:19         ` Florian Weimer
2017-08-10 13:06         ` Michal Hocko
2017-08-10 13:06           ` Michal Hocko
2017-08-07 14:59       ` Rik van Riel
2017-08-07 14:59         ` Rik van Riel
2017-08-07 14:59         ` Rik van Riel
     [not found]         ` <1502117991.6577.13.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-09  9:59           ` Kirill A. Shutemov
2017-08-09  9:59             ` Kirill A. Shutemov
2017-08-09  9:59             ` Kirill A. Shutemov
2017-08-09 12:31             ` Rik van Riel
2017-08-09 12:31               ` Rik van Riel
2017-08-09 12:31               ` Rik van Riel
2017-08-09 12:42             ` Florian Weimer
2017-08-09 12:42               ` Florian Weimer
2017-08-10 13:05         ` Michal Hocko
2017-08-10 13:05           ` Michal Hocko
     [not found]           ` <20170810130531.GS23863-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-08-10 13:23             ` Colm MacCárthaigh
2017-08-10 13:23               ` Colm MacCárthaigh
2017-08-10 13:23               ` Colm MacCárthaigh
     [not found]               ` <CAAF6GDc2hsj-XJj=Rx2ZF6Sh3Ke6nKewABXfqQxQjfDd5QN7Ug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-10 15:36                 ` Michal Hocko
2017-08-10 15:36                   ` Michal Hocko
2017-08-10 15:36                   ` Michal Hocko
2017-08-10 16:17                   ` Colm MacCárthaigh
     [not found]                     ` <CAAF6GDeno6RpHf1KORVSxUL7M-CQfbWFFdyKK8LAWd_6PcJ55Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-10 17:01                       ` Michal Hocko
2017-08-10 17:01                         ` Michal Hocko
2017-08-10 17:01                         ` Michal Hocko
     [not found]                         ` <20170810170144.GA987-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-08-10 22:09                           ` Colm MacCárthaigh
2017-08-10 22:09                             ` Colm MacCárthaigh
2017-08-10 22:09                             ` Colm MacCárthaigh
     [not found]                             ` <CAAF6GDdFjS612mx1TXzaVk1J-Afz9wsAywTEijO2TG4idxabiw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-11 14:06                               ` Michal Hocko
2017-08-11 14:06                                 ` Michal Hocko
2017-08-11 14:06                                 ` Michal Hocko
     [not found]                                 ` <20170811140653.GO30811-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-08-11 14:11                                   ` Florian Weimer
2017-08-11 14:11                                     ` Florian Weimer
2017-08-11 14:11                                     ` Florian Weimer
     [not found]                                     ` <c8cda773-b28d-f35f-7f18-6735584cb173-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-11 14:24                                       ` Michal Hocko
2017-08-11 14:24                                         ` Michal Hocko
2017-08-11 14:24                                         ` Michal Hocko
     [not found]                                         ` <20170811142457.GP30811-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-08-11 15:24                                           ` Florian Weimer
2017-08-11 15:24                                             ` Florian Weimer
2017-08-11 15:24                                             ` Florian Weimer
2017-08-11 15:31                                             ` Michal Hocko
2017-08-11 15:31                                               ` Michal Hocko
2017-08-07 15:55       ` Colm MacCárthaigh
2017-08-07 16:02         ` Colm MacCárthaigh
2017-08-10 13:21         ` Michal Hocko
2017-08-10 13:21           ` Michal Hocko
2017-08-10 13:21           ` Michal Hocko
2017-08-10 14:11           ` Michal Hocko
2017-08-10 14:11             ` Michal Hocko
2017-08-07 18:23 ` Mike Kravetz
2017-08-07 18:23   ` Mike Kravetz
2017-08-08  9:58   ` Florian Weimer
2017-08-08  9:58     ` Florian Weimer
2017-08-08 13:15     ` Rik van Riel
2017-08-08 13:15       ` Rik van Riel
2017-08-08 15:19       ` Mike Kravetz
2017-08-08 15:19         ` Mike Kravetz
2017-08-08 15:22         ` Florian Weimer
2017-08-08 15:22           ` Florian Weimer
2017-08-08 15:46         ` Rik van Riel [this message]
2017-08-08 15:46           ` Rik van Riel
2017-08-08 16:48           ` Colm MacCárthaigh
2017-08-08 16:48             ` Colm MacCárthaigh
2017-08-08 16:52           ` Matthew Wilcox
2017-08-08 16:52             ` Matthew Wilcox
2017-08-08 18:45             ` Rik van Riel
2017-08-08 18:45               ` Rik van Riel
2017-08-10 15:31               ` Michal Hocko
2017-08-10 15:31                 ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502207168.6577.25.camel@redhat.com \
    --to=riel@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=colm@allcosts.net \
    --cc=dave.hansen@intel.com \
    --cc=fweimer@redhat.com \
    --cc=keescook@chromium.org \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@amacapital.net \
    --cc=mike.kravetz@oracle.com \
    --cc=mingo@kernel.org \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.