All of lore.kernel.org
 help / color / mirror / Atom feed
From: riel@redhat.com
To: linux-kernel@vger.kernel.org
Cc: mike.kravetz@oracle.com, linux-mm@kvack.org, fweimer@redhat.com,
	colm@allcosts.net, akpm@linux-foundation.org,
	keescook@chromium.org, luto@amacapital.net, wad@chromium.org,
	mingo@kernel.org, kirill@shutemov.name, dave.hansen@intel.com
Subject: [PATCH 1/2] x86,mpx: make mpx depend on x86-64 to free up VMA flag
Date: Sun,  6 Aug 2017 10:04:24 -0400	[thread overview]
Message-ID: <20170806140425.20937-2-riel@redhat.com> (raw)
In-Reply-To: <20170806140425.20937-1-riel@redhat.com>

From: Rik van Riel <riel@redhat.com>

MPX only seems to be available on 64 bit CPUs, starting with Skylake
and Goldmont. Move VM_MPX into the 64 bit only portion of vma->vm_flags,
in order to free up a VMA flag.

Signed-off-by: Rik van Riel <riel@redhat.com>
---
 arch/x86/Kconfig   | 4 +++-
 include/linux/mm.h | 8 ++++++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 781521b7cf9e..6dff14fadc6f 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1756,7 +1756,9 @@ config X86_SMAP
 config X86_INTEL_MPX
 	prompt "Intel MPX (Memory Protection Extensions)"
 	def_bool n
-	depends on CPU_SUP_INTEL
+	# Note: only available in 64-bit mode due to VMA flags shortage
+	depends on CPU_SUP_INTEL && X86_64
+	select ARCH_USES_HIGH_VMA_FLAGS
 	---help---
 	  MPX provides hardware features that can be used in
 	  conjunction with compiler-instrumented code to check
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 46b9ac5e8569..7550eeb06ccf 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -208,10 +208,12 @@ extern unsigned int kobjsize(const void *objp);
 #define VM_HIGH_ARCH_BIT_1	33	/* bit only usable on 64-bit architectures */
 #define VM_HIGH_ARCH_BIT_2	34	/* bit only usable on 64-bit architectures */
 #define VM_HIGH_ARCH_BIT_3	35	/* bit only usable on 64-bit architectures */
+#define VM_HIGH_ARCH_BIT_4	36	/* bit only usable on 64-bit architectures */
 #define VM_HIGH_ARCH_0	BIT(VM_HIGH_ARCH_BIT_0)
 #define VM_HIGH_ARCH_1	BIT(VM_HIGH_ARCH_BIT_1)
 #define VM_HIGH_ARCH_2	BIT(VM_HIGH_ARCH_BIT_2)
 #define VM_HIGH_ARCH_3	BIT(VM_HIGH_ARCH_BIT_3)
+#define VM_HIGH_ARCH_4	BIT(VM_HIGH_ARCH_BIT_4)
 #endif /* CONFIG_ARCH_USES_HIGH_VMA_FLAGS */
 
 #if defined(CONFIG_X86)
@@ -235,9 +237,11 @@ extern unsigned int kobjsize(const void *objp);
 # define VM_MAPPED_COPY	VM_ARCH_1	/* T if mapped copy of data (nommu mmap) */
 #endif
 
-#if defined(CONFIG_X86)
+#if defined(CONFIG_X86_INTEL_MPX)
 /* MPX specific bounds table or bounds directory */
-# define VM_MPX		VM_ARCH_2
+# define VM_MPX		VM_HIGH_ARCH_BIT_4
+#else
+# define VM_MPX		VM_NONE
 #endif
 
 #ifndef VM_GROWSUP
-- 
2.9.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: riel@redhat.com
To: linux-kernel@vger.kernel.org
Cc: mike.kravetz@oracle.com, linux-mm@kvack.org, fweimer@redhat.com,
	colm@allcosts.net, akpm@linux-foundation.org,
	keescook@chromium.org, luto@amacapital.net, wad@chromium.org,
	mingo@kernel.org, kirill@shutemov.name, dave.hansen@intel.com
Subject: [PATCH 1/2] x86,mpx: make mpx depend on x86-64 to free up VMA flag
Date: Sun,  6 Aug 2017 10:04:24 -0400	[thread overview]
Message-ID: <20170806140425.20937-2-riel@redhat.com> (raw)
In-Reply-To: <20170806140425.20937-1-riel@redhat.com>

From: Rik van Riel <riel@redhat.com>

MPX only seems to be available on 64 bit CPUs, starting with Skylake
and Goldmont. Move VM_MPX into the 64 bit only portion of vma->vm_flags,
in order to free up a VMA flag.

Signed-off-by: Rik van Riel <riel@redhat.com>
---
 arch/x86/Kconfig   | 4 +++-
 include/linux/mm.h | 8 ++++++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 781521b7cf9e..6dff14fadc6f 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1756,7 +1756,9 @@ config X86_SMAP
 config X86_INTEL_MPX
 	prompt "Intel MPX (Memory Protection Extensions)"
 	def_bool n
-	depends on CPU_SUP_INTEL
+	# Note: only available in 64-bit mode due to VMA flags shortage
+	depends on CPU_SUP_INTEL && X86_64
+	select ARCH_USES_HIGH_VMA_FLAGS
 	---help---
 	  MPX provides hardware features that can be used in
 	  conjunction with compiler-instrumented code to check
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 46b9ac5e8569..7550eeb06ccf 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -208,10 +208,12 @@ extern unsigned int kobjsize(const void *objp);
 #define VM_HIGH_ARCH_BIT_1	33	/* bit only usable on 64-bit architectures */
 #define VM_HIGH_ARCH_BIT_2	34	/* bit only usable on 64-bit architectures */
 #define VM_HIGH_ARCH_BIT_3	35	/* bit only usable on 64-bit architectures */
+#define VM_HIGH_ARCH_BIT_4	36	/* bit only usable on 64-bit architectures */
 #define VM_HIGH_ARCH_0	BIT(VM_HIGH_ARCH_BIT_0)
 #define VM_HIGH_ARCH_1	BIT(VM_HIGH_ARCH_BIT_1)
 #define VM_HIGH_ARCH_2	BIT(VM_HIGH_ARCH_BIT_2)
 #define VM_HIGH_ARCH_3	BIT(VM_HIGH_ARCH_BIT_3)
+#define VM_HIGH_ARCH_4	BIT(VM_HIGH_ARCH_BIT_4)
 #endif /* CONFIG_ARCH_USES_HIGH_VMA_FLAGS */
 
 #if defined(CONFIG_X86)
@@ -235,9 +237,11 @@ extern unsigned int kobjsize(const void *objp);
 # define VM_MAPPED_COPY	VM_ARCH_1	/* T if mapped copy of data (nommu mmap) */
 #endif
 
-#if defined(CONFIG_X86)
+#if defined(CONFIG_X86_INTEL_MPX)
 /* MPX specific bounds table or bounds directory */
-# define VM_MPX		VM_ARCH_2
+# define VM_MPX		VM_HIGH_ARCH_BIT_4
+#else
+# define VM_MPX		VM_NONE
 #endif
 
 #ifndef VM_GROWSUP
-- 
2.9.4

  reply	other threads:[~2017-08-06 14:04 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-06 14:04 [PATCH v2 0/2] mm,fork,security: introduce MADV_WIPEONFORK riel
2017-08-06 14:04 ` riel
2017-08-06 14:04 ` riel [this message]
2017-08-06 14:04   ` [PATCH 1/2] x86,mpx: make mpx depend on x86-64 to free up VMA flag riel
2017-08-06 14:04 ` [PATCH 2/2] mm,fork: introduce MADV_WIPEONFORK riel
2017-08-06 14:04   ` riel
2017-08-10 15:23   ` Michal Hocko
2017-08-10 15:23     ` Michal Hocko
2017-08-11 15:23     ` Rik van Riel
2017-08-11 15:23       ` Rik van Riel
2017-08-11 16:36       ` Mike Kravetz
2017-08-11 16:36         ` Mike Kravetz
2017-08-11 16:59         ` Rik van Riel
2017-08-11 16:59           ` Rik van Riel
2017-08-11 17:07           ` Mike Kravetz
2017-08-11 17:07             ` Mike Kravetz
2017-08-07 13:22 ` [PATCH v2 0/2] mm,fork,security: " Michal Hocko
2017-08-07 13:22   ` Michal Hocko
     [not found]   ` <20170807132257.GH32434-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-08-07 13:46     ` Michal Hocko
2017-08-07 13:46       ` Michal Hocko
2017-08-07 13:46       ` Michal Hocko
2017-08-07 14:19       ` Florian Weimer
2017-08-07 14:19         ` Florian Weimer
2017-08-10 13:06         ` Michal Hocko
2017-08-10 13:06           ` Michal Hocko
2017-08-07 14:59       ` Rik van Riel
2017-08-07 14:59         ` Rik van Riel
2017-08-07 14:59         ` Rik van Riel
     [not found]         ` <1502117991.6577.13.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-09  9:59           ` Kirill A. Shutemov
2017-08-09  9:59             ` Kirill A. Shutemov
2017-08-09  9:59             ` Kirill A. Shutemov
2017-08-09 12:31             ` Rik van Riel
2017-08-09 12:31               ` Rik van Riel
2017-08-09 12:31               ` Rik van Riel
2017-08-09 12:42             ` Florian Weimer
2017-08-09 12:42               ` Florian Weimer
2017-08-10 13:05         ` Michal Hocko
2017-08-10 13:05           ` Michal Hocko
     [not found]           ` <20170810130531.GS23863-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-08-10 13:23             ` Colm MacCárthaigh
2017-08-10 13:23               ` Colm MacCárthaigh
2017-08-10 13:23               ` Colm MacCárthaigh
     [not found]               ` <CAAF6GDc2hsj-XJj=Rx2ZF6Sh3Ke6nKewABXfqQxQjfDd5QN7Ug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-10 15:36                 ` Michal Hocko
2017-08-10 15:36                   ` Michal Hocko
2017-08-10 15:36                   ` Michal Hocko
2017-08-10 16:17                   ` Colm MacCárthaigh
     [not found]                     ` <CAAF6GDeno6RpHf1KORVSxUL7M-CQfbWFFdyKK8LAWd_6PcJ55Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-10 17:01                       ` Michal Hocko
2017-08-10 17:01                         ` Michal Hocko
2017-08-10 17:01                         ` Michal Hocko
     [not found]                         ` <20170810170144.GA987-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-08-10 22:09                           ` Colm MacCárthaigh
2017-08-10 22:09                             ` Colm MacCárthaigh
2017-08-10 22:09                             ` Colm MacCárthaigh
     [not found]                             ` <CAAF6GDdFjS612mx1TXzaVk1J-Afz9wsAywTEijO2TG4idxabiw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-11 14:06                               ` Michal Hocko
2017-08-11 14:06                                 ` Michal Hocko
2017-08-11 14:06                                 ` Michal Hocko
     [not found]                                 ` <20170811140653.GO30811-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-08-11 14:11                                   ` Florian Weimer
2017-08-11 14:11                                     ` Florian Weimer
2017-08-11 14:11                                     ` Florian Weimer
     [not found]                                     ` <c8cda773-b28d-f35f-7f18-6735584cb173-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-11 14:24                                       ` Michal Hocko
2017-08-11 14:24                                         ` Michal Hocko
2017-08-11 14:24                                         ` Michal Hocko
     [not found]                                         ` <20170811142457.GP30811-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-08-11 15:24                                           ` Florian Weimer
2017-08-11 15:24                                             ` Florian Weimer
2017-08-11 15:24                                             ` Florian Weimer
2017-08-11 15:31                                             ` Michal Hocko
2017-08-11 15:31                                               ` Michal Hocko
2017-08-07 15:55       ` Colm MacCárthaigh
2017-08-07 16:02         ` Colm MacCárthaigh
2017-08-10 13:21         ` Michal Hocko
2017-08-10 13:21           ` Michal Hocko
2017-08-10 13:21           ` Michal Hocko
2017-08-10 14:11           ` Michal Hocko
2017-08-10 14:11             ` Michal Hocko
2017-08-07 18:23 ` Mike Kravetz
2017-08-07 18:23   ` Mike Kravetz
2017-08-08  9:58   ` Florian Weimer
2017-08-08  9:58     ` Florian Weimer
2017-08-08 13:15     ` Rik van Riel
2017-08-08 13:15       ` Rik van Riel
2017-08-08 15:19       ` Mike Kravetz
2017-08-08 15:19         ` Mike Kravetz
2017-08-08 15:22         ` Florian Weimer
2017-08-08 15:22           ` Florian Weimer
2017-08-08 15:46         ` Rik van Riel
2017-08-08 15:46           ` Rik van Riel
2017-08-08 16:48           ` Colm MacCárthaigh
2017-08-08 16:48             ` Colm MacCárthaigh
2017-08-08 16:52           ` Matthew Wilcox
2017-08-08 16:52             ` Matthew Wilcox
2017-08-08 18:45             ` Rik van Riel
2017-08-08 18:45               ` Rik van Riel
2017-08-10 15:31               ` Michal Hocko
2017-08-10 15:31                 ` Michal Hocko
  -- strict thread matches above, loose matches on Subject: below --
2017-08-11 21:28 [PATCH v4 " riel-H+wXaHxf7aLQT0dZR+AlfA
2017-08-11 21:28 ` [PATCH 1/2] x86,mpx: make mpx depend on x86-64 to free up VMA flag riel
2017-08-11 21:28   ` riel
2017-08-11 19:19 [PATCH v3 0/2] mm,fork,security: introduce MADV_WIPEONFORK riel-H+wXaHxf7aLQT0dZR+AlfA
     [not found] ` <20170811191942.17487-1-riel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-11 19:19   ` [PATCH 1/2] x86,mpx: make mpx depend on x86-64 to free up VMA flag riel-H+wXaHxf7aLQT0dZR+AlfA
2017-08-11 19:19     ` riel
2017-08-11 19:19     ` riel
2017-08-04 19:07 [PATCH 0/2] mm,fork,security: introduce MADV_WIPEONFORK riel
2017-08-04 19:07 ` [PATCH 1/2] x86,mpx: make mpx depend on x86-64 to free up VMA flag riel
2017-08-04 19:07   ` riel
2017-08-04 19:25   ` Dave Hansen
2017-08-04 19:25     ` Dave Hansen
2017-08-04 19:01 [PATCH 0/2] mm,fork: MADV_WIPEONFORK - an empty VMA in the child riel
2017-08-04 19:01 ` [PATCH 1/2] x86,mpx: make mpx depend on x86-64 to free up VMA flag riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170806140425.20937-2-riel@redhat.com \
    --to=riel@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=colm@allcosts.net \
    --cc=dave.hansen@intel.com \
    --cc=fweimer@redhat.com \
    --cc=keescook@chromium.org \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@amacapital.net \
    --cc=mike.kravetz@oracle.com \
    --cc=mingo@kernel.org \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.