From: Denis OSTERLAND <denis.osterland@diehl.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"m.grzeschik@pengutronix.de" <m.grzeschik@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH v4 5/5] rtc: isl1219: add device tree docu
Date: Thu, 12 Jul 2018 06:42:11 +0000 [thread overview]
Message-ID: <1531377731.5323.2.camel@diehl.com> (raw)
In-Reply-To: <20180711151621.GA4084@rob-hp-laptop>
QW0gTWl0dHdvY2gsIGRlbiAxMS4wNy4yMDE4LCAwOToxNiAtMDYwMCBzY2hyaWViIFJvYiBI
ZXJyaW5nOg0KPiBPbiBUdWUsIEp1bCAxMCwgMjAxOCBhdCAwOTo0NDoxNUFNICswMDAwLCBE
ZW5pcyBPU1RFUkxBTkQgd3JvdGU6DQo+ID4gDQo+ID4gRnJvbTogRGVuaXMgT3N0ZXJsYW5k
IDxEZW5pcy5Pc3RlcmxhbmRAZGllaGwuY29tPg0KPiA+IA0KPiA+IFRoZSBkZXZpY2V0cmVl
IGRvY3VtZW50YXRpb24gZm9yIHRoZSBJU0wxMjE5IGRldmljZSB0cmVlDQo+ID4gYmluZGlu
ZyBpcyBhZGRlZCB3aXRoIGFuIHNob3J0IGV4YW1wbGUuIEl0IGlzIG5vdCBhIHRyaXZpYWwN
Cj4gPiBkZXZpY2UsIGJlY2F1c2UgaXQgc3VwcG9ydHMgdHdvIGludGVycnVwdCBzb3VjZXMu
DQo+IHMvc291Y2VzL3NvdXJjZXMvDQpPSw0KPiANCj4gPiANCj4gPiANCj4gPiBTaWduZWQt
b2ZmLWJ5OiBEZW5pcyBPc3RlcmxhbmQgPERlbmlzLk9zdGVybGFuZEBkaWVobC5jb20+DQo+
ID4gLS0tDQo+ID4gwqAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9ydGMvaXNpbCxpc2wxMjE5
LnR4dMKgwqB8IDI5ICsrKysrKysrKysrKysrKysrKysNCj4gPiDCoDEgZmlsZSBjaGFuZ2Vk
LCAyOSBpbnNlcnRpb25zKCspDQo+ID4gwqBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRh
dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3J0Yy9pc2lsLGlzbDEyMTkudHh0DQo+ID4gDQo+
ID4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9ydGMv
aXNpbCxpc2wxMjE5LnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9y
dGMvaXNpbCxpc2wxMjE5LnR4dA0KPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+ID4gaW5k
ZXggMDAwMDAwMDAwMDAwLi5mMjZmMWU5ZDRiZGUNCj4gPiAtLS0gL2Rldi9udWxsDQo+ID4g
KysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3J0Yy9pc2lsLGlzbDEy
MTkudHh0DQo+ID4gQEAgLTAsMCArMSwyOSBAQA0KPiA+ICtJbnRlcnNpbCBJU0wxMjE5IEky
QyBSVEMvQWxhcm0gY2hpcCB3aXRoIGV2ZW50IGluDQo+ID4gKw0KPiA+ICtJU0wxMjE5IGhh
cyBhZGRpdGlvbmFsIHBpbnMgRVZJTiBhbmQgI0VWREVUIGZvciB0YW1wZXIgZGV0ZWN0aW9u
Lg0KPiA+ICsNCj4gPiArUmVxdWlyZWQgcHJvcGVydGllcyBzdXBwb3J0ZWQgYnkgdGhlIGRl
dmljZToNCj4gPiArDQo+ID4gKyAtICJjb21wYXRpYmxlIjogbXVzdCBiZSAiaXNpbCxpc2wx
MjE5Ig0KPiA+ICsgLSAicmVnIjogSTJDIGJ1cyBhZGRyZXNzIG9mIHRoZSBkZXZpY2UNCj4g
PiArDQo+ID4gK09wdGlvbmFsIHByb3BlcnRpZXM6DQo+ID4gKw0KPiA+ICsgLSAiaW50ZXJy
dXB0LW5hbWVzIjogbGlzdCB3aGljaCBtYXkgY29udGFpbnMgImlycSIgYW5kICJldmRldCIN
Cj4gPiArIC0gImludGVycnVwdC1wYXJlbnQiLCAiaW50ZXJydXB0cyIsICJpbnRlcnJ1cHRz
LWV4dGVuZGVkIjoNCj4gPiArwqDCoMKgZm9yIHBhc3NpbmcgdGhlIGludGVycnVwdCBsaW5l
IG9mIHRoZSBTb0MgY29ubmVjdGVkIHRvICNJUlEgcGluDQo+ID4gK8KgwqDCoGFuZCAjRVZE
RVQgcGluIG9mIHRoZSBSVEMgY2hpcC4NCj4gSnVzdCBsaXN0ICdpbnRlcnJ1cHRzJyBhbmQg
aG93IG1hbnkgdGhlcmUgYXJlLiBpbnRlcnJ1cHQtcGFyZW50IGlzwqANCj4gaW1wbGllZCBh
bmQgbWF5IGJlIGluIGEgcGFyZW50IG5vZGUuIGludGVycnVwdHMtZXh0ZW5kZWQgaXMgYWxz
b8KgDQo+IGltcGxpY2l0bHkgYWxsb3dlZCBhcyBuZWVkZWQuDQpXaWxsIGNoYW5nZSB0bzog
ImludGVycnVwdHMiOiBsaXN0IG9mIGludGVycnVwdHMgZm9yICJpcnEiIGFuZCAiZXZkZXQi
DQo+IA0KPiA+IA0KPiA+ICsgLSAiaXNpbCxldi1ldmllbmIiOiBpZiBwcmVzZW50IGJpdCBj
YW4gYmUgc2V0IHRvIGRpc2FibGUgZXZlbnQgaW5wdXQgcHVsbC11cA0KPiA+ICsNCj4gPiAr
DQo+ID4gK0V4YW1wbGUgaXNsMTIxOSBub2RlIHdpdGggI0lSUSBwaW4gY29ubmVjdGVkIHRv
IFNvQyBncGlvMSBwaW4xMg0KPiA+ICsgYW5kICNFVkRFVCBwaW4gY29ubmVjdGVkIHRvIFNv
QyBncGlvMiBwaW4gMjQ6DQo+ID4gKw0KPiA+ICsJaXNsMTIxOTogcnRjQDY4IHsNCj4gPiAr
CQljb21wYXRpYmxlID0gImlzaWwsaXNsMTIxOSI7DQo+ID4gKwkJcmVnID0gPDB4Njg+Ow0K
PiA+ICsJCWludGVycnVwdC1uYW1lcyA9ICJpcnEiLCAiZXZkZXQiOw0KPiA+ICsJCWludGVy
cnVwdHMtZXh0ZW5kZWQgPSA8JmdwaW8xIDEyIElSUV9UWVBFX0VER0VfRkFMTElORz4sDQo+
ID4gKwkJCTwmZ3BpbzIgMjQgSVJRX1RZUEVfRURHRV9GQUxMSU5HPjsNCj4gPiArCX07DQo+
ID4gKw0KPiA+IC0tDQo+ID4gMi4xOC4wDQo+ID4gDQo+ID4gDQo+ID4gDQo+ID4gRGllaGwg
Q29ubmVjdGl2aXR5IFNvbHV0aW9ucyBHbWJIDQo+ID4gR2VzY2jDpGZ0c2bDvGhydW5nOiBI
b3JzdCBMZW9uYmVyZ2VyDQo+ID4gU2l0eiBkZXIgR2VzZWxsc2NoYWZ0OiBOw7xybmJlcmcg
LSBSZWdpc3RlcmdlcmljaHQ6IEFtdHNnZXJpY2h0DQo+ID4gTsO8cm5iZXJnOiBIUkIgMzIz
MTUNCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18N
Cj4gPiANCj4gPiBEZXIgSW5oYWx0IGRlciB2b3JzdGVoZW5kZW4gRS1NYWlsIGlzdCBuaWNo
dCByZWNodGxpY2ggYmluZGVuZC4gRGllc2UgRS1NYWlsIGVudGhhZWx0IHZlcnRyYXVsaWNo
ZSB1bmQvb2RlciByZWNodGxpY2ggZ2VzY2h1ZXR6dGUgSW5mb3JtYXRpb25lbi4NCj4gPiBJ
bmZvcm1pZXJlbiBTaWUgdW5zIGJpdHRlLCB3ZW5uIFNpZSBkaWVzZSBFLU1haWwgZmFlbHNj
aGxpY2hlcndlaXNlIGVyaGFsdGVuIGhhYmVuLiBCaXR0ZSBsb2VzY2hlbiBTaWUgaW4gZGll
c2VtIEZhbGwgZGllIE5hY2hyaWNodC4NCj4gPiBKZWRlIHVuZXJsYXVidGUgRm9ybSBkZXIg
UmVwcm9kdWt0aW9uLCBCZWthbm50Z2FiZSwgQWVuZGVydW5nLCBWZXJ0ZWlsdW5nIHVuZC9v
ZGVyIFB1Ymxpa2F0aW9uIGRpZXNlciBFLU1haWwgaXN0IHN0cmVuZ3N0ZW5zIHVudGVyc2Fn
dC4NCj4gPiBUaGUgY29udGVudHMgb2YgdGhlIGFib3ZlIG1lbnRpb25lZCBlLW1haWwgaXMg
bm90IGxlZ2FsbHkgYmluZGluZy4gVGhpcyBlLW1haWwgY29udGFpbnMgY29uZmlkZW50aWFs
IGFuZC9vciBsZWdhbGx5IHByb3RlY3RlZCBpbmZvcm1hdGlvbi4gUGxlYXNlIGluZm9ybSB1
cyBpZiB5b3UgaGF2ZSByZWNlaXZlZCB0aGlzIGUtbWFpbCBieQ0KPiA+IG1pc3Rha2UgYW5k
IGRlbGV0ZSBpdCBpbiBzdWNoIGEgY2FzZS4gRWFjaCB1bmF1dGhvcml6ZWQgcmVwcm9kdWN0
aW9uLCBkaXNjbG9zdXJlLCBhbHRlcmF0aW9uLCBkaXN0cmlidXRpb24gYW5kL29yIHB1Ymxp
Y2F0aW9uIG9mIHRoaXMgZS1tYWlsIGlzIHN0cmljdGx5IHByb2hpYml0ZWQuDQoNCkRpZWhs
IENvbm5lY3Rpdml0eSBTb2x1dGlvbnMgR21iSA0KR2VzY2jDpGZ0c2bDvGhydW5nOiBIb3Jz
dCBMZW9uYmVyZ2VyDQpTaXR6IGRlciBHZXNlbGxzY2hhZnQ6IE7DvHJuYmVyZyAtIFJlZ2lz
dGVyZ2VyaWNodDogQW10c2dlcmljaHQNCk7DvHJuYmVyZzogSFJCIDMyMzE1DQpfX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCg0KRGVyIEluaGFsdCBk
ZXIgdm9yc3RlaGVuZGVuIEUtTWFpbCBpc3QgbmljaHQgcmVjaHRsaWNoIGJpbmRlbmQuIERp
ZXNlIEUtTWFpbCBlbnRoYWVsdCB2ZXJ0cmF1bGljaGUgdW5kL29kZXIgcmVjaHRsaWNoIGdl
c2NodWV0enRlIEluZm9ybWF0aW9uZW4uDQpJbmZvcm1pZXJlbiBTaWUgdW5zIGJpdHRlLCB3
ZW5uIFNpZSBkaWVzZSBFLU1haWwgZmFlbHNjaGxpY2hlcndlaXNlIGVyaGFsdGVuIGhhYmVu
LiBCaXR0ZSBsb2VzY2hlbiBTaWUgaW4gZGllc2VtIEZhbGwgZGllIE5hY2hyaWNodC4NCkpl
ZGUgdW5lcmxhdWJ0ZSBGb3JtIGRlciBSZXByb2R1a3Rpb24sIEJla2FubnRnYWJlLCBBZW5k
ZXJ1bmcsIFZlcnRlaWx1bmcgdW5kL29kZXIgUHVibGlrYXRpb24gZGllc2VyIEUtTWFpbCBp
c3Qgc3RyZW5nc3RlbnMgdW50ZXJzYWd0Lg0KVGhlIGNvbnRlbnRzIG9mIHRoZSBhYm92ZSBt
ZW50aW9uZWQgZS1tYWlsIGlzIG5vdCBsZWdhbGx5IGJpbmRpbmcuIFRoaXMgZS1tYWlsIGNv
bnRhaW5zIGNvbmZpZGVudGlhbCBhbmQvb3IgbGVnYWxseSBwcm90ZWN0ZWQgaW5mb3JtYXRp
b24uIFBsZWFzZSBpbmZvcm0gdXMgaWYgeW91IGhhdmUgcmVjZWl2ZWQgdGhpcyBlLW1haWwg
YnkNCm1pc3Rha2UgYW5kIGRlbGV0ZSBpdCBpbiBzdWNoIGEgY2FzZS4gRWFjaCB1bmF1dGhv
cml6ZWQgcmVwcm9kdWN0aW9uLCBkaXNjbG9zdXJlLCBhbHRlcmF0aW9uLCBkaXN0cmlidXRp
b24gYW5kL29yIHB1YmxpY2F0aW9uIG9mIHRoaXMgZS1tYWlsIGlzIHN0cmljdGx5IHByb2hp
Yml0ZWQuIA0K
WARNING: multiple messages have this Message-ID (diff)
From: Denis OSTERLAND <denis.osterland@diehl.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"m.grzeschik@pengutronix.de" <m.grzeschik@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH v4 5/5] rtc: isl1219: add device tree docu
Date: Thu, 12 Jul 2018 06:42:11 +0000 [thread overview]
Message-ID: <1531377731.5323.2.camel@diehl.com> (raw)
In-Reply-To: <20180711151621.GA4084@rob-hp-laptop>
Am Mittwoch, den 11.07.2018, 09:16 -0600 schrieb Rob Herring:
> On Tue, Jul 10, 2018 at 09:44:15AM +0000, Denis OSTERLAND wrote:
> >
> > From: Denis Osterland <Denis.Osterland@diehl.com>
> >
> > The devicetree documentation for the ISL1219 device tree
> > binding is added with an short example. It is not a trivial
> > device, because it supports two interrupt souces.
> s/souces/sources/
OK
>
> >
> >
> > Signed-off-by: Denis Osterland <Denis.Osterland@diehl.com>
> > ---
> > .../devicetree/bindings/rtc/isil,isl1219.txt | 29 +++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/rtc/isil,isl1219.txt
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1219.txt b/Documentation/devicetree/bindings/rtc/isil,isl1219.txt
> > new file mode 100644
> > index 000000000000..f26f1e9d4bde
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/isil,isl1219.txt
> > @@ -0,0 +1,29 @@
> > +Intersil ISL1219 I2C RTC/Alarm chip with event in
> > +
> > +ISL1219 has additional pins EVIN and #EVDET for tamper detection.
> > +
> > +Required properties supported by the device:
> > +
> > + - "compatible": must be "isil,isl1219"
> > + - "reg": I2C bus address of the device
> > +
> > +Optional properties:
> > +
> > + - "interrupt-names": list which may contains "irq" and "evdet"
> > + - "interrupt-parent", "interrupts", "interrupts-extended":
> > + for passing the interrupt line of the SoC connected to #IRQ pin
> > + and #EVDET pin of the RTC chip.
> Just list 'interrupts' and how many there are. interrupt-parent is
> implied and may be in a parent node. interrupts-extended is also
> implicitly allowed as needed.
Will change to: "interrupts": list of interrupts for "irq" and "evdet"
>
> >
> > + - "isil,ev-evienb": if present bit can be set to disable event input pull-up
> > +
> > +
> > +Example isl1219 node with #IRQ pin connected to SoC gpio1 pin12
> > + and #EVDET pin connected to SoC gpio2 pin 24:
> > +
> > + isl1219: rtc@68 {
> > + compatible = "isil,isl1219";
> > + reg = <0x68>;
> > + interrupt-names = "irq", "evdet";
> > + interrupts-extended = <&gpio1 12 IRQ_TYPE_EDGE_FALLING>,
> > + <&gpio2 24 IRQ_TYPE_EDGE_FALLING>;
> > + };
> > +
> > --
> > 2.18.0
> >
> >
> >
> > Diehl Connectivity Solutions GmbH
> > Geschäftsführung: Horst Leonberger
> > Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
> > Nürnberg: HRB 32315
> > ___________________________________________________________________________________________________
> >
> > Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
> > Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
> > Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
> > The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
> > mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.
Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315
___________________________________________________________________________________________________
Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.
next prev parent reply other threads:[~2018-07-12 7:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 9:44 [PATCH v4 0/5] rtc: isl1208: fixes, documentation and isl1219 support Denis OSTERLAND
2018-07-10 9:44 ` [PATCH v4 1/5] rtc: sysfs: facilitate attribute add to rtc device Denis OSTERLAND
2018-07-18 7:25 ` Alexandre Belloni
2018-07-18 7:37 ` Denis OSTERLAND
2018-07-18 7:37 ` Denis OSTERLAND
2018-07-10 9:44 ` [PATCH v4 2/5] rtc: isl1208: add support for isl1219 with tamper detection Denis OSTERLAND
2018-07-10 13:20 ` kbuild test robot
2018-07-10 13:20 ` kbuild test robot
2018-07-10 14:06 ` Denis OSTERLAND
2018-07-10 14:06 ` Denis OSTERLAND
2018-07-11 6:01 ` Ye Xiaolong
2018-07-18 8:13 ` Alexandre Belloni
2018-07-18 10:44 ` Denis OSTERLAND
2018-07-18 10:44 ` Denis OSTERLAND
2018-07-10 9:44 ` [PATCH v4 4/5] rtc: isl1208: set ev-evienb bit from device tree Denis OSTERLAND
2018-07-10 9:44 ` [PATCH v4 5/5] rtc: isl1219: add device tree docu Denis OSTERLAND
2018-07-11 15:16 ` Rob Herring
2018-07-12 6:42 ` Denis OSTERLAND [this message]
2018-07-12 6:42 ` Denis OSTERLAND
2018-07-18 7:38 ` Alexandre Belloni
2018-07-18 7:55 ` Denis OSTERLAND
2018-07-18 7:55 ` Denis OSTERLAND
2018-07-10 9:44 ` [PATCH v4 3/5] rtc: isl1208: Add "evdet" interrupt source for isl1219 Denis OSTERLAND
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531377731.5323.2.camel@diehl.com \
--to=denis.osterland@diehl.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.