From: Denis OSTERLAND <denis.osterland@diehl.com>
To: "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"m.grzeschik@pengutronix.de" <m.grzeschik@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH v4 1/5] rtc: sysfs: facilitate attribute add to rtc device
Date: Wed, 18 Jul 2018 07:37:47 +0000 [thread overview]
Message-ID: <1531899467.6017.9.camel@diehl.com> (raw)
In-Reply-To: <20180718072508.GG3211@piout.net>
SGVsbG8sDQoNCnRoYW5rcyBmb3IgeW91ciBjb21tZW50cy4NCg0KQW0gTWl0dHdvY2gsIGRl
biAxOC4wNy4yMDE4LCAwOToyNSArMDIwMCBzY2hyaWViIEFsZXhhbmRyZSBCZWxsb25pOg0K
PiBIZWxsbywNCj4gDQo+IE9uIDEwLzA3LzIwMTggMDk6NDQ6MTUrMDAwMCwgRGVuaXMgT1NU
RVJMQU5EIHdyb3RlOg0KPiA+wqANCj4gPiArDQo+ID4gK3N0YXRpYyBzaXplX3QgcnRjX2dy
b3VwX2NvdW50KHN0cnVjdCBydGNfZGV2aWNlICpydGMpDQo+ID4gK3sNCj4gSSBkb24ndCBm
ZWVsIHRoaXMgZnVuY3Rpb24gaXMgbmVjZXNzYXJ5LCB5b3UgY2FuIGluY2x1ZGUgaXQgaW4g
X19ydGNfYWRkX2dyb3VwDQpJIHRoaW5rIHRoYXQgaXQgaXMgZWFzaWVyIHRvIHJlYWQsIGJ1
dCBzdXJlIEkgY2FuIGluY2x1ZGUgaXQuDQo+IA0KPiA+IA0KPiA+ICsNCj4gPiArc3RhdGlj
IGlubGluZSBpbnQNCj4gPiArX19ydGNfYWRkX2dyb3VwKHN0cnVjdCBydGNfZGV2aWNlICpy
dGMsIGNvbnN0IHN0cnVjdCBhdHRyaWJ1dGVfZ3JvdXAgKmdycCkNCj4gPiArew0KPiA+ICsJ
c2l6ZV90IGNudCA9IHJ0Y19ncm91cF9jb3VudChydGMpOw0KPiA+ICsJY29uc3Qgc3RydWN0
IGF0dHJpYnV0ZV9ncm91cCAqKmdyb3VwcywgKipvbGQ7DQo+ID4gKw0KPiA+ICsJZ3JvdXBz
ID0gZGV2bV9remFsbG9jKCZydGMtPmRldiwgKGNudCsyKSpzaXplb2YoKmdyb3VwcyksIEdG
UF9LRVJORUwpOw0KPiBQbGVhc2UgdXNlIGRldm1fa2NhbGxvYw0Kb2theQ0KPiANCj4gPiAN
Cj4gPiArCWlmIChJU19FUlJfT1JfTlVMTChncm91cHMpKQ0KPiA+ICsJCXJldHVybiBQVFJf
RVJSKGdyb3Vwcyk7DQo+ID4gKwltZW1jcHkoZ3JvdXBzLCBydGMtPmRldi5ncm91cHMsIGNu
dCpzaXplb2YoKmdyb3VwcykpOw0KPiA+ICsJZ3JvdXBzW2NudF0gPSBncnA7DQo+ID4gKw0K
PiA+ICsJb2xkID0gcnRjLT5kZXYuZ3JvdXBzOw0KPiA+ICsJcnRjLT5kZXYuZ3JvdXBzID0g
Z3JvdXBzOw0KPiA+ICsJaWYgKG9sZCAhPSBydGNfYXR0cl9ncm91cHMpDQo+ID4gKwkJZGV2
bV9rZnJlZSgmcnRjLT5kZXYsIG9sZCk7DQo+ID4gKw0KPiA+ICsJcmV0dXJuIDA7DQo+ID4g
K30NCj4gPiArDQo+ID4gK2ludCBydGNfYWRkX2dyb3VwKHN0cnVjdCBydGNfZGV2aWNlICpy
dGMsIGNvbnN0IHN0cnVjdCBhdHRyaWJ1dGVfZ3JvdXAgKmdycCkNCj4gPiArew0KPiA+ICsJ
cmV0dXJuIHJ0Yy0+ZGV2LmtvYmouc3RhdGVfaW5fc3lzZnMgPw0KPiA+ICsJCWRldm1fZGV2
aWNlX2FkZF9ncm91cCgmcnRjLT5kZXYsIGdycCkgOg0KPiA+ICsJCV9fcnRjX2FkZF9ncm91
cChydGMsIGdycCk7DQo+IFVzaW5nIGRldm1fZGV2aWNlX2FkZF9ncm91cCBhZnRlciBSVEMg
cmVnaXN0cmF0aW9uIGlzIHJhY3kgYW5kIHNob3VsZA0KPiBub3QgYmUgYWxsb3dlZC4gSSB3
b3VsZCBtZXJnZSBfX3J0Y19hZGRfZ3JvdXAgaW4gcnRjX2FkZF9ncm91cCBhbmQNCj4gcmV0
dXJuIGFuIGVycm9yIGlmIHJ0Yy0+cmVnaXN0ZXJlZCBpcyB0cnVlLg0KWW91IGFyZSByaWdo
dC4gQW4gZXJyb3IgaW4gdGhpcyBjYXNlIGlzIGJldHRlci4NCj4gDQo+IA0KDQpSZWdhcmRz
IERlbmlzDQoNCkRpZWhsIENvbm5lY3Rpdml0eSBTb2x1dGlvbnMgR21iSA0KR2VzY2jDpGZ0
c2bDvGhydW5nOiBIb3JzdCBMZW9uYmVyZ2VyDQpTaXR6IGRlciBHZXNlbGxzY2hhZnQ6IE7D
vHJuYmVyZyAtIFJlZ2lzdGVyZ2VyaWNodDogQW10c2dlcmljaHQNCk7DvHJuYmVyZzogSFJC
IDMyMzE1DQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18N
Cg0KRGVyIEluaGFsdCBkZXIgdm9yc3RlaGVuZGVuIEUtTWFpbCBpc3QgbmljaHQgcmVjaHRs
aWNoIGJpbmRlbmQuIERpZXNlIEUtTWFpbCBlbnRoYWVsdCB2ZXJ0cmF1bGljaGUgdW5kL29k
ZXIgcmVjaHRsaWNoIGdlc2NodWV0enRlIEluZm9ybWF0aW9uZW4uDQpJbmZvcm1pZXJlbiBT
aWUgdW5zIGJpdHRlLCB3ZW5uIFNpZSBkaWVzZSBFLU1haWwgZmFlbHNjaGxpY2hlcndlaXNl
IGVyaGFsdGVuIGhhYmVuLiBCaXR0ZSBsb2VzY2hlbiBTaWUgaW4gZGllc2VtIEZhbGwgZGll
IE5hY2hyaWNodC4NCkplZGUgdW5lcmxhdWJ0ZSBGb3JtIGRlciBSZXByb2R1a3Rpb24sIEJl
a2FubnRnYWJlLCBBZW5kZXJ1bmcsIFZlcnRlaWx1bmcgdW5kL29kZXIgUHVibGlrYXRpb24g
ZGllc2VyIEUtTWFpbCBpc3Qgc3RyZW5nc3RlbnMgdW50ZXJzYWd0Lg0KVGhlIGNvbnRlbnRz
IG9mIHRoZSBhYm92ZSBtZW50aW9uZWQgZS1tYWlsIGlzIG5vdCBsZWdhbGx5IGJpbmRpbmcu
IFRoaXMgZS1tYWlsIGNvbnRhaW5zIGNvbmZpZGVudGlhbCBhbmQvb3IgbGVnYWxseSBwcm90
ZWN0ZWQgaW5mb3JtYXRpb24uIFBsZWFzZSBpbmZvcm0gdXMgaWYgeW91IGhhdmUgcmVjZWl2
ZWQgdGhpcyBlLW1haWwgYnkNCm1pc3Rha2UgYW5kIGRlbGV0ZSBpdCBpbiBzdWNoIGEgY2Fz
ZS4gRWFjaCB1bmF1dGhvcml6ZWQgcmVwcm9kdWN0aW9uLCBkaXNjbG9zdXJlLCBhbHRlcmF0
aW9uLCBkaXN0cmlidXRpb24gYW5kL29yIHB1YmxpY2F0aW9uIG9mIHRoaXMgZS1tYWlsIGlz
IHN0cmljdGx5IHByb2hpYml0ZWQuIA0K
WARNING: multiple messages have this Message-ID (diff)
From: Denis OSTERLAND <denis.osterland@diehl.com>
To: "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"m.grzeschik@pengutronix.de" <m.grzeschik@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH v4 1/5] rtc: sysfs: facilitate attribute add to rtc device
Date: Wed, 18 Jul 2018 07:37:47 +0000 [thread overview]
Message-ID: <1531899467.6017.9.camel@diehl.com> (raw)
In-Reply-To: <20180718072508.GG3211@piout.net>
Hello,
thanks for your comments.
Am Mittwoch, den 18.07.2018, 09:25 +0200 schrieb Alexandre Belloni:
> Hello,
>
> On 10/07/2018 09:44:15+0000, Denis OSTERLAND wrote:
> >
> > +
> > +static size_t rtc_group_count(struct rtc_device *rtc)
> > +{
> I don't feel this function is necessary, you can include it in __rtc_add_group
I think that it is easier to read, but sure I can include it.
>
> >
> > +
> > +static inline int
> > +__rtc_add_group(struct rtc_device *rtc, const struct attribute_group *grp)
> > +{
> > + size_t cnt = rtc_group_count(rtc);
> > + const struct attribute_group **groups, **old;
> > +
> > + groups = devm_kzalloc(&rtc->dev, (cnt+2)*sizeof(*groups), GFP_KERNEL);
> Please use devm_kcalloc
okay
>
> >
> > + if (IS_ERR_OR_NULL(groups))
> > + return PTR_ERR(groups);
> > + memcpy(groups, rtc->dev.groups, cnt*sizeof(*groups));
> > + groups[cnt] = grp;
> > +
> > + old = rtc->dev.groups;
> > + rtc->dev.groups = groups;
> > + if (old != rtc_attr_groups)
> > + devm_kfree(&rtc->dev, old);
> > +
> > + return 0;
> > +}
> > +
> > +int rtc_add_group(struct rtc_device *rtc, const struct attribute_group *grp)
> > +{
> > + return rtc->dev.kobj.state_in_sysfs ?
> > + devm_device_add_group(&rtc->dev, grp) :
> > + __rtc_add_group(rtc, grp);
> Using devm_device_add_group after RTC registration is racy and should
> not be allowed. I would merge __rtc_add_group in rtc_add_group and
> return an error if rtc->registered is true.
You are right. An error in this case is better.
>
>
Regards Denis
Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315
___________________________________________________________________________________________________
Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.
next prev parent reply other threads:[~2018-07-18 8:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 9:44 [PATCH v4 0/5] rtc: isl1208: fixes, documentation and isl1219 support Denis OSTERLAND
2018-07-10 9:44 ` [PATCH v4 1/5] rtc: sysfs: facilitate attribute add to rtc device Denis OSTERLAND
2018-07-18 7:25 ` Alexandre Belloni
2018-07-18 7:37 ` Denis OSTERLAND [this message]
2018-07-18 7:37 ` Denis OSTERLAND
2018-07-10 9:44 ` [PATCH v4 2/5] rtc: isl1208: add support for isl1219 with tamper detection Denis OSTERLAND
2018-07-10 13:20 ` kbuild test robot
2018-07-10 13:20 ` kbuild test robot
2018-07-10 14:06 ` Denis OSTERLAND
2018-07-10 14:06 ` Denis OSTERLAND
2018-07-11 6:01 ` Ye Xiaolong
2018-07-18 8:13 ` Alexandre Belloni
2018-07-18 10:44 ` Denis OSTERLAND
2018-07-18 10:44 ` Denis OSTERLAND
2018-07-10 9:44 ` [PATCH v4 4/5] rtc: isl1208: set ev-evienb bit from device tree Denis OSTERLAND
2018-07-10 9:44 ` [PATCH v4 3/5] rtc: isl1208: Add "evdet" interrupt source for isl1219 Denis OSTERLAND
2018-07-10 9:44 ` [PATCH v4 5/5] rtc: isl1219: add device tree docu Denis OSTERLAND
2018-07-11 15:16 ` Rob Herring
2018-07-12 6:42 ` Denis OSTERLAND
2018-07-12 6:42 ` Denis OSTERLAND
2018-07-18 7:38 ` Alexandre Belloni
2018-07-18 7:55 ` Denis OSTERLAND
2018-07-18 7:55 ` Denis OSTERLAND
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531899467.6017.9.camel@diehl.com \
--to=denis.osterland@diehl.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.