All of lore.kernel.org
 help / color / mirror / Atom feed
From: rd.dunlab@gmail.com (rd_dunlab)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 2/4 v2] arc: fix type warnings in arc/mm/cache.c
Date: Thu, 26 Jul 2018 20:16:35 -0700	[thread overview]
Message-ID: <1532661395238@infradead.org> (raw)
In-Reply-To: <15326613951079@infradead.org>

From: Randy Dunlap <rdunlap@infradead.org>

Fix type warnings in arch/arc/mm/cache.c.

../arch/arc/mm/cache.c: In function 'flush_anon_page':
../arch/arc/mm/cache.c:1062:55: warning: passing argument 2 of '__flush_dcache_page' makes integer from pointer without a cast [-Wint-conversion]
  __flush_dcache_page((phys_addr_t)page_address(page), page_address(page));
                                                       ^~~~~~~~~~~~~~~~~~
../arch/arc/mm/cache.c:1013:59: note: expected 'long unsigned int' but argument is of type 'void *'
 void __flush_dcache_page(phys_addr_t paddr, unsigned long vaddr)
                                             ~~~~~~~~~~~~~~^~~~~

Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
Cc: Vineet Gupta <vgupta at synopsys.com>
Cc: linux-snps-arc at lists.infradead.org
Cc: Elad Kanfi <eladkan at mellanox.com>
Cc: Leon Romanovsky <leonro at mellanox.com>
Cc: Ofer Levi <oferle at mellanox.com>
---
v2: drop some spurious (accidental) patch lines

 arch/arc/mm/cache.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

--- linux-next-20180723.orig/arch/arc/mm/cache.c
+++ linux-next-20180723/arch/arc/mm/cache.c
@@ -1038,7 +1038,7 @@ void flush_cache_mm(struct mm_struct *mm
 void flush_cache_page(struct vm_area_struct *vma, unsigned long u_vaddr,
 		      unsigned long pfn)
 {
-	unsigned int paddr = pfn << PAGE_SHIFT;
+	phys_addr_t paddr = pfn << PAGE_SHIFT;
 
 	u_vaddr &= PAGE_MASK;
 
@@ -1058,8 +1058,9 @@ void flush_anon_page(struct vm_area_stru
 		     unsigned long u_vaddr)
 {
 	/* TBD: do we really need to clear the kernel mapping */
-	__flush_dcache_page(page_address(page), u_vaddr);
-	__flush_dcache_page(page_address(page), page_address(page));
+	__flush_dcache_page((phys_addr_t)page_address(page), u_vaddr);
+	__flush_dcache_page((phys_addr_t)page_address(page),
+			    (phys_addr_t)page_address(page));
 
 }
 


-- 

WARNING: multiple messages have this Message-ID (diff)
From: rd_dunlab <rd.dunlab@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	lkml <linux-kernel@vger.kernel.org>
Cc: Vineet Gupta <vgupta@synopsys.com>,
	linux-snps-arc@lists.infradead.org,
	Elad Kanfi <eladkan@mellanox.com>,
	Leon Romanovsky <leonro@mellanox.com>,
	Ofer Levi <oferle@mellanox.com>
Subject: [PATCH 2/4 v2] arc: fix type warnings in arc/mm/cache.c
Date: Thu, 26 Jul 2018 20:16:35 -0700	[thread overview]
Message-ID: <1532661395238@infradead.org> (raw)
In-Reply-To: <15326613951079@infradead.org>

From: Randy Dunlap <rdunlap@infradead.org>

Fix type warnings in arch/arc/mm/cache.c.

../arch/arc/mm/cache.c: In function 'flush_anon_page':
../arch/arc/mm/cache.c:1062:55: warning: passing argument 2 of '__flush_dcache_page' makes integer from pointer without a cast [-Wint-conversion]
  __flush_dcache_page((phys_addr_t)page_address(page), page_address(page));
                                                       ^~~~~~~~~~~~~~~~~~
../arch/arc/mm/cache.c:1013:59: note: expected 'long unsigned int' but argument is of type 'void *'
 void __flush_dcache_page(phys_addr_t paddr, unsigned long vaddr)
                                             ~~~~~~~~~~~~~~^~~~~

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Vineet Gupta <vgupta@synopsys.com>
Cc: linux-snps-arc@lists.infradead.org
Cc: Elad Kanfi <eladkan@mellanox.com>
Cc: Leon Romanovsky <leonro@mellanox.com>
Cc: Ofer Levi <oferle@mellanox.com>
---
v2: drop some spurious (accidental) patch lines

 arch/arc/mm/cache.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

--- linux-next-20180723.orig/arch/arc/mm/cache.c
+++ linux-next-20180723/arch/arc/mm/cache.c
@@ -1038,7 +1038,7 @@ void flush_cache_mm(struct mm_struct *mm
 void flush_cache_page(struct vm_area_struct *vma, unsigned long u_vaddr,
 		      unsigned long pfn)
 {
-	unsigned int paddr = pfn << PAGE_SHIFT;
+	phys_addr_t paddr = pfn << PAGE_SHIFT;
 
 	u_vaddr &= PAGE_MASK;
 
@@ -1058,8 +1058,9 @@ void flush_anon_page(struct vm_area_stru
 		     unsigned long u_vaddr)
 {
 	/* TBD: do we really need to clear the kernel mapping */
-	__flush_dcache_page(page_address(page), u_vaddr);
-	__flush_dcache_page(page_address(page), page_address(page));
+	__flush_dcache_page((phys_addr_t)page_address(page), u_vaddr);
+	__flush_dcache_page((phys_addr_t)page_address(page),
+			    (phys_addr_t)page_address(page));
 
 }
 


-- 


  parent reply	other threads:[~2018-07-27  3:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27  3:16 [PATCH 0/4 v2] arc: some allmodconfig build fixes rd_dunlab
2018-07-27  3:16 ` rd_dunlab
2018-07-27  3:16 ` [PATCH 4/4 v2] arc: fix printk warning in arc/plat-eznps/mtm.c rd_dunlab
2018-07-27  3:16   ` rd_dunlab
2018-07-29  7:03   ` Leon Romanovsky
2018-07-29  7:03     ` Leon Romanovsky
2018-07-27  3:16 ` [PATCH 3/4 v2] arc: fix data type errors in platform headers rd_dunlab
2018-07-27  3:16   ` rd_dunlab
2018-07-29  7:01   ` Leon Romanovsky
2018-07-29  7:01     ` Leon Romanovsky
2018-07-29 18:10     ` [PATCH 3/4 v3] " Randy Dunlap
2018-07-29 18:10       ` Randy Dunlap
2018-07-29 20:22       ` Leon Romanovsky
2018-07-29 20:22         ` Leon Romanovsky
2018-07-27  3:16 ` rd_dunlab [this message]
2018-07-27  3:16   ` [PATCH 2/4 v2] arc: fix type warnings in arc/mm/cache.c rd_dunlab
2018-07-27  3:16 ` [PATCH 1/4 v2] arc: fix build errors in arc/include/asm/delay.h rd_dunlab
2018-07-27  3:16   ` rd_dunlab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1532661395238@infradead.org \
    --to=rd.dunlab@gmail.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.