All of lore.kernel.org
 help / color / mirror / Atom feed
From: leonro@mellanox.com (Leon Romanovsky)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 3/4 v2] arc: fix data type errors in platform headers
Date: Sun, 29 Jul 2018 10:01:13 +0300	[thread overview]
Message-ID: <20180729070113.GC7157@mtr-leonro.mtl.com> (raw)
In-Reply-To: <1532661395712@infradead.org>

On Thu, Jul 26, 2018@08:16:35PM -0700, rd_dunlab wrote:
> From: Randy Dunlap <rdunlap at infradead.org>
>
> Add <asm-generic/types.h> to fix build errors.
> Both ctop.h and <soc/nps/common.h> use u32 types and cause many
> errors.
>
> Examples:
> ../include/soc/nps/common.h:71:4: error: unknown type name 'u32'
>     u32 __reserved:20, cluster:4, core:4, thread:4;
> ../include/soc/nps/common.h:76:3: error: unknown type name 'u32'
>    u32 value;
> ../include/soc/nps/common.h:124:4: error: unknown type name 'u32'
>     u32 base:8, cl_x:4, cl_y:4,
> ../include/soc/nps/common.h:127:3: error: unknown type name 'u32'
>    u32 value;
>
> ../arch/arc/plat-eznps/include/plat/ctop.h:83:4: error: unknown type name 'u32'
>     u32 gen:1, gdis:1, clk_gate_dis:1, asb:1,
> ../arch/arc/plat-eznps/include/plat/ctop.h:86:3: error: unknown type name 'u32'
>    u32 value;
> ../arch/arc/plat-eznps/include/plat/ctop.h:93:4: error: unknown type name 'u32'
>     u32 csa:22, dmsid:6, __reserved:3, cs:1;
> ../arch/arc/plat-eznps/include/plat/ctop.h:95:3: error: unknown type name 'u32'
>    u32 value;
>
> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
> Cc: Vineet Gupta <vgupta at synopsys.com>
> Cc: linux-snps-arc at lists.infradead.org
> Cc: Elad Kanfi <eladkan at mellanox.com>
> Cc: Leon Romanovsky <leonro at mellanox.com>
> Cc: Ofer Levi <oferle at mellanox.com>
> ---
> v2: no change
>
>  arch/arc/plat-eznps/include/plat/ctop.h |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20180723.orig/arch/arc/plat-eznps/include/plat/ctop.h
> +++ linux-next-20180723/arch/arc/plat-eznps/include/plat/ctop.h
> @@ -21,6 +21,7 @@
>  #error "Incorrect ctop.h include"
>  #endif
>
> +#include <asm-generic/types.h>

I'm not familiar with arch/* code, so maybe my question will sound
naive., but why "asm-generic/types.h" and not "linux/types.h"?

Thanks for fixing build.

>  #include <soc/nps/common.h>
>
>  /* core auxiliary registers */
>
>
> --
>

WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leonro@mellanox.com>
To: rd_dunlab <rd.dunlab@gmail.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Vineet Gupta <vgupta@synopsys.com>,
	linux-snps-arc@lists.infradead.org,
	Elad Kanfi <eladkan@mellanox.com>,
	Ofer Levi <oferle@mellanox.com>
Subject: Re: [PATCH 3/4 v2] arc: fix data type errors in platform headers
Date: Sun, 29 Jul 2018 10:01:13 +0300	[thread overview]
Message-ID: <20180729070113.GC7157@mtr-leonro.mtl.com> (raw)
In-Reply-To: <1532661395712@infradead.org>

On Thu, Jul 26, 2018 at 08:16:35PM -0700, rd_dunlab wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Add <asm-generic/types.h> to fix build errors.
> Both ctop.h and <soc/nps/common.h> use u32 types and cause many
> errors.
>
> Examples:
> ../include/soc/nps/common.h:71:4: error: unknown type name 'u32'
>     u32 __reserved:20, cluster:4, core:4, thread:4;
> ../include/soc/nps/common.h:76:3: error: unknown type name 'u32'
>    u32 value;
> ../include/soc/nps/common.h:124:4: error: unknown type name 'u32'
>     u32 base:8, cl_x:4, cl_y:4,
> ../include/soc/nps/common.h:127:3: error: unknown type name 'u32'
>    u32 value;
>
> ../arch/arc/plat-eznps/include/plat/ctop.h:83:4: error: unknown type name 'u32'
>     u32 gen:1, gdis:1, clk_gate_dis:1, asb:1,
> ../arch/arc/plat-eznps/include/plat/ctop.h:86:3: error: unknown type name 'u32'
>    u32 value;
> ../arch/arc/plat-eznps/include/plat/ctop.h:93:4: error: unknown type name 'u32'
>     u32 csa:22, dmsid:6, __reserved:3, cs:1;
> ../arch/arc/plat-eznps/include/plat/ctop.h:95:3: error: unknown type name 'u32'
>    u32 value;
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Vineet Gupta <vgupta@synopsys.com>
> Cc: linux-snps-arc@lists.infradead.org
> Cc: Elad Kanfi <eladkan@mellanox.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>
> Cc: Ofer Levi <oferle@mellanox.com>
> ---
> v2: no change
>
>  arch/arc/plat-eznps/include/plat/ctop.h |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20180723.orig/arch/arc/plat-eznps/include/plat/ctop.h
> +++ linux-next-20180723/arch/arc/plat-eznps/include/plat/ctop.h
> @@ -21,6 +21,7 @@
>  #error "Incorrect ctop.h include"
>  #endif
>
> +#include <asm-generic/types.h>

I'm not familiar with arch/* code, so maybe my question will sound
naive., but why "asm-generic/types.h" and not "linux/types.h"?

Thanks for fixing build.

>  #include <soc/nps/common.h>
>
>  /* core auxiliary registers */
>
>
> --
>

  reply	other threads:[~2018-07-29  7:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27  3:16 [PATCH 0/4 v2] arc: some allmodconfig build fixes rd_dunlab
2018-07-27  3:16 ` rd_dunlab
2018-07-27  3:16 ` [PATCH 4/4 v2] arc: fix printk warning in arc/plat-eznps/mtm.c rd_dunlab
2018-07-27  3:16   ` rd_dunlab
2018-07-29  7:03   ` Leon Romanovsky
2018-07-29  7:03     ` Leon Romanovsky
2018-07-27  3:16 ` [PATCH 3/4 v2] arc: fix data type errors in platform headers rd_dunlab
2018-07-27  3:16   ` rd_dunlab
2018-07-29  7:01   ` Leon Romanovsky [this message]
2018-07-29  7:01     ` Leon Romanovsky
2018-07-29 18:10     ` [PATCH 3/4 v3] " Randy Dunlap
2018-07-29 18:10       ` Randy Dunlap
2018-07-29 20:22       ` Leon Romanovsky
2018-07-29 20:22         ` Leon Romanovsky
2018-07-27  3:16 ` [PATCH 2/4 v2] arc: fix type warnings in arc/mm/cache.c rd_dunlab
2018-07-27  3:16   ` rd_dunlab
2018-07-27  3:16 ` [PATCH 1/4 v2] arc: fix build errors in arc/include/asm/delay.h rd_dunlab
2018-07-27  3:16   ` rd_dunlab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180729070113.GC7157@mtr-leonro.mtl.com \
    --to=leonro@mellanox.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.