From: rd.dunlab@gmail.com (rd_dunlab)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 1/4 v2] arc: fix build errors in arc/include/asm/delay.h
Date: Thu, 26 Jul 2018 20:16:35 -0700 [thread overview]
Message-ID: <15326613952848@infradead.org> (raw)
In-Reply-To: <15326613951079@infradead.org>
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors in arch/arc/'s delay.h:
- add "extern unsigned long loops_per_jiffy;"
- add <asm-generic/types.h> for "u64"
In file included from ../drivers/infiniband/hw/cxgb3/cxio_hal.c:32:
../arch/arc/include/asm/delay.h: In function '__udelay':
../arch/arc/include/asm/delay.h:61:12: error: 'u64' undeclared (first use in this function)
loops = ((u64) usecs * 4295 * HZ * loops_per_jiffy) >> 32;
^~~
In file included from ../drivers/infiniband/hw/cxgb3/cxio_hal.c:32:
../arch/arc/include/asm/delay.h: In function '__udelay':
../arch/arc/include/asm/delay.h:63:37: error: 'loops_per_jiffy' undeclared (first use in this function)
loops = ((u64) usecs * 4295 * HZ * loops_per_jiffy) >> 32;
^~~~~~~~~~~~~~~
Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
Cc: Vineet Gupta <vgupta at synopsys.com>
Cc: linux-snps-arc at lists.infradead.org
Cc: Elad Kanfi <eladkan at mellanox.com>
Cc: Leon Romanovsky <leonro at mellanox.com>
Cc: Ofer Levi <oferle at mellanox.com>
---
v2: add extern for loops_per_jiffy instead of including <linux/delay.h>
for it
arch/arc/include/asm/delay.h | 3 +++
1 file changed, 3 insertions(+)
--- linux-next-20180723.orig/arch/arc/include/asm/delay.h
+++ linux-next-20180723/arch/arc/include/asm/delay.h
@@ -17,8 +17,11 @@
#ifndef __ASM_ARC_UDELAY_H
#define __ASM_ARC_UDELAY_H
+#include <asm-generic/types.h>
#include <asm/param.h> /* HZ */
+extern unsigned long loops_per_jiffy;
+
static inline void __delay(unsigned long loops)
{
__asm__ __volatile__(
--
WARNING: multiple messages have this Message-ID (diff)
From: rd_dunlab <rd.dunlab@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>,
lkml <linux-kernel@vger.kernel.org>
Cc: Vineet Gupta <vgupta@synopsys.com>,
linux-snps-arc@lists.infradead.org,
Elad Kanfi <eladkan@mellanox.com>,
Leon Romanovsky <leonro@mellanox.com>,
Ofer Levi <oferle@mellanox.com>
Subject: [PATCH 1/4 v2] arc: fix build errors in arc/include/asm/delay.h
Date: Thu, 26 Jul 2018 20:16:35 -0700 [thread overview]
Message-ID: <15326613952848@infradead.org> (raw)
In-Reply-To: <15326613951079@infradead.org>
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors in arch/arc/'s delay.h:
- add "extern unsigned long loops_per_jiffy;"
- add <asm-generic/types.h> for "u64"
In file included from ../drivers/infiniband/hw/cxgb3/cxio_hal.c:32:
../arch/arc/include/asm/delay.h: In function '__udelay':
../arch/arc/include/asm/delay.h:61:12: error: 'u64' undeclared (first use in this function)
loops = ((u64) usecs * 4295 * HZ * loops_per_jiffy) >> 32;
^~~
In file included from ../drivers/infiniband/hw/cxgb3/cxio_hal.c:32:
../arch/arc/include/asm/delay.h: In function '__udelay':
../arch/arc/include/asm/delay.h:63:37: error: 'loops_per_jiffy' undeclared (first use in this function)
loops = ((u64) usecs * 4295 * HZ * loops_per_jiffy) >> 32;
^~~~~~~~~~~~~~~
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Vineet Gupta <vgupta@synopsys.com>
Cc: linux-snps-arc@lists.infradead.org
Cc: Elad Kanfi <eladkan@mellanox.com>
Cc: Leon Romanovsky <leonro@mellanox.com>
Cc: Ofer Levi <oferle@mellanox.com>
---
v2: add extern for loops_per_jiffy instead of including <linux/delay.h>
for it
arch/arc/include/asm/delay.h | 3 +++
1 file changed, 3 insertions(+)
--- linux-next-20180723.orig/arch/arc/include/asm/delay.h
+++ linux-next-20180723/arch/arc/include/asm/delay.h
@@ -17,8 +17,11 @@
#ifndef __ASM_ARC_UDELAY_H
#define __ASM_ARC_UDELAY_H
+#include <asm-generic/types.h>
#include <asm/param.h> /* HZ */
+extern unsigned long loops_per_jiffy;
+
static inline void __delay(unsigned long loops)
{
__asm__ __volatile__(
--
next prev parent reply other threads:[~2018-07-27 3:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 3:16 [PATCH 0/4 v2] arc: some allmodconfig build fixes rd_dunlab
2018-07-27 3:16 ` rd_dunlab
2018-07-27 3:16 ` rd_dunlab [this message]
2018-07-27 3:16 ` [PATCH 1/4 v2] arc: fix build errors in arc/include/asm/delay.h rd_dunlab
2018-07-27 3:16 ` [PATCH 3/4 v2] arc: fix data type errors in platform headers rd_dunlab
2018-07-27 3:16 ` rd_dunlab
2018-07-29 7:01 ` Leon Romanovsky
2018-07-29 7:01 ` Leon Romanovsky
2018-07-29 18:10 ` [PATCH 3/4 v3] " Randy Dunlap
2018-07-29 18:10 ` Randy Dunlap
2018-07-29 20:22 ` Leon Romanovsky
2018-07-29 20:22 ` Leon Romanovsky
2018-07-27 3:16 ` [PATCH 2/4 v2] arc: fix type warnings in arc/mm/cache.c rd_dunlab
2018-07-27 3:16 ` rd_dunlab
2018-07-27 3:16 ` [PATCH 4/4 v2] arc: fix printk warning in arc/plat-eznps/mtm.c rd_dunlab
2018-07-27 3:16 ` rd_dunlab
2018-07-29 7:03 ` Leon Romanovsky
2018-07-29 7:03 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15326613952848@infradead.org \
--to=rd.dunlab@gmail.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.