All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Leonidas P. Papadakos" <papadakospan@gmail.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: "Jose Abreu" <jose.abreu@synopsys.com>,
	"Alexandre Torgue" <alexandre.torgue@st.com>,
	netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	"Christoph Müllner" <christoph.muellner@theobroma-systems.com>,
	"Klaus Goger" <klaus.goger@theobroma-systems.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Philipp Tomsich" <philipp.tomsich@theobroma-systems.com>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"Heiko Stübner" <heiko@sntech.de>
Subject: Re: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices
Date: Fri, 12 Apr 2019 00:09:30 +0300	[thread overview]
Message-ID: <1555016970.28872.0@gmail.com> (raw)
In-Reply-To: <1554489537.1199.0@gmail.com>


At this point I've settled on snps,txpbl = <0x20> by itself.
If I increase the MTU from the default of 1500 I get a stack trace and 
link reset almost immediately:
(https://pastebin.com/raw/5JBtfWei)
whether TX Checksumming is ON or OFF.

That said, with the default MTU, I get better speeds when TX 
Checksumming is on and the PBL tweak is set.

Is there a better option in the horizon for the near future?
At least for the Renegade (the only board I have to test) it can serve 
as a temporary workaround.
Should I make a patch to replace force_thresh_dma_mode with txbpl 
<0x20> for the Renegade specifically?

In any case I would be happy to help as much as I can to figure out if 
it's a board specific thing, or SoC, or even an issue of the Ethernet 
device itself.



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Leonidas P. Papadakos" <papadakospan@gmail.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: "Jose Abreu" <jose.abreu@synopsys.com>,
	"Philipp Tomsich" <philipp.tomsich@theobroma-systems.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Christoph Müllner" <christoph.muellner@theobroma-systems.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@st.com>,
	netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"Klaus Goger" <klaus.goger@theobroma-systems.com>
Subject: Re: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices
Date: Fri, 12 Apr 2019 00:09:30 +0300	[thread overview]
Message-ID: <1555016970.28872.0@gmail.com> (raw)
In-Reply-To: <1554489537.1199.0@gmail.com>


At this point I've settled on snps,txpbl = <0x20> by itself.
If I increase the MTU from the default of 1500 I get a stack trace and 
link reset almost immediately:
(https://pastebin.com/raw/5JBtfWei)
whether TX Checksumming is ON or OFF.

That said, with the default MTU, I get better speeds when TX 
Checksumming is on and the PBL tweak is set.

Is there a better option in the horizon for the near future?
At least for the Renegade (the only board I have to test) it can serve 
as a temporary workaround.
Should I make a patch to replace force_thresh_dma_mode with txbpl 
<0x20> for the Renegade specifically?

In any case I would be happy to help as much as I can to figure out if 
it's a board specific thing, or SoC, or even an issue of the Ethernet 
device itself.



  reply	other threads:[~2019-04-11 21:09 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 18:18 [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices Leonidas P. Papadakos
2019-04-01 18:18 ` Leonidas P. Papadakos
2019-04-01 18:31 ` Heiko Stübner
2019-04-01 18:31   ` Heiko Stübner
2019-04-01 18:54 ` Robin Murphy
2019-04-01 18:54   ` Robin Murphy
2019-04-01 19:06   ` Heiko Stübner
2019-04-01 19:06     ` Heiko Stübner
2019-04-01 19:12     ` Philipp Tomsich
2019-04-01 19:12       ` Philipp Tomsich
2019-04-02  7:59       ` Jose Abreu
2019-04-02  7:59         ` Jose Abreu
2019-04-02 11:49         ` Robin Murphy
2019-04-02 11:49           ` Robin Murphy
2019-04-02 11:53           ` Jose Abreu
2019-04-02 11:53             ` Jose Abreu
2019-04-02 22:08             ` Robin Murphy
2019-04-02 22:08               ` Robin Murphy
2019-04-02 22:48               ` Leonidas P. Papadakos
2019-04-02 22:48                 ` Leonidas P. Papadakos
2019-04-03  7:55                 ` Jose Abreu
2019-04-03  7:55                   ` Jose Abreu
2019-04-03 15:35                   ` Leonidas P. Papadakos
2019-04-03 15:35                     ` Leonidas P. Papadakos
2019-04-03 15:55                     ` Leonidas P. Papadakos
2019-04-03 15:55                       ` Leonidas P. Papadakos
2019-04-03 16:12                       ` Robin Murphy
2019-04-03 16:12                         ` Robin Murphy
2019-04-05 10:24                         ` Jose Abreu
2019-04-05 10:24                           ` Jose Abreu
2019-04-05 17:58                           ` Leonidas P. Papadakos
2019-04-05 17:58                             ` Leonidas P. Papadakos
2019-04-05 18:14                           ` Leonidas P. Papadakos
2019-04-05 18:14                             ` Leonidas P. Papadakos
2019-04-05 18:29                             ` Robin Murphy
2019-04-05 18:29                               ` Robin Murphy
2019-04-05 18:38                               ` Leonidas P. Papadakos
2019-04-05 18:38                                 ` Leonidas P. Papadakos
2019-04-11 21:09                                 ` Leonidas P. Papadakos [this message]
2019-04-11 21:09                                   ` Leonidas P. Papadakos
2019-04-12  7:35                                   ` Jose Abreu
2019-04-12  7:35                                     ` Jose Abreu
2019-04-12 11:13                                     ` Leonidas P. Papadakos
2019-04-12 11:13                                       ` Leonidas P. Papadakos
2019-04-15  8:15                                       ` Jose Abreu
2019-04-15  8:15                                         ` Jose Abreu
2019-04-15 21:45                                         ` Leonidas P. Papadakos
2019-04-15 21:45                                           ` Leonidas P. Papadakos
2019-04-15 22:19                                           ` Leonidas P. Papadakos
2019-04-15 22:19                                             ` Leonidas P. Papadakos
2019-04-16  8:01                                             ` Jose Abreu
2019-04-16  8:01                                               ` Jose Abreu
2019-04-16 10:03                                               ` Leonidas P. Papadakos
2019-04-16 10:03                                                 ` Leonidas P. Papadakos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1555016970.28872.0@gmail.com \
    --to=papadakospan@gmail.com \
    --cc=alexandre.torgue@st.com \
    --cc=christoph.muellner@theobroma-systems.com \
    --cc=heiko@sntech.de \
    --cc=jose.abreu@synopsys.com \
    --cc=klaus.goger@theobroma-systems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=philipp.tomsich@theobroma-systems.com \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.