All of lore.kernel.org
 help / color / mirror / Atom feed
From: xiaolei li <xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Miquel Raynal <miquel.raynal-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
Cc: richard-/L3Ra7n9ekc@public.gmane.org,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH 1/5] mtd: rawnand: mtk: Correct low level time calculation of r/w cycle
Date: Tue, 30 Apr 2019 08:59:42 +0800	[thread overview]
Message-ID: <1556585982.26455.52.camel@mhfsdcap03> (raw)
In-Reply-To: <20190429120226.43589cdd@xps13>

On Mon, 2019-04-29 at 12:02 +0200, Miquel Raynal wrote:
> Hi xiaolei,
> 
> xiaolei li <xiaolei.li@mediatek.com> wrote on Mon, 29 Apr 2019 17:35:53
> +0800:
> 
> > Hi Miquel,
> > 
> > Thanks for your review.
> > 
> > 
> > On Mon, 2019-04-29 at 11:03 +0200, Miquel Raynal wrote:
> > > Hi Xiaolei,
> > > 
> > > Xiaolei Li <xiaolei.li@mediatek.com> wrote on Mon, 29 Apr 2019 14:38:30
> > > +0800:
> > >   
> > > > At present, the flow of calculating AC timing of read/write cycle in SDR
> > > > mode is that:
> > > > At first, calculate high hold time which is valid for both read and write
> > > > cycle using the max value between tREH_min and tWH_min.
> > > > Secondly, calculate WE# pulse width using tWP_min.
> > > > Thridly, calculate RE# pulse width using the bigger one between tREA_max
> > > > and tRP_min.
> > > > 
> > > > But NAND SPEC shows that Controller should also meet write/read cycle time.
> > > > That is write cycle time should be more than tWC_min and read cycle should
> > > > be more than tRC_min. Obviously, we do not achieve that now.
> > > > 
> > > > This patch corrects the low level time calculation to meet minimum
> > > > read/write cycle time required. After getting the high hold time, WE# low
> > > > level time will be promised to meet tWP_min and tWC_min requirement,
> > > > and RE# low level time will be promised to meet tREA_max, tRP_min and
> > > > tRC_min requirement.
> > > > 
> > > > Fixes: 93db446a424c ("mtd: nand: move raw NAND related code to the raw/ subdir")  
> > > 
> > > This is definitely not the faulty patch. Please use --follow when
> > > searching for the culprit, to avoid being blocked by the
> > > renaming/moving work.  
> > Yes. This issue exists before raw/ sudir being created.
> > 
> > The faulty patch should be 'commit edfee3619c49 ("mtd: nand: mtk: add
> > ->setup_data_interface() hook")' which cannot be found in git history  
> > now.
> > 
> > Should I list it here?
> 
> What do you mean? This commit exists, I can actually "git show" it.
> 
Sorry. I find it. Will fix it in next patch version.
Thanks.

> 
> Thanks,
> Miquèl



_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: xiaolei li <xiaolei.li@mediatek.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: richard@nod.at, linux-mediatek@lists.infradead.org,
	linux-mtd@lists.infradead.org, srv_heupstream@mediatek.com
Subject: Re: [PATCH 1/5] mtd: rawnand: mtk: Correct low level time calculation of r/w cycle
Date: Tue, 30 Apr 2019 08:59:42 +0800	[thread overview]
Message-ID: <1556585982.26455.52.camel@mhfsdcap03> (raw)
In-Reply-To: <20190429120226.43589cdd@xps13>

On Mon, 2019-04-29 at 12:02 +0200, Miquel Raynal wrote:
> Hi xiaolei,
> 
> xiaolei li <xiaolei.li@mediatek.com> wrote on Mon, 29 Apr 2019 17:35:53
> +0800:
> 
> > Hi Miquel,
> > 
> > Thanks for your review.
> > 
> > 
> > On Mon, 2019-04-29 at 11:03 +0200, Miquel Raynal wrote:
> > > Hi Xiaolei,
> > > 
> > > Xiaolei Li <xiaolei.li@mediatek.com> wrote on Mon, 29 Apr 2019 14:38:30
> > > +0800:
> > >   
> > > > At present, the flow of calculating AC timing of read/write cycle in SDR
> > > > mode is that:
> > > > At first, calculate high hold time which is valid for both read and write
> > > > cycle using the max value between tREH_min and tWH_min.
> > > > Secondly, calculate WE# pulse width using tWP_min.
> > > > Thridly, calculate RE# pulse width using the bigger one between tREA_max
> > > > and tRP_min.
> > > > 
> > > > But NAND SPEC shows that Controller should also meet write/read cycle time.
> > > > That is write cycle time should be more than tWC_min and read cycle should
> > > > be more than tRC_min. Obviously, we do not achieve that now.
> > > > 
> > > > This patch corrects the low level time calculation to meet minimum
> > > > read/write cycle time required. After getting the high hold time, WE# low
> > > > level time will be promised to meet tWP_min and tWC_min requirement,
> > > > and RE# low level time will be promised to meet tREA_max, tRP_min and
> > > > tRC_min requirement.
> > > > 
> > > > Fixes: 93db446a424c ("mtd: nand: move raw NAND related code to the raw/ subdir")  
> > > 
> > > This is definitely not the faulty patch. Please use --follow when
> > > searching for the culprit, to avoid being blocked by the
> > > renaming/moving work.  
> > Yes. This issue exists before raw/ sudir being created.
> > 
> > The faulty patch should be 'commit edfee3619c49 ("mtd: nand: mtk: add
> > ->setup_data_interface() hook")' which cannot be found in git history  
> > now.
> > 
> > Should I list it here?
> 
> What do you mean? This commit exists, I can actually "git show" it.
> 
Sorry. I find it. Will fix it in next patch version.
Thanks.

> 
> Thanks,
> Miquèl



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2019-04-30  0:59 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29  6:38 [PATCH 0/5] MTK NAND driver improvements and fixes Xiaolei Li
2019-04-29  6:38 ` Xiaolei Li
2019-04-29  6:38 ` [PATCH 1/5] mtd: rawnand: mtk: Correct low level time calculation of r/w cycle Xiaolei Li
2019-04-29  6:38   ` Xiaolei Li
     [not found]   ` <20190429063834.45967-2-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-04-29  9:03     ` Miquel Raynal
2019-04-29  9:03       ` Miquel Raynal
2019-04-29  9:35       ` xiaolei li
2019-04-29  9:35         ` xiaolei li
2019-04-29 10:02         ` Miquel Raynal
2019-04-29 10:02           ` Miquel Raynal
2019-04-30  0:59           ` xiaolei li [this message]
2019-04-30  0:59             ` xiaolei li
2019-04-29  6:38 ` [PATCH 2/5] mtd: rawnand: mtk: Improve data sampling timing for read cycle Xiaolei Li
2019-04-29  6:38   ` Xiaolei Li
     [not found]   ` <20190429063834.45967-3-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-04-29  9:10     ` Miquel Raynal
2019-04-29  9:10       ` Miquel Raynal
2019-04-29  9:49       ` xiaolei li
2019-04-29  6:38 ` [PATCH 3/5] mtd: rawnand: mtk: Add validity check for CE# pin setting Xiaolei Li
2019-04-29  6:38   ` Xiaolei Li
     [not found]   ` <20190429063834.45967-4-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-04-29  9:11     ` Miquel Raynal
2019-04-29  9:11       ` Miquel Raynal
2019-04-29  6:38 ` [PATCH 4/5] mtd: rawnand: mtk: Fix wrongly assigned oob buffer pointer issue Xiaolei Li
2019-04-29  6:38   ` Xiaolei Li
     [not found]   ` <20190429063834.45967-5-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-04-29  9:14     ` Miquel Raynal
2019-04-29  9:14       ` Miquel Raynal
2019-04-29  9:52       ` xiaolei li
2019-04-29  9:52         ` xiaolei li
2019-04-29  6:38 ` [PATCH 5/5] mtd: rawnand: mtk: Setup empty page threshold correctly Xiaolei Li
2019-04-29  6:38   ` Xiaolei Li
     [not found]   ` <20190429063834.45967-6-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-04-29  9:22     ` Miquel Raynal
2019-04-29  9:22       ` Miquel Raynal
2019-04-29  9:57       ` xiaolei li
2019-04-29  9:57         ` xiaolei li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1556585982.26455.52.camel@mhfsdcap03 \
    --to=xiaolei.li-nus5lvnupcjwk0htik3j/w@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=miquel.raynal-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org \
    --cc=richard-/L3Ra7n9ekc@public.gmane.org \
    --cc=srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.