From: Miquel Raynal <miquel.raynal-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
To: Xiaolei Li <xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: richard-/L3Ra7n9ekc@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH 5/5] mtd: rawnand: mtk: Setup empty page threshold correctly
Date: Mon, 29 Apr 2019 11:22:00 +0200 [thread overview]
Message-ID: <20190429112200.42a86815@xps13> (raw)
In-Reply-To: <20190429063834.45967-6-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Hi Xiaolei,
Xiaolei Li <xiaolei.li@mediatek.com> wrote on Mon, 29 Apr 2019 14:38:34
+0800:
> MTK NAND Controller has the ability to check whether read data are
> mostly 0xff by comparing zero bit conut of read data with empty
count ?
> threshold automatically.
>
> But now we never set this threshold and always make it be default value
> which is 10.
>
> This patch fixes this problem by setting empty threshold as the product
> of read sector count and ecc strength.
Do we use these feature yet?
s/ecc/ECC/
>
> Fixes: 93db446a424c ("mtd: nand: move raw NAND related code to the raw/ subdir")
Ditto.
> Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com>
> ---
> drivers/mtd/nand/raw/mtk_nand.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/mtk_nand.c b/drivers/mtd/nand/raw/mtk_nand.c
> index cf5e50e704ae..675d4faa3480 100644
> --- a/drivers/mtd/nand/raw/mtk_nand.c
> +++ b/drivers/mtd/nand/raw/mtk_nand.c
> @@ -94,6 +94,7 @@
> #define NFI_MASTER_STA (0x224)
> #define MASTER_STA_MASK (0x0FFF)
> #define NFI_EMPTY_THRESH (0x23C)
> +#define EMPTY_THRESH_MASK GENMASK(7, 0)
>
> #define MTK_NAME "mtk-nand"
> #define KB(x) ((x) * 1024UL)
> @@ -931,6 +932,10 @@ static int mtk_nfc_read_subpage(struct mtd_info *mtd, struct nand_chip *chip,
> return -EINVAL;
> }
>
> + /* Setup empty threshold */
> + reg = max(sectors * chip->ecc.strength, EMPTY_THRESH_MASK);
> + nfi_writel(nfc, reg, NFI_EMPTY_THRESH);
> +
> reg = nfi_readw(nfc, NFI_CNFG);
> reg |= CNFG_READ_EN | CNFG_DMA_BURST_EN | CNFG_AHB;
> if (!raw) {
Thanks,
Miquèl
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Xiaolei Li <xiaolei.li@mediatek.com>
Cc: richard@nod.at, linux-mediatek@lists.infradead.org,
linux-mtd@lists.infradead.org, srv_heupstream@mediatek.com
Subject: Re: [PATCH 5/5] mtd: rawnand: mtk: Setup empty page threshold correctly
Date: Mon, 29 Apr 2019 11:22:00 +0200 [thread overview]
Message-ID: <20190429112200.42a86815@xps13> (raw)
In-Reply-To: <20190429063834.45967-6-xiaolei.li@mediatek.com>
Hi Xiaolei,
Xiaolei Li <xiaolei.li@mediatek.com> wrote on Mon, 29 Apr 2019 14:38:34
+0800:
> MTK NAND Controller has the ability to check whether read data are
> mostly 0xff by comparing zero bit conut of read data with empty
count ?
> threshold automatically.
>
> But now we never set this threshold and always make it be default value
> which is 10.
>
> This patch fixes this problem by setting empty threshold as the product
> of read sector count and ecc strength.
Do we use these feature yet?
s/ecc/ECC/
>
> Fixes: 93db446a424c ("mtd: nand: move raw NAND related code to the raw/ subdir")
Ditto.
> Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com>
> ---
> drivers/mtd/nand/raw/mtk_nand.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/mtk_nand.c b/drivers/mtd/nand/raw/mtk_nand.c
> index cf5e50e704ae..675d4faa3480 100644
> --- a/drivers/mtd/nand/raw/mtk_nand.c
> +++ b/drivers/mtd/nand/raw/mtk_nand.c
> @@ -94,6 +94,7 @@
> #define NFI_MASTER_STA (0x224)
> #define MASTER_STA_MASK (0x0FFF)
> #define NFI_EMPTY_THRESH (0x23C)
> +#define EMPTY_THRESH_MASK GENMASK(7, 0)
>
> #define MTK_NAME "mtk-nand"
> #define KB(x) ((x) * 1024UL)
> @@ -931,6 +932,10 @@ static int mtk_nfc_read_subpage(struct mtd_info *mtd, struct nand_chip *chip,
> return -EINVAL;
> }
>
> + /* Setup empty threshold */
> + reg = max(sectors * chip->ecc.strength, EMPTY_THRESH_MASK);
> + nfi_writel(nfc, reg, NFI_EMPTY_THRESH);
> +
> reg = nfi_readw(nfc, NFI_CNFG);
> reg |= CNFG_READ_EN | CNFG_DMA_BURST_EN | CNFG_AHB;
> if (!raw) {
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-04-29 9:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 6:38 [PATCH 0/5] MTK NAND driver improvements and fixes Xiaolei Li
2019-04-29 6:38 ` Xiaolei Li
2019-04-29 6:38 ` [PATCH 1/5] mtd: rawnand: mtk: Correct low level time calculation of r/w cycle Xiaolei Li
2019-04-29 6:38 ` Xiaolei Li
[not found] ` <20190429063834.45967-2-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-04-29 9:03 ` Miquel Raynal
2019-04-29 9:03 ` Miquel Raynal
2019-04-29 9:35 ` xiaolei li
2019-04-29 9:35 ` xiaolei li
2019-04-29 10:02 ` Miquel Raynal
2019-04-29 10:02 ` Miquel Raynal
2019-04-30 0:59 ` xiaolei li
2019-04-30 0:59 ` xiaolei li
2019-04-29 6:38 ` [PATCH 2/5] mtd: rawnand: mtk: Improve data sampling timing for read cycle Xiaolei Li
2019-04-29 6:38 ` Xiaolei Li
[not found] ` <20190429063834.45967-3-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-04-29 9:10 ` Miquel Raynal
2019-04-29 9:10 ` Miquel Raynal
2019-04-29 9:49 ` xiaolei li
2019-04-29 6:38 ` [PATCH 3/5] mtd: rawnand: mtk: Add validity check for CE# pin setting Xiaolei Li
2019-04-29 6:38 ` Xiaolei Li
[not found] ` <20190429063834.45967-4-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-04-29 9:11 ` Miquel Raynal
2019-04-29 9:11 ` Miquel Raynal
2019-04-29 6:38 ` [PATCH 4/5] mtd: rawnand: mtk: Fix wrongly assigned oob buffer pointer issue Xiaolei Li
2019-04-29 6:38 ` Xiaolei Li
[not found] ` <20190429063834.45967-5-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-04-29 9:14 ` Miquel Raynal
2019-04-29 9:14 ` Miquel Raynal
2019-04-29 9:52 ` xiaolei li
2019-04-29 9:52 ` xiaolei li
2019-04-29 6:38 ` [PATCH 5/5] mtd: rawnand: mtk: Setup empty page threshold correctly Xiaolei Li
2019-04-29 6:38 ` Xiaolei Li
[not found] ` <20190429063834.45967-6-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-04-29 9:22 ` Miquel Raynal [this message]
2019-04-29 9:22 ` Miquel Raynal
2019-04-29 9:57 ` xiaolei li
2019-04-29 9:57 ` xiaolei li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429112200.42a86815@xps13 \
--to=miquel.raynal-ldxbnhwyfcjbdgjk7y7tuq@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=richard-/L3Ra7n9ekc@public.gmane.org \
--cc=srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.