All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda: Assign boolean values to a bool variable
@ 2021-01-25  7:17 ` Jiapeng Zhong
  0 siblings, 0 replies; 4+ messages in thread
From: Jiapeng Zhong @ 2021-01-25  7:17 UTC (permalink / raw)
  To: perex
  Cc: guennadi.liakhovetski, alsa-devel, kai.vehmanen, linux-kernel,
	tiwai, pierre-louis.bossart, hui.wang, kai.heng.feng,
	Jiapeng Zhong, rppt

Fix the following coccicheck warnings:

./sound/pci/hda/hda_intel.c:2309:3-23: WARNING: Assignment of
0/1 to bool variable.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
---
 sound/pci/hda/hda_intel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 5a50d3a..24e9762 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2304,7 +2304,7 @@ static int azx_probe_continue(struct azx *chip)
 
 		/* HSW/BDW controllers need this power */
 		if (CONTROLLER_IN_GPU(pci))
-			hda->need_i915_power = 1;
+			hda->need_i915_power = true;
 	}
 
 	/* Request display power well for the HDA controller or codec. For
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] ALSA: hda: Assign boolean values to a bool variable
@ 2021-01-25  7:17 ` Jiapeng Zhong
  0 siblings, 0 replies; 4+ messages in thread
From: Jiapeng Zhong @ 2021-01-25  7:17 UTC (permalink / raw)
  To: perex
  Cc: tiwai, kai.vehmanen, pierre-louis.bossart, guennadi.liakhovetski,
	kai.heng.feng, rppt, hui.wang, alsa-devel, linux-kernel,
	Jiapeng Zhong

Fix the following coccicheck warnings:

./sound/pci/hda/hda_intel.c:2309:3-23: WARNING: Assignment of
0/1 to bool variable.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
---
 sound/pci/hda/hda_intel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 5a50d3a..24e9762 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2304,7 +2304,7 @@ static int azx_probe_continue(struct azx *chip)
 
 		/* HSW/BDW controllers need this power */
 		if (CONTROLLER_IN_GPU(pci))
-			hda->need_i915_power = 1;
+			hda->need_i915_power = true;
 	}
 
 	/* Request display power well for the HDA controller or codec. For
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda: Assign boolean values to a bool variable
  2021-01-25  7:17 ` Jiapeng Zhong
@ 2021-01-25  8:01   ` Takashi Iwai
  -1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-01-25  8:01 UTC (permalink / raw)
  To: Jiapeng Zhong
  Cc: guennadi.liakhovetski, alsa-devel, kai.vehmanen, linux-kernel,
	pierre-louis.bossart, tiwai, hui.wang, kai.heng.feng, rppt

On Mon, 25 Jan 2021 08:17:27 +0100,
Jiapeng Zhong wrote:
> 
> Fix the following coccicheck warnings:
> 
> ./sound/pci/hda/hda_intel.c:2309:3-23: WARNING: Assignment of
> 0/1 to bool variable.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>

Thanks, applied now.

But if you have some more similar changes, please try to convert at
once instead of submitting each change infrequently.  It's getting
annoying now, as the change itself hardly helps improving the
readability or code quality in general, although there is no strong
reason to object it.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda: Assign boolean values to a bool variable
@ 2021-01-25  8:01   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-01-25  8:01 UTC (permalink / raw)
  To: Jiapeng Zhong
  Cc: perex, tiwai, kai.vehmanen, pierre-louis.bossart,
	guennadi.liakhovetski, kai.heng.feng, rppt, hui.wang, alsa-devel,
	linux-kernel

On Mon, 25 Jan 2021 08:17:27 +0100,
Jiapeng Zhong wrote:
> 
> Fix the following coccicheck warnings:
> 
> ./sound/pci/hda/hda_intel.c:2309:3-23: WARNING: Assignment of
> 0/1 to bool variable.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>

Thanks, applied now.

But if you have some more similar changes, please try to convert at
once instead of submitting each change infrequently.  It's getting
annoying now, as the change itself hardly helps improving the
readability or code quality in general, although there is no strong
reason to object it.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-26  3:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-25  7:17 [PATCH] ALSA: hda: Assign boolean values to a bool variable Jiapeng Zhong
2021-01-25  7:17 ` Jiapeng Zhong
2021-01-25  8:01 ` Takashi Iwai
2021-01-25  8:01   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.