All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: "hailong.fan" <hailong.fan@mediatek.com>
Cc: linux-sound@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-mediatek@lists.infradead.org,
	 Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	 Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	 Bard Liao <yung-chuan.liao@linux.intel.com>,
	 Daniel Baluta <daniel.baluta@nxp.com>,
	 Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
	 linux-kernel@vger.kernel.org,
	 Project_Global_Chrome_Upstream_Group@mediatek.com,
	 Jaroslav Kysela <perex@perex.cz>,
	 Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
	 devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	 Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,  Takashi Iwai <tiwai@suse.com>,
	sound-open-firmware@alsa-project.org,
	 Matthias Brugger <matthias.bgg@gmail.com>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: dsp: mediatek: add mt8196 dsp document
Date: Thu, 03 Jul 2025 05:19:31 -0500	[thread overview]
Message-ID: <175153797140.484478.11959606684592113866.robh@kernel.org> (raw)
In-Reply-To: <20250703075632.20758-2-hailong.fan@mediatek.com>


On Thu, 03 Jul 2025 15:56:23 +0800, hailong.fan wrote:
> From: Hailong Fan <hailong.fan@mediatek.com>
> 
> This patch adds mt8196 dsp document. The dsp is used for Sound Open
> Firmware driver node. It includes registers,  clocks, memory regions,
> and mailbox for dsp.
> 
> Signed-off-by: Hailong Fan <hailong.fan@mediatek.com>
> ---
>  .../bindings/sound/mediatek,mt8196-dsp.yaml   | 95 +++++++++++++++++++
>  1 file changed, 95 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt8196-dsp.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/sound/mediatek,mt8196-dsp.example.dts:18:18: fatal error: dt-bindings/clock/mt8196-clk.h: No such file or directory
   18 |         #include <dt-bindings/clock/mt8196-clk.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/sound/mediatek,mt8196-dsp.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1525: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250703075632.20758-2-hailong.fan@mediatek.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.



  parent reply	other threads:[~2025-07-03 10:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03  7:56 [PATCH v2 0/2] ASoC: mediatek: Add support of SOF on Mediatek mt8196 SoC hailong.fan
2025-07-03  7:56 ` [PATCH v2 1/2] dt-bindings: dsp: mediatek: add mt8196 dsp document hailong.fan
2025-07-03  8:08   ` Krzysztof Kozlowski
2025-07-03  9:05     ` AngeloGioacchino Del Regno
2025-07-03 10:24       ` Krzysztof Kozlowski
2025-07-09  6:05         ` Hailong Fan (范海龙)
2025-07-09  6:57           ` Krzysztof Kozlowski
2025-08-26  7:16             ` Hailong Fan (范海龙)
2025-07-09  6:34       ` Hailong Fan (范海龙)
2025-07-09  6:59         ` Krzysztof Kozlowski
2025-08-26  7:21           ` Hailong Fan (范海龙)
2025-07-09  2:52     ` Hailong Fan (范海龙)
2025-07-09  6:55       ` Krzysztof Kozlowski
2025-08-26  7:23         ` Hailong Fan (范海龙)
2025-07-03 10:19   ` Rob Herring (Arm) [this message]
2025-07-03  7:56 ` [PATCH v2 2/2] ASoC: SOF: MediaTek: Add mt8196 hardware support hailong.fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175153797140.484478.11959606684592113866.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hailong.fan@mediatek.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=sound-open-firmware@alsa-project.org \
    --cc=tiwai@suse.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.