From: Krzysztof Kozlowski <krzk@kernel.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"hailong.fan" <hailong.fan@mediatek.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
sound-open-firmware@alsa-project.org,
linux-sound@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 1/2] dt-bindings: dsp: mediatek: add mt8196 dsp document
Date: Thu, 3 Jul 2025 12:24:38 +0200 [thread overview]
Message-ID: <8b8a58f0-9e18-47d6-8382-1d16d630ea15@kernel.org> (raw)
In-Reply-To: <61784658-c71d-458b-8934-5f5db2330bc0@collabora.com>
On 03/07/2025 11:05, AngeloGioacchino Del Regno wrote:
>>> +
>>> + clocks:
>>> + items:
>>> + - description: mux for dsp clock
>>> + - description: 26M clock
>>> + - description: ADSP PLL clock
>>> +
>>> + clock-names:
>>> + items:
>>> + - const: adsp_sel
>>
>> Isn't this called audiodsp in other bindings?
>>
>>> + - const: clk26m
>>
>> Don't use frequencies. How is the pin or input called in datasheet? How
>> other devices call it?
>
> In the datasheet, this is called.... CLK26M (really).
>
OK, this is a valid argument, however we still try to unify the inputs
so bindings can share such pieces. It is discouraged to have similar
devices with different bindings in only one place: clk26m -> clk27m or
whatever other number.
Common is also to name the clock input based on the purpose (like bus, ref).
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-03 10:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 7:56 [PATCH v2 0/2] ASoC: mediatek: Add support of SOF on Mediatek mt8196 SoC hailong.fan
2025-07-03 7:56 ` [PATCH v2 1/2] dt-bindings: dsp: mediatek: add mt8196 dsp document hailong.fan
2025-07-03 8:08 ` Krzysztof Kozlowski
2025-07-03 9:05 ` AngeloGioacchino Del Regno
2025-07-03 10:24 ` Krzysztof Kozlowski [this message]
2025-07-09 6:05 ` Hailong Fan (范海龙)
2025-07-09 6:57 ` Krzysztof Kozlowski
2025-08-26 7:16 ` Hailong Fan (范海龙)
2025-07-09 6:34 ` Hailong Fan (范海龙)
2025-07-09 6:59 ` Krzysztof Kozlowski
2025-08-26 7:21 ` Hailong Fan (范海龙)
2025-07-09 2:52 ` Hailong Fan (范海龙)
2025-07-09 6:55 ` Krzysztof Kozlowski
2025-08-26 7:23 ` Hailong Fan (范海龙)
2025-07-03 10:19 ` Rob Herring (Arm)
2025-07-03 7:56 ` [PATCH v2 2/2] ASoC: SOF: MediaTek: Add mt8196 hardware support hailong.fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b8a58f0-9e18-47d6-8382-1d16d630ea15@kernel.org \
--to=krzk@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=hailong.fan@mediatek.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=robh@kernel.org \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.