Re: [PATCH v2 1/2] dt-bindings: dsp: mediatek: add mt8196 dsp document

["Hailong Fan (范海龙)" <Hailong.Fan@mediatek.com>]

On Wed, 2025-07-09 at 08:59 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 09/07/2025 08:34, Hailong Fan (范海龙) wrote:
> > On Thu, 2025-07-03 at 11:05 +0200, AngeloGioacchino Del Regno
> > wrote:
> > > External email : Please do not click links or open attachments
> > > until
> > > you have verified the sender or the content.
> > > 
> > > 
> > > Il 03/07/25 10:08, Krzysztof Kozlowski ha scritto:
> > > > On 03/07/2025 09:56, hailong.fan wrote:
> > > > > From: Hailong Fan <hailong.fan@mediatek.com>
> > > > > 
> > > > > This patch adds mt8196 dsp document. The dsp is used for
> > > > > Sound
> > > > > Open
> > > > 
> > > > Please do not use "This commit/patch/change", but imperative
> > > > mood.
> > > > See
> > > > longer explanation here:
> > > > 
> > 
> > 
https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst*L95__;Iw!!CTRNKA9wMg0ARbw!g39q48fUCsDJ5PETUtQ0PK0Bkwf0Ce1F_ZzJiEiWMzuybWQ0dSPzblvLlJ-4saWTSoJWuS5imsXbpdgLBvUy4wxw9C5w7B4m$
> > > > 
> 
> Fix your email client not to produce such junk like above ^.
OK,thx.
> 
> > > > > Firmware driver node. It includes registers,  clocks, memory
> > > > > regions,
> > > > > and mailbox for dsp.
> > > > > 
> > > > > Signed-off-by: Hailong Fan <hailong.fan@mediatek.com>
> > > > > ---
> > > > >   .../bindings/sound/mediatek,mt8196-dsp.yaml   | 95
> > > > > +++++++++++++++++++
> > > > >   1 file changed, 95 insertions(+)
> > > > >   create mode 100644
> > > > > Documentation/devicetree/bindings/sound/mediatek,mt8196-
> > > > > dsp.yaml
> > > > > 
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/sound/mediatek,mt8196-
> > > > > dsp.yaml
> > > > > b/Documentation/devicetree/bindings/sound/mediatek,mt8196-
> > > > > dsp.yaml
> > > > > new file mode 100644
> > > > > index 000000000000..68f594f476e8
> > > > > --- /dev/null
> > > > > +++
> > > > > b/Documentation/devicetree/bindings/sound/mediatek,mt8196-
> > > > > dsp.yaml
> > > 
> > > Wrong folder; this should go to dsp/mediatek,mt8196-dsp.yaml ....
> > > 
> > > ...but then I don't get why MT8196 wasn't simply added to
> > > mediatek,mt8186-dsp.yaml.
> > > 
> > 
> > Yes, the first version was written this way, but the maintainer
> > suggested the following, so I'm not sure which approach is more
> > appropriate. Could you please provide a final recommendation?
> > 
> > v1 link:
> > 
https://lore.kernel.org/all/a72988212d0d95bfe76eb9c53bbdb8c57c989377.camel@mediatek.com/
> 
> You linked to your reply. What does it prove? You are the maintainer
> and
> you gave this recommendation for your own patch?
> 
> > 
> > comment:
> > > 
> > > > ---
> > > >  .../bindings/dsp/mediatek,mt8196-dsp.yaml     | 96
> > > > +++++++++++++++++++
> > > 
> > > Don't grow dsp directory. Either this is remoteproc or some sound
> > > component, so place it accordingly.
> > 
> > This is a reference to the approach used in a previous MediaTek
> > project:
> > 
> > 
> > 
https://urldefense.com/v3/__https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/dsp__;!!CTRNKA9wMg0ARbw!nYISmR0CRlwCkvCsX__KkrKPFCiGy1jjwq_rZjMMXmQ6RhzlUeLgBmUpxvAslqJZTvM7J-QDvq_hpD4$
> > Do we need to move all the files under the DSP directory to the
> > sound
> > directory?
> 
> No.
Got it, we will place mediatek,mt8196-dsp.yaml in the
Documentation/devicetree/bindings/dsp directory. Thx.
> 
> 
> Best regards,
> Krzysztof