All of lore.kernel.org
 help / color / mirror / Atom feed
From: netdev-bot+sashiko@kernel.org
To: llleigoing@outlook.com
Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev,
	edumazet@kernel.org, ncardwell@google.com, kuniyu@google.com,
	davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	horms@kernel.org, matttbe@kernel.org, martineau@kernel.org,
	geliang@kernel.org
Subject: Re: [PATCH net 3/3] mptcp: exclude MSG_PEEK from receive buffer autotuning
Date: Fri, 20 Nov 2026 08:22:54 +0000	[thread overview]
Message-ID: <179516297471.3136.7019370824354358240@kernel.org> (raw)
In-Reply-To: <20261117052200.1507847-4-llleigoing@outlook.com>

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The name in the Signed-off-by tag does not match the author name.

--

mptcp: exclude MSG_PEEK from receive buffer autotuning

This patch stops __mptcp_recvmsg_mskq() from passing bytes copied by
MSG_PEEK to mptcp_rcv_space_adjust(). Repeated peeks no longer count the
same queued data as new application consumption, which could inflate
sk_rcvbuf. This restores the MSG_PEEK check that was dropped by commit
581302298524 ("mptcp: error out earlier on disconnect").

> Author: lei lei <llleigoing@outlook.com>

[ ... ]

> Signed-off-by: lllei <llleigoing@outlook.com>

[Severity: Low]
This isn't a bug, but the name in the Signed-off-by tag ("lllei") does
not match the author name ("lei lei"). The email address is the same in
both.

checkpatch.pl reports this as a From:/Signed-off-by: name mismatch.

Could the sign-off be changed to match the author identity, using the
real name, in a v2?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261117052200.1507847-1-llleigoing%40outlook.com

  parent reply	other threads:[~2026-11-20  8:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  5:22 [PATCH net 0/3] tcp, mptcp: fix receive buffer sizing and peek accounting lei lei
2026-11-17  5:22 ` [PATCH net 1/3] tcp: saturate window-to-memory conversions at INT_MAX lei lei
2026-11-18  5:22   ` sashiko-bot
2026-11-19  7:54   ` Eric Dumazet
2026-11-20  8:22   ` netdev-bot+sashiko
2026-11-17  5:22 ` [PATCH net 2/3] net: bound receive window predictions before narrowing lei lei
2026-11-18  5:22   ` sashiko-bot
2026-11-19  7:56   ` Eric Dumazet
2026-11-20  8:22   ` netdev-bot+sashiko
2026-11-17  5:22 ` [PATCH net 3/3] mptcp: exclude MSG_PEEK from receive buffer autotuning lei lei
2026-11-18  5:22   ` sashiko-bot
2026-11-19  7:59   ` Eric Dumazet
2026-11-19 18:33     ` Matthieu Baerts
2026-11-20  8:05       ` Lin Lei
2026-11-20  8:22   ` netdev-bot+sashiko [this message]
2026-11-17  7:04 ` [PATCH net 0/3] tcp, mptcp: fix receive buffer sizing and peek accounting MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179516297471.3136.7019370824354358240@kernel.org \
    --to=netdev-bot+sashiko@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=geliang@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=llleigoing@outlook.com \
    --cc=martineau@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.