All of lore.kernel.org
 help / color / mirror / Atom feed
From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] ARM: bcm476x: Add system timer
Date: Mon, 08 Oct 2012 13:50:16 +0200	[thread overview]
Message-ID: <1822741.oh36baA1m8@flexo> (raw)
In-Reply-To: <20121007015406.470633343@gmail.com>

On Sunday 07 October 2012 03:53:02 Domenico Andreoli wrote:
> From: Domenico Andreoli <domenico.andreoli@linux.com>
> 
> System timer implementation for the BCM476x SoCs.
> 
> Signed-off-by: Domenico Andreoli <domenico.andreoli@linux.com>
> ---
>  Documentation/devicetree/bindings/timer/brcm,bcm476x-system-timer.txt |   22 +
>  arch/arm/boot/dts/bcm476x.dtsi                                        |    8 +
>  arch/arm/mach-bcm476x/bcm476x.c                                       |   10 -
>  drivers/clocksource/Makefile                                          |    1 +
>  drivers/clocksource/bcm476x_timer.c                                   |  188 ++++++++++
>  include/linux/bcm476x_timer.h                                         |   24 +
>  6 files changed, 244 insertions(+), 9 deletions(-)
> 
> Index: b/Documentation/devicetree/bindings/timer/brcm,bcm476x-system-timer.txt
> ===================================================================
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/brcm,bcm476x-system-timer.txt
> @@ -0,0 +1,22 @@
> +BCM476x System Timer
> +
> +The System Timer peripheral provides either two or four 32-bit timer
> +channels.  BCM476x has three timers at 0xba000, 0xbb000 and 0xd1000. The
> +first two provide four channels, the last (in the AON - Always ON power
> +domain) provides only two.
> +
> +Required properties:
> +
> +- compatible : should be "brcm,bcm476x-system-timer"
> +- reg : Specifies base physical address and size of the registers.
> +- interrupts : A list of 2 or 4 interrupt sinks; one per timer channel.
> +- clock-frequency : The frequency of the clock that drives the counter, in Hz.
> +
> +Example:
> +
> +timer {
> +	compatible = "brcm,bcm476x-system-timer";
> +	reg = <0xba000 0x1000>;
> +	interrupts = <4>, <11>;
> +	clock-frequency = <24000000>;
> +};
> Index: b/arch/arm/boot/dts/bcm476x.dtsi
> ===================================================================
> --- a/arch/arm/boot/dts/bcm476x.dtsi
> +++ b/arch/arm/boot/dts/bcm476x.dtsi
> @@ -14,6 +14,14 @@
>  		#size-cells = <1>;
>  		ranges;
>  
> +		timer {
> +			compatible = "brcm,bcm476x-system-timer";
> +			reg = <0xba000 0x1000>;
> +			interrupt-parent = <&vic0>;
> +			interrupts = <4>, <11>;
> +			clock-frequency = <24000000>;
> +		};

This should rather be timer: timer at ba0000 for this node to be uniquely named.
--
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <florian@openwrt.org>
To: linux-arm-kernel@lists.infradead.org
Cc: Domenico Andreoli <domenico.andreoli@linux.com>,
	devicetree-discuss@lists.ozlabs.org,
	Domenico Andreoli <cavokz@gmail.com>
Subject: Re: [PATCH 2/6] ARM: bcm476x: Add system timer
Date: Mon, 08 Oct 2012 13:50:16 +0200	[thread overview]
Message-ID: <1822741.oh36baA1m8@flexo> (raw)
In-Reply-To: <20121007015406.470633343@gmail.com>

On Sunday 07 October 2012 03:53:02 Domenico Andreoli wrote:
> From: Domenico Andreoli <domenico.andreoli@linux.com>
> 
> System timer implementation for the BCM476x SoCs.
> 
> Signed-off-by: Domenico Andreoli <domenico.andreoli@linux.com>
> ---
>  Documentation/devicetree/bindings/timer/brcm,bcm476x-system-timer.txt |   22 +
>  arch/arm/boot/dts/bcm476x.dtsi                                        |    8 +
>  arch/arm/mach-bcm476x/bcm476x.c                                       |   10 -
>  drivers/clocksource/Makefile                                          |    1 +
>  drivers/clocksource/bcm476x_timer.c                                   |  188 ++++++++++
>  include/linux/bcm476x_timer.h                                         |   24 +
>  6 files changed, 244 insertions(+), 9 deletions(-)
> 
> Index: b/Documentation/devicetree/bindings/timer/brcm,bcm476x-system-timer.txt
> ===================================================================
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/brcm,bcm476x-system-timer.txt
> @@ -0,0 +1,22 @@
> +BCM476x System Timer
> +
> +The System Timer peripheral provides either two or four 32-bit timer
> +channels.  BCM476x has three timers at 0xba000, 0xbb000 and 0xd1000. The
> +first two provide four channels, the last (in the AON - Always ON power
> +domain) provides only two.
> +
> +Required properties:
> +
> +- compatible : should be "brcm,bcm476x-system-timer"
> +- reg : Specifies base physical address and size of the registers.
> +- interrupts : A list of 2 or 4 interrupt sinks; one per timer channel.
> +- clock-frequency : The frequency of the clock that drives the counter, in Hz.
> +
> +Example:
> +
> +timer {
> +	compatible = "brcm,bcm476x-system-timer";
> +	reg = <0xba000 0x1000>;
> +	interrupts = <4>, <11>;
> +	clock-frequency = <24000000>;
> +};
> Index: b/arch/arm/boot/dts/bcm476x.dtsi
> ===================================================================
> --- a/arch/arm/boot/dts/bcm476x.dtsi
> +++ b/arch/arm/boot/dts/bcm476x.dtsi
> @@ -14,6 +14,14 @@
>  		#size-cells = <1>;
>  		ranges;
>  
> +		timer {
> +			compatible = "brcm,bcm476x-system-timer";
> +			reg = <0xba000 0x1000>;
> +			interrupt-parent = <&vic0>;
> +			interrupts = <4>, <11>;
> +			clock-frequency = <24000000>;
> +		};

This should rather be timer: timer@ba0000 for this node to be uniquely named.
--
Florian

  reply	other threads:[~2012-10-08 11:50 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-07  1:53 [PATCH 0/6] ARM: Add support for Broadcom BCM476x SoCs Domenico Andreoli
2012-10-07  1:53 ` Domenico Andreoli
2012-10-07  1:53 ` [PATCH 1/6] ARM: bcm476x: Add infrastructure Domenico Andreoli
2012-10-07  1:53   ` Domenico Andreoli
2012-10-07 19:57   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 19:57     ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 22:54     ` Domenico Andreoli
2012-10-07 22:54       ` Domenico Andreoli
2012-10-08 13:13       ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-08 13:13         ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-09  2:37       ` Stephen Warren
2012-10-09  2:37         ` Stephen Warren
2012-10-09 11:50         ` Domenico Andreoli
2012-10-09 11:50           ` Domenico Andreoli
2012-10-08 11:50   ` Florian Fainelli
2012-10-08 11:50     ` Florian Fainelli
2012-10-09  2:41     ` Stephen Warren
2012-10-09  2:41       ` Stephen Warren
2012-10-08 12:14   ` Thomas Petazzoni
2012-10-08 12:14     ` Thomas Petazzoni
2012-10-09 11:52     ` Domenico Andreoli
2012-10-09 11:52       ` Domenico Andreoli
2012-10-09  2:48   ` Stephen Warren
2012-10-09  2:48     ` Stephen Warren
2012-10-09 11:54     ` Domenico Andreoli
2012-10-09 11:54       ` Domenico Andreoli
2012-10-09  3:08   ` Stephen Warren
2012-10-09  3:08     ` Stephen Warren
2012-10-09 11:55     ` Domenico Andreoli
2012-10-09 11:55       ` Domenico Andreoli
2012-10-09  9:18   ` Arnd Bergmann
2012-10-09  9:18     ` Arnd Bergmann
2012-10-09 22:58     ` Domenico Andreoli
2012-10-09 22:58       ` Domenico Andreoli
2012-10-10  6:29       ` Arnd Bergmann
2012-10-10  6:29         ` Arnd Bergmann
2012-10-12  7:06   ` Domenico Andreoli
2012-10-12  7:06     ` Domenico Andreoli
2012-10-12  7:26     ` Thomas Petazzoni
2012-10-12  7:26       ` Thomas Petazzoni
2012-10-12  8:03       ` Arnd Bergmann
2012-10-12  8:03         ` Arnd Bergmann
2012-10-12  8:12         ` Thomas Petazzoni
2012-10-12  8:12           ` Thomas Petazzoni
2012-10-12 10:48           ` Arnd Bergmann
2012-10-12 10:48             ` Arnd Bergmann
2012-10-12 11:01             ` Thomas Petazzoni
2012-10-12 11:01               ` Thomas Petazzoni
2012-10-12 11:17               ` Arnd Bergmann
2012-10-12 11:17                 ` Arnd Bergmann
2012-10-07  1:53 ` [PATCH 2/6] ARM: bcm476x: Add system timer Domenico Andreoli
2012-10-07  1:53   ` Domenico Andreoli
2012-10-08 11:50   ` Florian Fainelli [this message]
2012-10-08 11:50     ` Florian Fainelli
2012-10-09  2:43     ` Stephen Warren
2012-10-09  2:43       ` Stephen Warren
2012-10-09 23:04       ` Domenico Andreoli
2012-10-09 23:04         ` Domenico Andreoli
2012-10-07  1:53 ` [PATCH 3/6] ARM: bcm476x: Add sched clock Domenico Andreoli
2012-10-07  1:53   ` Domenico Andreoli
2012-10-09  2:54   ` Stephen Warren
2012-10-09  2:54     ` Stephen Warren
2012-10-07  1:53 ` [PATCH 4/6] ARM: bcm476x: Add stub clock driver Domenico Andreoli
2012-10-07  1:53   ` Domenico Andreoli
2012-10-09  3:00   ` Stephen Warren
2012-10-09  3:00     ` Stephen Warren
2012-10-12 14:52   ` Mike Turquette
2012-10-12 14:52     ` Mike Turquette
2012-10-12 15:28     ` Domenico Andreoli
2012-10-12 15:28       ` Domenico Andreoli
2012-10-07  1:53 ` [PATCH 5/6] ARM: bcm476x: Add restart hook Domenico Andreoli
2012-10-07  1:53   ` Domenico Andreoli
2012-10-07  1:53 ` [PATCH 6/6] ARM: bcm476x: Instantiate console UART Domenico Andreoli
2012-10-07  1:53   ` Domenico Andreoli
2012-10-07 20:03   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 20:03     ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 23:14     ` Domenico Andreoli
2012-10-07 23:14       ` Domenico Andreoli
2012-10-09  3:06   ` Stephen Warren
2012-10-09  3:06     ` Stephen Warren
2012-10-09 23:37     ` Domenico Andreoli
2012-10-09 23:37       ` Domenico Andreoli
2012-10-07  5:22 ` [PATCH 0/6] ARM: Add support for Broadcom BCM476x SoCs Stephen Warren
2012-10-07  5:22   ` Stephen Warren
2012-10-07 10:14   ` Domenico Andreoli
2012-10-07 10:14     ` Domenico Andreoli
2012-10-09  2:44     ` Stephen Warren
2012-10-09  2:44       ` Stephen Warren
2012-10-09 23:57       ` Domenico Andreoli
2012-10-09 23:57         ` Domenico Andreoli
2012-10-07 19:47 ` Olof Johansson
2012-10-07 19:47   ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1822741.oh36baA1m8@flexo \
    --to=florian@openwrt.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.