All of lore.kernel.org
 help / color / mirror / Atom feed
From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] ARM: bcm476x: Add infrastructure
Date: Mon, 08 Oct 2012 13:50:08 +0200	[thread overview]
Message-ID: <19574322.MHE4gIJg5N@flexo> (raw)
In-Reply-To: <20121007015405.958959522@gmail.com>

Hi Domenico,

On Sunday 07 October 2012 03:53:01 Domenico Andreoli wrote:
> From: Domenico Andreoli <domenico.andreoli@linux.com>
> 
> BCM476x's minimal infrastructure, Kernel's great reuse.
> 
> Look mom, no include/mach directory!

This is going to be in the commit, use something more sensible ;)

> 
> Signed-off-by: Domenico Andreoli <domenico.andreoli@linux.com>
> ---
[snip]
> Index: b/arch/arm/boot/dts/bcm476x.dtsi
> ===================================================================
> --- /dev/null
> +++ b/arch/arm/boot/dts/bcm476x.dtsi
> @@ -0,0 +1,31 @@
> +/include/ "skeleton.dtsi"
> +
> +/ {
> +	compatible = "brcm,bcm476x";
> +	model = "Broadcom BCM476x";
> +
> +	chosen {
> +		bootargs = "earlyprintk";
> +	};
> +
> +	amba {

I would rather explicitely mention that the peripheral base address is at 0
so something like this:

amba at 0 {

to make it clear that the peripherals declared as leaf nodes of this one are
at a relative address.

> +		compatible = "arm,amba-bus";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		vic0: interrupt-controller at 80000 {
> +			compatible = "brcm,bcm476x-pl192", "arm,pl192-vic", "arm,primecell";
> +			reg = <0x80000 0x1000>;
> +			interrupt-controller;
> +			#interrupt-cells = <1>;
> +		};
> +
> +		vic1: interrupt-controller at 81000 {
> +			compatible = "brcm,bcm476x-pl192", "arm,pl192-vic", "arm,primecell";
> +			reg = <0x81000 0x1000>;
> +			interrupt-controller;
> +			#interrupt-cells = <1>;
> +		};
> +	};
> +};
> Index: b/arch/arm/configs/bcm476x_defconfig
> ===================================================================
> --- /dev/null
> +++ b/arch/arm/configs/bcm476x_defconfig
> @@ -0,0 +1,352 @@
[snip]
> +CONFIG_ARM_APPENDED_DTB=y
> +CONFIG_ARM_ATAG_DTB_COMPAT=y
> +CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER=y
> +CONFIG_CMDLINE="root=/dev/mmcblk0p2 ro console=ttyAMA1,115200 rootwait init=/bin/bash"

remove the specific init=, let people use the defaults.
--
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <florian@openwrt.org>
To: linux-arm-kernel@lists.infradead.org
Cc: Domenico Andreoli <domenico.andreoli@linux.com>,
	devicetree-discuss@lists.ozlabs.org,
	Domenico Andreoli <cavokz@gmail.com>
Subject: Re: [PATCH 1/6] ARM: bcm476x: Add infrastructure
Date: Mon, 08 Oct 2012 13:50:08 +0200	[thread overview]
Message-ID: <19574322.MHE4gIJg5N@flexo> (raw)
In-Reply-To: <20121007015405.958959522@gmail.com>

Hi Domenico,

On Sunday 07 October 2012 03:53:01 Domenico Andreoli wrote:
> From: Domenico Andreoli <domenico.andreoli@linux.com>
> 
> BCM476x's minimal infrastructure, Kernel's great reuse.
> 
> Look mom, no include/mach directory!

This is going to be in the commit, use something more sensible ;)

> 
> Signed-off-by: Domenico Andreoli <domenico.andreoli@linux.com>
> ---
[snip]
> Index: b/arch/arm/boot/dts/bcm476x.dtsi
> ===================================================================
> --- /dev/null
> +++ b/arch/arm/boot/dts/bcm476x.dtsi
> @@ -0,0 +1,31 @@
> +/include/ "skeleton.dtsi"
> +
> +/ {
> +	compatible = "brcm,bcm476x";
> +	model = "Broadcom BCM476x";
> +
> +	chosen {
> +		bootargs = "earlyprintk";
> +	};
> +
> +	amba {

I would rather explicitely mention that the peripheral base address is at 0
so something like this:

amba@0 {

to make it clear that the peripherals declared as leaf nodes of this one are
at a relative address.

> +		compatible = "arm,amba-bus";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		vic0: interrupt-controller@80000 {
> +			compatible = "brcm,bcm476x-pl192", "arm,pl192-vic", "arm,primecell";
> +			reg = <0x80000 0x1000>;
> +			interrupt-controller;
> +			#interrupt-cells = <1>;
> +		};
> +
> +		vic1: interrupt-controller@81000 {
> +			compatible = "brcm,bcm476x-pl192", "arm,pl192-vic", "arm,primecell";
> +			reg = <0x81000 0x1000>;
> +			interrupt-controller;
> +			#interrupt-cells = <1>;
> +		};
> +	};
> +};
> Index: b/arch/arm/configs/bcm476x_defconfig
> ===================================================================
> --- /dev/null
> +++ b/arch/arm/configs/bcm476x_defconfig
> @@ -0,0 +1,352 @@
[snip]
> +CONFIG_ARM_APPENDED_DTB=y
> +CONFIG_ARM_ATAG_DTB_COMPAT=y
> +CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER=y
> +CONFIG_CMDLINE="root=/dev/mmcblk0p2 ro console=ttyAMA1,115200 rootwait init=/bin/bash"

remove the specific init=, let people use the defaults.
--
Florian

  parent reply	other threads:[~2012-10-08 11:50 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-07  1:53 [PATCH 0/6] ARM: Add support for Broadcom BCM476x SoCs Domenico Andreoli
2012-10-07  1:53 ` Domenico Andreoli
2012-10-07  1:53 ` [PATCH 1/6] ARM: bcm476x: Add infrastructure Domenico Andreoli
2012-10-07  1:53   ` Domenico Andreoli
2012-10-07 19:57   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 19:57     ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 22:54     ` Domenico Andreoli
2012-10-07 22:54       ` Domenico Andreoli
2012-10-08 13:13       ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-08 13:13         ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-09  2:37       ` Stephen Warren
2012-10-09  2:37         ` Stephen Warren
2012-10-09 11:50         ` Domenico Andreoli
2012-10-09 11:50           ` Domenico Andreoli
2012-10-08 11:50   ` Florian Fainelli [this message]
2012-10-08 11:50     ` Florian Fainelli
2012-10-09  2:41     ` Stephen Warren
2012-10-09  2:41       ` Stephen Warren
2012-10-08 12:14   ` Thomas Petazzoni
2012-10-08 12:14     ` Thomas Petazzoni
2012-10-09 11:52     ` Domenico Andreoli
2012-10-09 11:52       ` Domenico Andreoli
2012-10-09  2:48   ` Stephen Warren
2012-10-09  2:48     ` Stephen Warren
2012-10-09 11:54     ` Domenico Andreoli
2012-10-09 11:54       ` Domenico Andreoli
2012-10-09  3:08   ` Stephen Warren
2012-10-09  3:08     ` Stephen Warren
2012-10-09 11:55     ` Domenico Andreoli
2012-10-09 11:55       ` Domenico Andreoli
2012-10-09  9:18   ` Arnd Bergmann
2012-10-09  9:18     ` Arnd Bergmann
2012-10-09 22:58     ` Domenico Andreoli
2012-10-09 22:58       ` Domenico Andreoli
2012-10-10  6:29       ` Arnd Bergmann
2012-10-10  6:29         ` Arnd Bergmann
2012-10-12  7:06   ` Domenico Andreoli
2012-10-12  7:06     ` Domenico Andreoli
2012-10-12  7:26     ` Thomas Petazzoni
2012-10-12  7:26       ` Thomas Petazzoni
2012-10-12  8:03       ` Arnd Bergmann
2012-10-12  8:03         ` Arnd Bergmann
2012-10-12  8:12         ` Thomas Petazzoni
2012-10-12  8:12           ` Thomas Petazzoni
2012-10-12 10:48           ` Arnd Bergmann
2012-10-12 10:48             ` Arnd Bergmann
2012-10-12 11:01             ` Thomas Petazzoni
2012-10-12 11:01               ` Thomas Petazzoni
2012-10-12 11:17               ` Arnd Bergmann
2012-10-12 11:17                 ` Arnd Bergmann
2012-10-07  1:53 ` [PATCH 2/6] ARM: bcm476x: Add system timer Domenico Andreoli
2012-10-07  1:53   ` Domenico Andreoli
2012-10-08 11:50   ` Florian Fainelli
2012-10-08 11:50     ` Florian Fainelli
2012-10-09  2:43     ` Stephen Warren
2012-10-09  2:43       ` Stephen Warren
2012-10-09 23:04       ` Domenico Andreoli
2012-10-09 23:04         ` Domenico Andreoli
2012-10-07  1:53 ` [PATCH 3/6] ARM: bcm476x: Add sched clock Domenico Andreoli
2012-10-07  1:53   ` Domenico Andreoli
2012-10-09  2:54   ` Stephen Warren
2012-10-09  2:54     ` Stephen Warren
2012-10-07  1:53 ` [PATCH 4/6] ARM: bcm476x: Add stub clock driver Domenico Andreoli
2012-10-07  1:53   ` Domenico Andreoli
2012-10-09  3:00   ` Stephen Warren
2012-10-09  3:00     ` Stephen Warren
2012-10-12 14:52   ` Mike Turquette
2012-10-12 14:52     ` Mike Turquette
2012-10-12 15:28     ` Domenico Andreoli
2012-10-12 15:28       ` Domenico Andreoli
2012-10-07  1:53 ` [PATCH 5/6] ARM: bcm476x: Add restart hook Domenico Andreoli
2012-10-07  1:53   ` Domenico Andreoli
2012-10-07  1:53 ` [PATCH 6/6] ARM: bcm476x: Instantiate console UART Domenico Andreoli
2012-10-07  1:53   ` Domenico Andreoli
2012-10-07 20:03   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 20:03     ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-07 23:14     ` Domenico Andreoli
2012-10-07 23:14       ` Domenico Andreoli
2012-10-09  3:06   ` Stephen Warren
2012-10-09  3:06     ` Stephen Warren
2012-10-09 23:37     ` Domenico Andreoli
2012-10-09 23:37       ` Domenico Andreoli
2012-10-07  5:22 ` [PATCH 0/6] ARM: Add support for Broadcom BCM476x SoCs Stephen Warren
2012-10-07  5:22   ` Stephen Warren
2012-10-07 10:14   ` Domenico Andreoli
2012-10-07 10:14     ` Domenico Andreoli
2012-10-09  2:44     ` Stephen Warren
2012-10-09  2:44       ` Stephen Warren
2012-10-09 23:57       ` Domenico Andreoli
2012-10-09 23:57         ` Domenico Andreoli
2012-10-07 19:47 ` Olof Johansson
2012-10-07 19:47   ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19574322.MHE4gIJg5N@flexo \
    --to=florian@openwrt.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.