All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: "Daniel P. Berrange" <berrange@redhat.com>,
	Keir Fraser <keir.fraser@eu.citrix.com>,
	"He, Qing" <qing.he@intel.com>,
	xen-devel@lists.xensource.com
Subject: Re: ioemu build failure with GCC > 4.3
Date: Thu, 10 Jul 2008 10:49:48 +0100	[thread overview]
Message-ID: <18549.56124.526376.460576@mariner.uk.xensource.com> (raw)
In-Reply-To: <18549.55810.700581.571255@mariner.uk.xensource.com>

iwj writes ("Re: [Xen-devel] ioemu build failure with GCC > 4.3"):
> Daniel P. Berrange writes ("Re: [Xen-devel] ioemu build failure with GCC > 4.3"):
> > None of the entire slirp directory looks like a good idea. This code
> > isn't even used in Xen is it ? My vote  would be disabling compilation
> > of entire slirp directory for Xen. 
> 
> This is the right answer, yes.

I've done this now.

Ian.

commit 29c20f126f298cf2162169b4bbb8206860f11240
Author: Ian Jackson <iwj@mariner.uk.xensource.com>
Date:   Thu Jul 10 10:48:51 2008 +0100

    Disable slirp.
    
    The slirp system is not really a very nice idea, especially not in a
    Xen context.  Also, the code misuses inline and does not compile on
    GCC >4.3ish.
    
    Thanks to Qing He <qing.he@intel.com> for the report.

diff --git a/xen-setup b/xen-setup
index c00122c..755b9ec 100755
--- a/xen-setup
+++ b/xen-setup
@@ -9,7 +9,7 @@ rm -f config-host.mak
 
 if test -f config-host.h; then mv config-host.h config-host.h~; fi
 
-./configure --disable-curses "$@" --prefix=/usr
+./configure --disable-curses --disable-slirp "$@" --prefix=/usr
 
 target=i386-dm

  reply	other threads:[~2008-07-10  9:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-10  9:32 ioemu build failure with GCC > 4.3 He, Qing
2008-07-10  9:39 ` Keir Fraser
2008-07-10  9:43   ` Daniel P. Berrange
2008-07-10  9:44     ` Ian Jackson
2008-07-10  9:49       ` Ian Jackson [this message]
2008-07-10 13:18         ` Ross Philipson
2008-07-10 14:06           ` Ian Jackson
2008-07-10 14:13             ` Ross Philipson
2008-07-14 15:12               ` Ian Jackson
2008-07-14 15:21                 ` Stefan de Konink
2008-07-15 13:55                   ` Ross Philipson
2008-07-15 14:06                     ` Keir Fraser
2008-07-15 14:09                       ` Ross Philipson
2008-07-15 18:33                         ` [PATCH] " Espen Skoglund
2008-07-15 18:45                         ` Espen Skoglund
2008-07-14 16:56                 ` prashanth.mundkur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18549.56124.526376.460576@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=berrange@redhat.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=qing.he@intel.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.