Re: ioemu build failure with GCC > 4.3

["Daniel P. Berrange" <berrange@redhat.com>]

On Thu, Jul 10, 2008 at 10:39:31AM +0100, Keir Fraser wrote:
> On 10/7/08 10:32, "He, Qing" <qing.he@intel.com> wrote:
> 
> > It's most straightforward to remove `inline' in slirp/misc.c, the code
> > doesn't really seem to benefit from it. But it looks pretty old and not
> > maintained for sometime. What about patch it locally?
> > 
> > Other options include specify `-fgnu89-inline' (n/a prior to GCC 4.1.3)
> > and overrides slirp compile line with `-std=gnu89', but may not be
> > preferred.
> 
> Could we change the '#define inline' in slirp_config.h to define it to
> nothing? None of the usages of 'inline' in the slirp directory look like a
> particularly good idea.

None of the entire slirp directory looks like a good idea. This code
isn't even used in Xen is it ? My vote  would be disabling compilation
of entire slirp directory for Xen. 

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|