From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "He, Qing" <qing.he@intel.com>, ian.jackson@eu.citrix.com
Cc: xen-devel@lists.xensource.com
Subject: Re: ioemu build failure with GCC > 4.3
Date: Thu, 10 Jul 2008 10:39:31 +0100 [thread overview]
Message-ID: <C49B9763.23DA8%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <37E52D09333DE2469A03574C88DBF40F021BEF97@pdsmsx414.ccr.corp.intel.com>
On 10/7/08 10:32, "He, Qing" <qing.he@intel.com> wrote:
> It's most straightforward to remove `inline' in slirp/misc.c, the code
> doesn't really seem to benefit from it. But it looks pretty old and not
> maintained for sometime. What about patch it locally?
>
> Other options include specify `-fgnu89-inline' (n/a prior to GCC 4.1.3)
> and overrides slirp compile line with `-std=gnu89', but may not be
> preferred.
Could we change the '#define inline' in slirp_config.h to define it to
nothing? None of the usages of 'inline' in the slirp directory look like a
particularly good idea.
-- Keir
next prev parent reply other threads:[~2008-07-10 9:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 9:32 ioemu build failure with GCC > 4.3 He, Qing
2008-07-10 9:39 ` Keir Fraser [this message]
2008-07-10 9:43 ` Daniel P. Berrange
2008-07-10 9:44 ` Ian Jackson
2008-07-10 9:49 ` Ian Jackson
2008-07-10 13:18 ` Ross Philipson
2008-07-10 14:06 ` Ian Jackson
2008-07-10 14:13 ` Ross Philipson
2008-07-14 15:12 ` Ian Jackson
2008-07-14 15:21 ` Stefan de Konink
2008-07-15 13:55 ` Ross Philipson
2008-07-15 14:06 ` Keir Fraser
2008-07-15 14:09 ` Ross Philipson
2008-07-15 18:33 ` [PATCH] " Espen Skoglund
2008-07-15 18:45 ` Espen Skoglund
2008-07-14 16:56 ` prashanth.mundkur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C49B9763.23DA8%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=qing.he@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.