From: Arnd Bergmann <arnd@arndb.de>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
dmaengine@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
Rob Herring <robh+dt@kernel.org>, Rob Herring <robh@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Andy Gross <agross@codeaurora.org>,
Archit Taneja <architt@codeaurora.org>
Subject: Re: [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size
Date: Tue, 01 Dec 2015 11:28:32 +0100 [thread overview]
Message-ID: <1971752.Auss6gPApO@wuerfel> (raw)
In-Reply-To: <1448961299-15161-4-git-send-email-stanimir.varbanov@linaro.org>
On Tuesday 01 December 2015 11:14:58 Stanimir Varbanov wrote:
>
> diff --git a/drivers/dma/qcom_bam_dma.c b/drivers/dma/qcom_bam_dma.c
> index 0f06f3b7a72b..6d290de9ab2b 100644
> --- a/drivers/dma/qcom_bam_dma.c
> +++ b/drivers/dma/qcom_bam_dma.c
> @@ -458,7 +458,7 @@ static void bam_chan_init_hw(struct bam_chan *bchan,
> */
> writel_relaxed(ALIGN(bchan->fifo_phys, sizeof(struct bam_desc_hw)),
> bam_addr(bdev, bchan->id, BAM_P_DESC_FIFO_ADDR));
> - writel_relaxed(BAM_DESC_FIFO_SIZE,
> + writel_relaxed(BAM_MAX_DATA_SIZE,
> bam_addr(bdev, bchan->id, BAM_P_FIFO_SIZES));
>
> /* enable the per pipe interrupts, enable EOT, ERR, and INT irqs */
I'm looking at that now and fail to see why these have to use writel_relaxed().
Could you add a patch to use readl/writel by default?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size
Date: Tue, 01 Dec 2015 11:28:32 +0100 [thread overview]
Message-ID: <1971752.Auss6gPApO@wuerfel> (raw)
In-Reply-To: <1448961299-15161-4-git-send-email-stanimir.varbanov@linaro.org>
On Tuesday 01 December 2015 11:14:58 Stanimir Varbanov wrote:
>
> diff --git a/drivers/dma/qcom_bam_dma.c b/drivers/dma/qcom_bam_dma.c
> index 0f06f3b7a72b..6d290de9ab2b 100644
> --- a/drivers/dma/qcom_bam_dma.c
> +++ b/drivers/dma/qcom_bam_dma.c
> @@ -458,7 +458,7 @@ static void bam_chan_init_hw(struct bam_chan *bchan,
> */
> writel_relaxed(ALIGN(bchan->fifo_phys, sizeof(struct bam_desc_hw)),
> bam_addr(bdev, bchan->id, BAM_P_DESC_FIFO_ADDR));
> - writel_relaxed(BAM_DESC_FIFO_SIZE,
> + writel_relaxed(BAM_MAX_DATA_SIZE,
> bam_addr(bdev, bchan->id, BAM_P_FIFO_SIZES));
>
> /* enable the per pipe interrupts, enable EOT, ERR, and INT irqs */
I'm looking at that now and fail to see why these have to use writel_relaxed().
Could you add a patch to use readl/writel by default?
Arnd
next prev parent reply other threads:[~2015-12-01 10:29 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 9:14 [PATCH 0/4] bam dma fixes and one dt extension Stanimir Varbanov
2015-12-01 9:14 ` Stanimir Varbanov
2015-12-01 9:14 ` [PATCH 1/4] dmaengine: qcom_bam_dma: fix dma free memory on remove Stanimir Varbanov
2015-12-01 9:14 ` Stanimir Varbanov
2015-12-01 9:14 ` [PATCH 2/4] dmaengine: qcom_bam_dma: clear BAM interrupt only if it is rised Stanimir Varbanov
2015-12-01 9:14 ` Stanimir Varbanov
2015-12-01 10:29 ` Arnd Bergmann
2015-12-01 10:29 ` Arnd Bergmann
2015-12-02 12:56 ` Stanimir Varbanov
2015-12-02 12:56 ` Stanimir Varbanov
2015-12-02 13:05 ` Arnd Bergmann
2015-12-02 13:05 ` Arnd Bergmann
2015-12-02 16:47 ` Stanimir Varbanov
2015-12-02 16:47 ` Stanimir Varbanov
2015-12-01 17:28 ` Andy Gross
2015-12-01 17:28 ` Andy Gross
2015-12-01 9:14 ` [PATCH 4/4] dmaengine: qcom_bam_dma: add controlled remotely dt property Stanimir Varbanov
2015-12-01 9:14 ` Stanimir Varbanov
2015-12-01 17:30 ` Andy Gross
2015-12-01 17:30 ` Andy Gross
[not found] ` <1448961299-15161-1-git-send-email-stanimir.varbanov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-12-01 9:14 ` [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size Stanimir Varbanov
2015-12-01 9:14 ` Stanimir Varbanov
2015-12-01 9:14 ` Stanimir Varbanov
2015-12-01 10:28 ` Arnd Bergmann [this message]
2015-12-01 10:28 ` Arnd Bergmann
2015-12-01 17:25 ` Andy Gross
2015-12-01 17:25 ` Andy Gross
2015-12-01 20:22 ` Arnd Bergmann
2015-12-01 20:22 ` Arnd Bergmann
2015-12-01 17:23 ` Andy Gross
2015-12-01 17:23 ` Andy Gross
2015-12-02 16:44 ` Stanimir Varbanov
2015-12-02 16:44 ` Stanimir Varbanov
2015-12-02 17:22 ` Andy Gross
2015-12-02 17:22 ` Andy Gross
2015-12-10 13:18 ` Stanimir Varbanov
2015-12-10 13:18 ` Stanimir Varbanov
[not found] ` <56697BA9.5050805-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-01-29 4:38 ` Andy Gross
2016-01-29 4:38 ` Andy Gross
2016-01-29 4:38 ` Andy Gross
2016-04-05 21:33 ` [PATCH 0/4] bam dma fixes and one dt extension Andy Gross
2016-04-05 21:33 ` Andy Gross
2016-04-05 21:33 ` Andy Gross
2016-04-05 23:06 ` Stanimir Varbanov
2016-04-05 23:06 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1971752.Auss6gPApO@wuerfel \
--to=arnd@arndb.de \
--cc=agross@codeaurora.org \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.