From: Andy Gross <andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Stanimir Varbanov
<stanimir.varbanov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Andy Gross <agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Archit Taneja <architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size
Date: Thu, 28 Jan 2016 22:38:55 -0600 [thread overview]
Message-ID: <20160129043855.GA4608@hector.attlocal.net> (raw)
In-Reply-To: <56697BA9.5050805-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Thu, Dec 10, 2015 at 03:18:33PM +0200, Stanimir Varbanov wrote:
<snip>
> >>> This is just using the #define. That is ok, but if you use this instead of the
> >>> BAM_P_FIFO_SIZES then you need to fix your comment. Or actually use the
> >>> register value.... otherwise looks fine.
> >>
> >> I did not follow your comment, but the intension of the patch is to set
> >> the proper FIFO size in BAM_P_FIFO_SIZES register, i.e. 32K - 8.
> >
> > Sorry, I mixed up the usage and was thinking there was something you read out
> > that told you the size. That's not how it works, unfortunately. The
> > MAX_DATA_SIZE is fine, but the name is a little misleading. Perhaps just
> > BAM_FIFO_SIZE?
>
> OK I can rename BAM_MAX_DATA_SIZE to BAM_FIFO_SIZE, and use it when
> setting BAM_P_FIFO_SIZES register. Is that fine to you?
Yes that's fine with me.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: andy.gross@linaro.org (Andy Gross)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size
Date: Thu, 28 Jan 2016 22:38:55 -0600 [thread overview]
Message-ID: <20160129043855.GA4608@hector.attlocal.net> (raw)
In-Reply-To: <56697BA9.5050805@linaro.org>
On Thu, Dec 10, 2015 at 03:18:33PM +0200, Stanimir Varbanov wrote:
<snip>
> >>> This is just using the #define. That is ok, but if you use this instead of the
> >>> BAM_P_FIFO_SIZES then you need to fix your comment. Or actually use the
> >>> register value.... otherwise looks fine.
> >>
> >> I did not follow your comment, but the intension of the patch is to set
> >> the proper FIFO size in BAM_P_FIFO_SIZES register, i.e. 32K - 8.
> >
> > Sorry, I mixed up the usage and was thinking there was something you read out
> > that told you the size. That's not how it works, unfortunately. The
> > MAX_DATA_SIZE is fine, but the name is a little misleading. Perhaps just
> > BAM_FIFO_SIZE?
>
> OK I can rename BAM_MAX_DATA_SIZE to BAM_FIFO_SIZE, and use it when
> setting BAM_P_FIFO_SIZES register. Is that fine to you?
Yes that's fine with me.
WARNING: multiple messages have this Message-ID (diff)
From: Andy Gross <andy.gross@linaro.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: Andy Gross <agross@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
dmaengine@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
Rob Herring <robh+dt@kernel.org>, Rob Herring <robh@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Archit Taneja <architt@codeaurora.org>
Subject: Re: [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size
Date: Thu, 28 Jan 2016 22:38:55 -0600 [thread overview]
Message-ID: <20160129043855.GA4608@hector.attlocal.net> (raw)
In-Reply-To: <56697BA9.5050805@linaro.org>
On Thu, Dec 10, 2015 at 03:18:33PM +0200, Stanimir Varbanov wrote:
<snip>
> >>> This is just using the #define. That is ok, but if you use this instead of the
> >>> BAM_P_FIFO_SIZES then you need to fix your comment. Or actually use the
> >>> register value.... otherwise looks fine.
> >>
> >> I did not follow your comment, but the intension of the patch is to set
> >> the proper FIFO size in BAM_P_FIFO_SIZES register, i.e. 32K - 8.
> >
> > Sorry, I mixed up the usage and was thinking there was something you read out
> > that told you the size. That's not how it works, unfortunately. The
> > MAX_DATA_SIZE is fine, but the name is a little misleading. Perhaps just
> > BAM_FIFO_SIZE?
>
> OK I can rename BAM_MAX_DATA_SIZE to BAM_FIFO_SIZE, and use it when
> setting BAM_P_FIFO_SIZES register. Is that fine to you?
Yes that's fine with me.
next prev parent reply other threads:[~2016-01-29 4:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 9:14 [PATCH 0/4] bam dma fixes and one dt extension Stanimir Varbanov
2015-12-01 9:14 ` Stanimir Varbanov
2015-12-01 9:14 ` [PATCH 1/4] dmaengine: qcom_bam_dma: fix dma free memory on remove Stanimir Varbanov
2015-12-01 9:14 ` Stanimir Varbanov
2015-12-01 9:14 ` [PATCH 2/4] dmaengine: qcom_bam_dma: clear BAM interrupt only if it is rised Stanimir Varbanov
2015-12-01 9:14 ` Stanimir Varbanov
2015-12-01 10:29 ` Arnd Bergmann
2015-12-01 10:29 ` Arnd Bergmann
2015-12-02 12:56 ` Stanimir Varbanov
2015-12-02 12:56 ` Stanimir Varbanov
2015-12-02 13:05 ` Arnd Bergmann
2015-12-02 13:05 ` Arnd Bergmann
2015-12-02 16:47 ` Stanimir Varbanov
2015-12-02 16:47 ` Stanimir Varbanov
2015-12-01 17:28 ` Andy Gross
2015-12-01 17:28 ` Andy Gross
2015-12-01 9:14 ` [PATCH 4/4] dmaengine: qcom_bam_dma: add controlled remotely dt property Stanimir Varbanov
2015-12-01 9:14 ` Stanimir Varbanov
2015-12-01 17:30 ` Andy Gross
2015-12-01 17:30 ` Andy Gross
[not found] ` <1448961299-15161-1-git-send-email-stanimir.varbanov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-12-01 9:14 ` [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size Stanimir Varbanov
2015-12-01 9:14 ` Stanimir Varbanov
2015-12-01 9:14 ` Stanimir Varbanov
2015-12-01 10:28 ` Arnd Bergmann
2015-12-01 10:28 ` Arnd Bergmann
2015-12-01 17:25 ` Andy Gross
2015-12-01 17:25 ` Andy Gross
2015-12-01 20:22 ` Arnd Bergmann
2015-12-01 20:22 ` Arnd Bergmann
2015-12-01 17:23 ` Andy Gross
2015-12-01 17:23 ` Andy Gross
2015-12-02 16:44 ` Stanimir Varbanov
2015-12-02 16:44 ` Stanimir Varbanov
2015-12-02 17:22 ` Andy Gross
2015-12-02 17:22 ` Andy Gross
2015-12-10 13:18 ` Stanimir Varbanov
2015-12-10 13:18 ` Stanimir Varbanov
[not found] ` <56697BA9.5050805-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-01-29 4:38 ` Andy Gross [this message]
2016-01-29 4:38 ` Andy Gross
2016-01-29 4:38 ` Andy Gross
2016-04-05 21:33 ` [PATCH 0/4] bam dma fixes and one dt extension Andy Gross
2016-04-05 21:33 ` Andy Gross
2016-04-05 21:33 ` Andy Gross
2016-04-05 23:06 ` Stanimir Varbanov
2016-04-05 23:06 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129043855.GA4608@hector.attlocal.net \
--to=andy.gross-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=stanimir.varbanov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.