All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Duncan Sands <baldrick@wanadoo.fr>
Cc: "Martin J. Bligh" <mbligh@aracnet.com>,
	Andrew Morton <akpm@digeo.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: BUGed to death
Date: Tue, 15 Apr 2003 14:31:34 +0200	[thread overview]
Message-ID: <20030415123134.GM9776@suse.de> (raw)
In-Reply-To: <200304151401.00704.baldrick@wanadoo.fr>

On Tue, Apr 15 2003, Duncan Sands wrote:
> On Monday 14 April 2003 22:19, Martin J. Bligh wrote:
> > Seems all these bug checks are fairly expensive. I can get 1%
> > back on system time for kernel compiles by changing BUG to
> > "do {} while (0)" to make them all compile away. Profiles aren't
> > very revealing though ... seems to be within experimental error ;-(
> 
> What happens if you just turn BUG_ON into "do {} while (0)"?

If you do that, you must audit every single BUG_ON to make sure the
expression doesn't have any side effects.

	BUG_ON(do_the_good_stuff());

-- 
Jens Axboe, proud inventer of BUG_ON :-)


  reply	other threads:[~2003-04-15 12:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-14 20:19 BUGed to death Martin J. Bligh
2003-04-14 20:40 ` Duncan Sands
2003-04-14 21:02   ` Dave Jones
2003-04-14 21:10     ` Duncan Sands
2003-04-14 21:17       ` Dave Jones
2003-04-15 11:57         ` Duncan Sands
2003-04-15 12:05           ` Dave Jones
2003-04-15 14:39             ` Martin J. Bligh
2003-04-23 15:08             ` Duncan Sands
2003-04-14 21:00 ` Dave Jones
2003-04-14 20:55   ` Martin J. Bligh
2003-04-14 21:08     ` Dave Jones
2003-04-14 21:50       ` Andrew Morton
2003-04-14 21:55         ` Dave Jones
2003-04-15  0:23   ` H. Peter Anvin
2003-04-15 12:01 ` Duncan Sands
2003-04-15 12:31   ` Jens Axboe [this message]
2003-04-15 12:36     ` Dave Jones
2003-04-15 12:40       ` Jens Axboe
2003-04-15 12:49     ` Sean Neakums
2003-04-15 12:52       ` Sean Neakums
2003-04-15 13:01     ` Roman Zippel
2003-04-15 13:17       ` Jens Axboe
2003-04-15 13:55     ` Duncan Sands
2003-04-15 14:22       ` Jens Axboe
2003-04-15 14:35   ` Martin J. Bligh
2003-04-15 14:39     ` Duncan Sands
2003-04-15 14:45       ` Martin J. Bligh
2003-04-15 14:58         ` Duncan Sands
  -- strict thread matches above, loose matches on Subject: below --
2003-04-15 14:30 rwhron
2003-04-15 15:57 ` Dave Jones
2003-04-15 16:11   ` Nick Piggin
2003-04-15 16:22   ` Soeren Sonnenburg
2003-04-15 16:42   ` Michael Buesch
2003-04-15 16:45     ` Dave Jones
2003-04-15 18:33 Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030415123134.GM9776@suse.de \
    --to=axboe@suse.de \
    --cc=akpm@digeo.com \
    --cc=baldrick@wanadoo.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@aracnet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.