From: Dave Jones <davej@codemonkey.org.uk>
To: rwhron@earthlink.net
Cc: linux-kernel@vger.kernel.org, reiserfs-list@namesys.com
Subject: Re: BUGed to death
Date: Tue, 15 Apr 2003 16:57:08 +0100 [thread overview]
Message-ID: <20030415155708.GB17152@suse.de> (raw)
In-Reply-To: <20030415143024.GA10117@rushmore>
On Tue, Apr 15, 2003 at 10:30:24AM -0400, rwhron@earthlink.net wrote:
> The patch below eliminates 4 BUG() calls that clearly
> cannot happen based on the context.
This looks bogus.
> --- linux-2.5.67-mm2/fs/reiserfs/hashes.c.orig 2003-04-15 10:11:44.000000000 -0400
> +++ linux-2.5.67-mm2/fs/reiserfs/hashes.c 2003-04-15 10:13:43.000000000 -0400
> @@ -90,10 +90,6 @@
>
> if (len >= 12)
> {
> - //assert(len < 16);
> - if (len >= 16)
> - BUG();
> -
Imagine I pass in 20. Previously, the BUG triggers. Not any more.
Ditto the other changes. Or am _I_ missing something ?
Dave
next prev parent reply other threads:[~2003-04-15 15:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-15 14:30 BUGed to death rwhron
2003-04-15 15:57 ` Dave Jones [this message]
2003-04-15 16:11 ` Nick Piggin
2003-04-15 16:22 ` Soeren Sonnenburg
2003-04-15 16:42 ` Michael Buesch
2003-04-15 16:45 ` Dave Jones
-- strict thread matches above, loose matches on Subject: below --
2003-04-15 18:33 Chuck Ebbert
2003-04-14 20:19 Martin J. Bligh
2003-04-14 20:40 ` Duncan Sands
2003-04-14 21:02 ` Dave Jones
2003-04-14 21:10 ` Duncan Sands
2003-04-14 21:17 ` Dave Jones
2003-04-15 11:57 ` Duncan Sands
2003-04-15 12:05 ` Dave Jones
2003-04-15 14:39 ` Martin J. Bligh
2003-04-23 15:08 ` Duncan Sands
2003-04-14 21:00 ` Dave Jones
2003-04-14 20:55 ` Martin J. Bligh
2003-04-14 21:08 ` Dave Jones
2003-04-14 21:50 ` Andrew Morton
2003-04-14 21:55 ` Dave Jones
2003-04-15 0:23 ` H. Peter Anvin
2003-04-15 12:01 ` Duncan Sands
2003-04-15 12:31 ` Jens Axboe
2003-04-15 12:36 ` Dave Jones
2003-04-15 12:40 ` Jens Axboe
2003-04-15 12:49 ` Sean Neakums
2003-04-15 12:52 ` Sean Neakums
2003-04-15 13:01 ` Roman Zippel
2003-04-15 13:17 ` Jens Axboe
2003-04-15 13:55 ` Duncan Sands
2003-04-15 14:22 ` Jens Axboe
2003-04-15 14:35 ` Martin J. Bligh
2003-04-15 14:39 ` Duncan Sands
2003-04-15 14:45 ` Martin J. Bligh
2003-04-15 14:58 ` Duncan Sands
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030415155708.GB17152@suse.de \
--to=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-list@namesys.com \
--cc=rwhron@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.