Re: BUGed to death

[Jens Axboe <axboe@suse.de>]

On Tue, Apr 15 2003, Dave Jones wrote:
> On Tue, Apr 15, 2003 at 02:31:34PM +0200, Jens Axboe wrote:
> 
>  > If you do that, you must audit every single BUG_ON to make sure the
>  > expression doesn't have any side effects.
>  > 
>  > 	BUG_ON(do_the_good_stuff());
> 
> Sure, but such a construct looks really bad anyway.
> Relying on side-effects of whats essentially a debug macro
> sounds very dodgy.
> 
> 	foo = do_the_good_stuff();
> 	BUG_ON (foo==baz)
> 
> Would be a better way of expressing this.

Oh I agree, it wasn't an example of good code :). It still needs to be
audited though.

-- 
Jens Axboe