All of lore.kernel.org
 help / color / mirror / Atom feed
From: trini@kernel.crashing.org (Tom Rini)
To: lm-sensors@vger.kernel.org
Subject: [PATCH] i2c driver fixes for 2.6.0
Date: Thu, 19 May 2005 06:24:32 +0000	[thread overview]
Message-ID: <20040105163441.GC2415@stop.crashing.org> (raw)
In-Reply-To: <10728219692713@kroah.com>

On Sun, Jan 04, 2004 at 05:08:49PM +1100, Rusty Russell wrote:

> In message <1072821970727@kroah.com> you write:
> > +/* If fix_hstcfg is set to anything different from 0, we reset one of the
> > +   registers to be a valid value. */
> > +static int fix_hstcfg = 0;
> > +MODULE_PARM(fix_hstcfg, "i");
> > +MODULE_PARM_DESC(fix_hstcfg,
> > +		"Fix config register. Needed on some boards (Force CPCI735).");
> > +
> 
> BTW, it'd be nice if someone converted these to module_param, too...

Done.
=== drivers/i2c/busses/i2c-piix4.c 1.21 vs edited ==--- 1.21/drivers/i2c/busses/i2c-piix4.c	Tue Dec 30 13:03:31 2003
+++ edited/drivers/i2c/busses/i2c-piix4.c	Mon Jan  5 09:33:17 2004
@@ -31,6 +31,7 @@
 /* #define DEBUG 1 */
 
 #include <linux/module.h>
+#include <linux/moduleparam.h>
 #include <linux/config.h>
 #include <linux/pci.h>
 #include <linux/kernel.h>
@@ -88,13 +89,13 @@
 /* If force is set to anything different from 0, we forcibly enable the
    PIIX4. DANGEROUS! */
 static int force = 0;
-MODULE_PARM(force, "i");
+module_param (force, int, 0);
 MODULE_PARM_DESC(force, "Forcibly enable the PIIX4. DANGEROUS!");
 
 /* If force_addr is set to anything different from 0, we forcibly enable
    the PIIX4 at the given address. VERY DANGEROUS! */
 static int force_addr = 0;
-MODULE_PARM(force_addr, "i");
+module_param (force_addr, int, 0);
 MODULE_PARM_DESC(force_addr,
 		 "Forcibly enable the PIIX4 at the given address. "
 		 "EXTREMELY DANGEROUS!");
@@ -102,7 +103,7 @@
 /* If fix_hstcfg is set to anything different from 0, we reset one of the
    registers to be a valid value. */
 static int fix_hstcfg = 0;
-MODULE_PARM(fix_hstcfg, "i");
+module_param (fix_hstcfg, int, 0);
 MODULE_PARM_DESC(fix_hstcfg,
 		"Fix config register. Needed on some boards (Force CPCI735).");
 
-- 
Tom Rini
http://gate.crashing.org/~trini/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20040105/d0ca16ae/attachment.bin

  parent reply	other threads:[~2005-05-19  6:24 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-30 22:02 [BK PATCH] i2c driver fixes for 2.6.0 Greg KH
2005-05-19  6:24 ` Greg KH
2003-12-30 22:06 ` [PATCH] " Greg KH
2005-05-19  6:24   ` Greg KH
2003-12-30 22:06   ` Greg KH
2005-05-19  6:24     ` Greg KH
2003-12-30 22:06     ` Greg KH
2005-05-19  6:24       ` Greg KH
2003-12-30 22:06       ` Greg KH
2005-05-19  6:24         ` Greg KH
2003-12-30 22:06         ` Greg KH
2005-05-19  6:24           ` Greg KH
2003-12-30 22:06           ` Greg KH
2005-05-19  6:24             ` Greg KH
2003-12-30 22:06             ` Greg KH
2005-05-19  6:24               ` Greg KH
2003-12-30 22:06               ` Greg KH
2005-05-19  6:24                 ` Greg KH
2003-12-30 22:06                 ` Greg KH
2005-05-19  6:24                   ` Greg KH
2003-12-30 22:06                   ` Greg KH
2005-05-19  6:24                     ` Greg KH
2003-12-30 22:06                     ` Greg KH
2005-05-19  6:24                       ` Greg KH
2003-12-30 22:06                       ` Greg KH
2005-05-19  6:24                         ` Greg KH
2003-12-30 22:06                         ` Greg KH
2005-05-19  6:24                           ` Greg KH
2003-12-30 22:06                           ` Greg KH
2005-05-19  6:24                             ` Greg KH
2003-12-30 22:06                             ` Greg KH
2005-05-19  6:24                               ` Greg KH
2003-12-30 22:06                               ` Greg KH
2005-05-19  6:24                                 ` Greg KH
2003-12-30 22:06                                 ` Greg KH
2005-05-19  6:24                                   ` Greg KH
2003-12-30 22:06                                   ` Greg KH
2005-05-19  6:24                                     ` Greg KH
2003-12-30 22:06                                     ` Greg KH
2005-05-19  6:24                                       ` Greg KH
2003-12-30 22:06                                       ` Greg KH
2005-05-19  6:24                                         ` Greg KH
2003-12-30 22:06                                         ` Greg KH
2005-05-19  6:24                                           ` Greg KH
2003-12-30 22:06                                           ` Greg KH
2005-05-19  6:24                                             ` Greg KH
2003-12-30 22:06                                             ` Greg KH
2005-05-19  6:24                                               ` Greg KH
2005-05-19  6:24   ` Rusty Russell
2005-05-19  6:24   ` Rusty Russell
2005-05-19  6:24   ` Jean Delvare
2005-05-19  6:24   ` Tom Rini [this message]
2005-05-19  6:24   ` Greg KH
2005-05-19  6:24   ` Rusty Russell
2005-05-19  6:24   ` Jean Delvare
2005-05-19  6:24   ` Greg KH
2005-05-19  6:24   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040105163441.GC2415@stop.crashing.org \
    --to=trini@kernel.crashing.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.