All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: [PATCH] i2c driver fixes for 2.6.0
Date: Thu, 19 May 2005 06:24:32 +0000	[thread overview]
Message-ID: <10728219711872@kroah.com> (raw)
In-Reply-To: <1072821971560@kroah.com>
In-Reply-To: <10728219692713@kroah.com>

ChangeSet 1.1496.8.33, 2003/12/17 16:06:23-08:00, mhoffman@lightlink.com

[PATCH] I2C: remove initialization of limits by lm75 driver

This patch is from the lm_sensors project CVS, from this revision:

	1.44 (mds) remove initialization of limits by driver

It is better to set these limits by a combination of /etc/sensors.conf
and 'sensors -s'; "mechanism not policy."


 drivers/i2c/chips/lm75.c |    8 --------
 1 files changed, 8 deletions(-)


diff -Nru a/drivers/i2c/chips/lm75.c b/drivers/i2c/chips/lm75.c
--- a/drivers/i2c/chips/lm75.c	Tue Dec 30 12:30:13 2003
+++ b/drivers/i2c/chips/lm75.c	Tue Dec 30 12:30:13 2003
@@ -51,10 +51,6 @@
 #define TEMP_FROM_REG(val)	((((val & 0x7fff) >> 7) * 5) | ((val & 0x8000)?-256:0))
 #define TEMP_TO_REG(val)	(SENSORS_LIMIT((val<0?(0x200+((val)/5))<<7:(((val) + 2) / 5) << 7),0,0xffff))
 
-/* Initial values */
-#define LM75_INIT_TEMP_OS	600
-#define LM75_INIT_TEMP_HYST	500
-
 /* Each client has this additional data */
 struct lm75_data {
 	struct semaphore	update_lock;
@@ -258,10 +254,6 @@
 static void lm75_init_client(struct i2c_client *client)
 {
 	/* Initialize the LM75 chip */
-	lm75_write_value(client, LM75_REG_TEMP_OS,
-			 TEMP_TO_REG(LM75_INIT_TEMP_OS));
-	lm75_write_value(client, LM75_REG_TEMP_HYST,
-			 TEMP_TO_REG(LM75_INIT_TEMP_HYST));
 	lm75_write_value(client, LM75_REG_CONF, 0);
 }
 


WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] i2c driver fixes for 2.6.0
Date: Tue, 30 Dec 2003 14:06:11 -0800	[thread overview]
Message-ID: <10728219711872@kroah.com> (raw)
In-Reply-To: <1072821971560@kroah.com>

ChangeSet 1.1496.8.33, 2003/12/17 16:06:23-08:00, mhoffman@lightlink.com

[PATCH] I2C: remove initialization of limits by lm75 driver

This patch is from the lm_sensors project CVS, from this revision:

	1.44 (mds) remove initialization of limits by driver

It is better to set these limits by a combination of /etc/sensors.conf
and 'sensors -s'; "mechanism not policy."


 drivers/i2c/chips/lm75.c |    8 --------
 1 files changed, 8 deletions(-)


diff -Nru a/drivers/i2c/chips/lm75.c b/drivers/i2c/chips/lm75.c
--- a/drivers/i2c/chips/lm75.c	Tue Dec 30 12:30:13 2003
+++ b/drivers/i2c/chips/lm75.c	Tue Dec 30 12:30:13 2003
@@ -51,10 +51,6 @@
 #define TEMP_FROM_REG(val)	((((val & 0x7fff) >> 7) * 5) | ((val & 0x8000)?-256:0))
 #define TEMP_TO_REG(val)	(SENSORS_LIMIT((val<0?(0x200+((val)/5))<<7:(((val) + 2) / 5) << 7),0,0xffff))
 
-/* Initial values */
-#define LM75_INIT_TEMP_OS	600
-#define LM75_INIT_TEMP_HYST	500
-
 /* Each client has this additional data */
 struct lm75_data {
 	struct semaphore	update_lock;
@@ -258,10 +254,6 @@
 static void lm75_init_client(struct i2c_client *client)
 {
 	/* Initialize the LM75 chip */
-	lm75_write_value(client, LM75_REG_TEMP_OS,
-			 TEMP_TO_REG(LM75_INIT_TEMP_OS));
-	lm75_write_value(client, LM75_REG_TEMP_HYST,
-			 TEMP_TO_REG(LM75_INIT_TEMP_HYST));
 	lm75_write_value(client, LM75_REG_CONF, 0);
 }
 


  parent reply	other threads:[~2005-05-19  6:24 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-30 22:02 [BK PATCH] i2c driver fixes for 2.6.0 Greg KH
2005-05-19  6:24 ` Greg KH
2003-12-30 22:06 ` [PATCH] " Greg KH
2005-05-19  6:24   ` Greg KH
2003-12-30 22:06   ` Greg KH
2005-05-19  6:24     ` Greg KH
2003-12-30 22:06     ` Greg KH
2005-05-19  6:24       ` Greg KH
2003-12-30 22:06       ` Greg KH
2005-05-19  6:24         ` Greg KH
2003-12-30 22:06         ` Greg KH
2005-05-19  6:24           ` Greg KH
2003-12-30 22:06           ` Greg KH
2005-05-19  6:24             ` Greg KH
2003-12-30 22:06             ` Greg KH
2005-05-19  6:24               ` Greg KH
2003-12-30 22:06               ` Greg KH
2005-05-19  6:24                 ` Greg KH
2003-12-30 22:06                 ` Greg KH
2005-05-19  6:24                   ` Greg KH
2003-12-30 22:06                   ` Greg KH [this message]
2005-05-19  6:24                     ` Greg KH
2003-12-30 22:06                     ` Greg KH
2005-05-19  6:24                       ` Greg KH
2003-12-30 22:06                       ` Greg KH
2005-05-19  6:24                         ` Greg KH
2003-12-30 22:06                         ` Greg KH
2005-05-19  6:24                           ` Greg KH
2003-12-30 22:06                           ` Greg KH
2005-05-19  6:24                             ` Greg KH
2003-12-30 22:06                             ` Greg KH
2005-05-19  6:24                               ` Greg KH
2003-12-30 22:06                               ` Greg KH
2005-05-19  6:24                                 ` Greg KH
2003-12-30 22:06                                 ` Greg KH
2005-05-19  6:24                                   ` Greg KH
2003-12-30 22:06                                   ` Greg KH
2005-05-19  6:24                                     ` Greg KH
2003-12-30 22:06                                     ` Greg KH
2005-05-19  6:24                                       ` Greg KH
2003-12-30 22:06                                       ` Greg KH
2005-05-19  6:24                                         ` Greg KH
2003-12-30 22:06                                         ` Greg KH
2005-05-19  6:24                                           ` Greg KH
2003-12-30 22:06                                           ` Greg KH
2005-05-19  6:24                                             ` Greg KH
2003-12-30 22:06                                             ` Greg KH
2005-05-19  6:24                                               ` Greg KH
2005-05-19  6:24   ` Jean Delvare
2005-05-19  6:24   ` Rusty Russell
2005-05-19  6:24   ` Rusty Russell
2005-05-19  6:24   ` Rusty Russell
2005-05-19  6:24   ` Greg KH
2005-05-19  6:24   ` Tom Rini
2005-05-19  6:24   ` Jean Delvare
2005-05-19  6:24   ` Greg KH
2005-05-19  6:24   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10728219711872@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensors@stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.