From: greg@kroah.com (Greg KH)
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: [PATCH] i2c driver fixes for 2.6.0
Date: Thu, 19 May 2005 06:24:31 +0000 [thread overview]
Message-ID: <1072821970466@kroah.com> (raw)
In-Reply-To: <10728219701447@kroah.com>
In-Reply-To: <10728219692713@kroah.com>
ChangeSet 1.1496.20.2, 2003/12/19 10:47:09-08:00, mds@paradyne.com
[PATCH] I2C: fix amd756 byte writes
This fixes byte writes (used by the eeprom driver) in the i2c-amd756
driver. It is similar to recent fixes for the i2c-amd8111 and
i2c-nforce2 drivers.
Tested by me.
drivers/i2c/busses/i2c-amd756.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff -Nru a/drivers/i2c/busses/i2c-amd756.c b/drivers/i2c/busses/i2c-amd756.c
--- a/drivers/i2c/busses/i2c-amd756.c Tue Dec 30 12:29:49 2003
+++ b/drivers/i2c/busses/i2c-amd756.c Tue Dec 30 12:29:49 2003
@@ -213,9 +213,8 @@
case I2C_SMBUS_BYTE:
outw_p(((addr & 0x7f) << 1) | (read_write & 0x01),
SMB_HOST_ADDRESS);
- /* TODO: Why only during write? */
if (read_write = I2C_SMBUS_WRITE)
- outb_p(command, SMB_HOST_COMMAND);
+ outb_p(command, SMB_HOST_DATA);
size = AMD756_BYTE;
break;
case I2C_SMBUS_BYTE_DATA:
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] i2c driver fixes for 2.6.0
Date: Tue, 30 Dec 2003 14:06:10 -0800 [thread overview]
Message-ID: <1072821970466@kroah.com> (raw)
In-Reply-To: <10728219701447@kroah.com>
ChangeSet 1.1496.20.2, 2003/12/19 10:47:09-08:00, mds@paradyne.com
[PATCH] I2C: fix amd756 byte writes
This fixes byte writes (used by the eeprom driver) in the i2c-amd756
driver. It is similar to recent fixes for the i2c-amd8111 and
i2c-nforce2 drivers.
Tested by me.
drivers/i2c/busses/i2c-amd756.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff -Nru a/drivers/i2c/busses/i2c-amd756.c b/drivers/i2c/busses/i2c-amd756.c
--- a/drivers/i2c/busses/i2c-amd756.c Tue Dec 30 12:29:49 2003
+++ b/drivers/i2c/busses/i2c-amd756.c Tue Dec 30 12:29:49 2003
@@ -213,9 +213,8 @@
case I2C_SMBUS_BYTE:
outw_p(((addr & 0x7f) << 1) | (read_write & 0x01),
SMB_HOST_ADDRESS);
- /* TODO: Why only during write? */
if (read_write == I2C_SMBUS_WRITE)
- outb_p(command, SMB_HOST_COMMAND);
+ outb_p(command, SMB_HOST_DATA);
size = AMD756_BYTE;
break;
case I2C_SMBUS_BYTE_DATA:
next prev parent reply other threads:[~2005-05-19 6:24 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-30 22:02 [BK PATCH] i2c driver fixes for 2.6.0 Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` [PATCH] " Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH [this message]
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2003-12-30 22:06 ` Greg KH
2005-05-19 6:24 ` Greg KH
2005-05-19 6:24 ` Greg KH
2005-05-19 6:24 ` Tom Rini
2005-05-19 6:24 ` Rusty Russell
2005-05-19 6:24 ` Rusty Russell
2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Rusty Russell
2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Greg KH
2005-05-19 6:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1072821970466@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.