All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Jamie Lokier <jamie@shareable.org>
Cc: Werner Almesberger <wa@almesberger.net>, linux-fsdevel@vger.kernel.org
Subject: Re: barriers vs. reads
Date: Tue, 22 Jun 2004 13:32:45 +0200	[thread overview]
Message-ID: <20040622113245.GA1104@suse.de> (raw)
In-Reply-To: <20040622112802.GA21456@mail.shareable.org>

On Tue, Jun 22 2004, Jamie Lokier wrote:
> Jens Axboe wrote:
> > > But do we have cases where reads must not cross write barriers ?
> > 
> > To me, it's the expected behaviour. If you issue a barrier write, a read
> > issued later should not be able to fetch old data.
> 
> Two things:
> 
>    1. A read _which doesn't overlap writes before the barrier_
>       should be ok before the barrier with no visible change.
> 
>       So, look at the block numbers and permit reordering if there's
>       no overlap.  This reordering is semantically invisible.

You mean a read that doesn't contain sectors that overlap with the
barrier writes? Yes that would be fine.

It's easier said than done, though. Current io schedulers don't handle
barriers in a very fast fashion - they push all pending requests from
the internal sorted tree to the dispatch list, the latter which is
always accessed in FIFO like fashion (io scheduler adds to tail, driver
eats from the head). So if you wanted to optimize this, that has to be
changed.

>    2. Other than O_DIRECT, can the I/O subsystem issue reads that
>       overlap writes in flight?  Surely that never occurs?

No, it can only happen for reads that don't go through the page cache.

>       If it never occurs, then reads can be safely moved before write
>       barriers without looking at block numbers.

It can happen with direct io of any sort, the solution has to take this
into account. That's why we currently have handling for rbtree aliases
as well.

-- 
Jens Axboe


  reply	other threads:[~2004-06-22 11:32 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-22  3:53 barriers vs. reads Werner Almesberger
2004-06-22  7:39 ` Jens Axboe
2004-06-22  7:50   ` Werner Almesberger
2004-06-22  7:55     ` Jens Axboe
2004-06-22  8:34       ` Werner Almesberger
2004-06-22 10:08         ` Jens Axboe
2004-06-22 11:28       ` Jamie Lokier
2004-06-22 11:32         ` Jens Axboe [this message]
2004-06-22 17:12           ` Bryan Henderson
2004-06-22 20:53             ` Jens Axboe
2004-06-23 16:41               ` Bryan Henderson
2004-06-23 16:52                 ` Jens Axboe
2004-06-23 16:53                 ` Jamie Lokier
2004-06-23 21:08                   ` Bryan Henderson
2004-06-23 23:23                   ` Werner Almesberger
2004-06-24 13:43                     ` Jamie Lokier
2004-06-24 14:32                       ` Christoph Hellwig
2004-06-24 17:05                       ` Werner Almesberger
2004-06-22 18:53           ` Werner Almesberger
2004-06-22 19:57             ` Jamie Lokier
2004-06-22 23:13               ` Werner Almesberger
2004-06-22 20:57             ` Jens Axboe
2004-06-22 23:10               ` Werner Almesberger
2004-06-23  0:14                 ` Jamie Lokier
2004-06-23  6:27                 ` Jens Axboe
2004-06-22 18:45         ` Werner Almesberger
2004-06-22 19:07           ` Guy
  -- strict thread matches above, loose matches on Subject: below --
2004-06-24  0:48 Werner Almesberger
2004-06-24  3:39 ` Werner Almesberger
2004-06-24  8:00   ` Herbert Poetzl
2004-06-24 12:16     ` Werner Almesberger
2004-06-24 13:36   ` Jamie Lokier
2004-06-24 17:02     ` Werner Almesberger
2004-06-24 16:39 ` Steve Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040622113245.GA1104@suse.de \
    --to=axboe@suse.de \
    --cc=jamie@shareable.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=wa@almesberger.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.