[Kernel-janitors] [PATCH] parport/ieee1284: replace

[Kernel-janitors] [PATCH] parport/ieee1284: replace

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 1182 bytes --]

I would appreciate any comments from the janitors list. This is one (of
many) cases where I made a decision about replacing

set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);

with

msleep(jiffies_to_msecs(some_time));

msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch. 

Thanks,
Nish



Applys-to: 2.6.7

Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays the desired time.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

--- linux-vanilla/drivers/parport/ieee1284.c	2004-06-16 05:18:57.000000000 +0000
+++ linux-dev/drivers/parport/ieee1284.c	2004-07-12 21:46:18.000000000 +0000
@@ -212,13 +212,11 @@ int parport_wait_peripheral(struct parpo
 		if ((status & mask) == result)
 			return 0;
 
-		if (!ret) {
+		if (!ret) 
 			/* parport_wait_event didn't time out, but the
 			 * peripheral wasn't actually ready either.
 			 * Wait for another 10ms. */
-			__set_current_state (TASK_INTERRUPTIBLE);
-			schedule_timeout ((HZ+ 99) / 100);
-		}
+			msleep(10);
 	}
 
 	return 1;

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] [PATCH] parport/ieee1284_ops: replace

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]

I would appreciate any comments from the janitors list. This is one (of
many) cases where I made a decision about replacing

set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);

with

msleep(jiffies_to_msecs(some_time));

msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch. 

Thanks,
Nish



Applys-to: 2.6.7

Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays the desired time.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

--- linux-vanilla/drivers/parport/ieee1284_ops.c	2004-06-16 05:20:04.000000000 +0000
+++ linux-dev/drivers/parport/ieee1284_ops.c	2004-07-12 22:09:23.000000000 +0000
@@ -542,8 +542,7 @@ size_t parport_ieee1284_ecp_read_data (s
 			/* Yield the port for a while. */
 			if (count && dev->port->irq != PARPORT_IRQ_NONE) {
 				parport_release (dev);
-				__set_current_state (TASK_INTERRUPTIBLE);
-				schedule_timeout ((HZ + 24) / 25);
+				msleep(40);
 				parport_claim_or_block (dev);
 			}
 			else

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] [PATCH] parport/ieee1284:

[Mark Hollomon]

[-- Attachment #1: Type: text/plain, Size: 1711 bytes --]

I think TASK_INTERRUPTIBLE is needed here. The top of the loop the 
schedule_timeout is in looks for signals.


Nishanth Aravamudan wrote:
> I would appreciate any comments from the janitors list. This is one (of
> many) cases where I made a decision about replacing
> 
> set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(some_time);
> 
> with
> 
> msleep(jiffies_to_msecs(some_time));
> 
> msleep() is not exactly the same as the previous code, but I only did
> this replacement where I thought long delays were *desired*. If this is
> not the case here, then just disregard this patch. 
> 
> Thanks,
> Nish
> 
> 
> 
> Applys-to: 2.6.7
> 
> Description: Uses msleep() instead of schedule_timeout() to guarantee
> the task delays the desired time.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> 
> --- linux-vanilla/drivers/parport/ieee1284.c	2004-06-16 05:18:57.000000000 +0000
> +++ linux-dev/drivers/parport/ieee1284.c	2004-07-12 21:46:18.000000000 +0000
> @@ -212,13 +212,11 @@ int parport_wait_peripheral(struct parpo
>  		if ((status & mask) == result)
>  			return 0;
>  
> -		if (!ret) {
> +		if (!ret) 
>  			/* parport_wait_event didn't time out, but the
>  			 * peripheral wasn't actually ready either.
>  			 * Wait for another 10ms. */
> -			__set_current_state (TASK_INTERRUPTIBLE);
> -			schedule_timeout ((HZ+ 99) / 100);
> -		}
> +			msleep(10);
>  	}
>  
>  	return 1;
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors


-- 
--------------------------
Mark Hollomon

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors