[Kernel-janitors] Re: [PATCH 2.6.9-rc2 3/33] char/drm_os_linux:

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 3/33] char/drm_os_linux:

[Keith Whitwell]

Nishanth Aravamudan wrote:
> Any comments would be appreciated. 
> 
> Description: Use set_current_state() instead of direct assignment of
> current->state.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> 
> --- 2.6.9-rc1-mm4-vanilla/drivers/char/drm/drm_os_linux.h	2004-09-09 23:05:38.000000000 -0700
> +++ 2.6.9-rc1-mm4/drivers/char/drm/drm_os_linux.h	2004-09-10 10:34:04.000000000 -0700
> @@ -134,7 +134,7 @@ do {								\
>  	add_wait_queue(&(queue), &entry);			\
>  								\
>  	for (;;) {						\
> -		current->state = TASK_INTERRUPTIBLE;		\
> +		set_current_state(TASK_INTERRUPTIBLE);		\
>  		if (condition)					\
>  			break;					\
>  		if (time_after_eq(jiffies, end)) {		\
> 

There are two assignments in that macro, aren't there?  Why not adjust both of 
them?

Keith
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 3/33] char/drm_os_linux:

[Dave Airlie]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1446 bytes --]


I'll apply this to my tree and fix up the rest of them in the DRM, and
push it to Linus..

Dave.

On Wed, 15 Sep 2004, Nishanth Aravamudan wrote:

> Any comments would be appreciated.
>
> Description: Use set_current_state() instead of direct assignment of
> current->state.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
>
> --- 2.6.9-rc1-mm4-vanilla/drivers/char/drm/drm_os_linux.h	2004-09-09 23:05:38.000000000 -0700
> +++ 2.6.9-rc1-mm4/drivers/char/drm/drm_os_linux.h	2004-09-10 10:34:04.000000000 -0700
> @@ -134,7 +134,7 @@ do {								\
>  	add_wait_queue(&(queue), &entry);			\
>  								\
>  	for (;;) {						\
> -		current->state = TASK_INTERRUPTIBLE;		\
> +		set_current_state(TASK_INTERRUPTIBLE);		\
>  		if (condition)					\
>  			break;					\
>  		if (time_after_eq(jiffies, end)) {		\
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: thawte's Crypto Challenge Vl
> Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam
> Camcorder. More prizes in the weekly Lunch Hour Challenge.
> Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m
> --
> _______________________________________________
> Dri-devel mailing list
> Dri-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/dri-devel
>

-- 
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
pam_smb / Linux DECstation / Linux VAX / ILUG person


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 3/33] char/drm_os_linux:

[Alan Cox]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

On Iau, 2004-09-16 at 12:00, Dave Airlie wrote:
> I'll apply this to my tree and fix up the rest of them in the DRM, and
> push it to Linus..

Use __set_current_state() for these. set_current_state also includes a
memory barrier (ie its designed to be safe for all uses) while the DRI
code is already careful.

Alan


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 3/33] char/drm_os_linux:

[Jon Smirl]

[-- Attachment #1: Type: text/plain, Size: 2339 bytes --]

Dave, I just fixed this one in DRM CVS.


On Thu, 16 Sep 2004 00:13:46 -0700, Nishanth Aravamudan <nacc@us.ibm.com> wrote:
> Re-submission of patch incorporating Alan Cox's suggestion of using
> __set_current_state() and changing the other direct assignment in the
> macro.
> 
> Thanks,
> Nish
> 
> Description: Use set_current_state() instead of direct assignment of
> current->state.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> 
> 
> --- 2.6.9-rc2-vanilla/drivers/char/drm/drm_os_linux.h   2004-09-13 17:15:48.000000000 -0700
> +++ 2.6.9-rc2/drivers/char/drm/drm_os_linux.h   2004-09-16 00:10:47.000000000 -0700
> @@ -134,7 +134,7 @@ do {                                                                \
>         add_wait_queue(&(queue), &entry);                       \
>                                                                 \
>         for (;;) {                                              \
> -               current->state = TASK_INTERRUPTIBLE;            \
> +               __set_current_state(TASK_INTERRUPTIBLE);                \
>                 if (condition)                                  \
>                         break;                                  \
>                 if (time_after_eq(jiffies, end)) {              \
> @@ -147,7 +147,7 @@ do {                                                                \
>                         break;                                  \
>                 }                                               \
>         }                                                       \
> -       current->state = TASK_RUNNING;                          \
> +       __set_current_state(TASK_RUNNING);                      \
>         remove_wait_queue(&(queue), &entry);                    \
>  } while (0)
> 
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
> Project Admins to receive an Apple iPod Mini FREE for your judgement on
> who ports your project to Linux PPC the best. Sponsored by IBM.
> Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
> --
> _______________________________________________
> Dri-devel mailing list
> Dri-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/dri-devel
> 



-- 
Jon Smirl
jonsmirl@gmail.com

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 3/4] sbus/bbc_i2c: replace

[David S. Miller]

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

On Mon, 27 Sep 2004 10:26:56 -0700
Nishanth Aravamudan <nacc@us.ibm.com> wrote:

> Any comments would be appreciated.
> 
> Description: Use msleep_interruptible() instead of
> schedule_timeout() to guarantee the task delays as expected. Also use
> set_current_state() instead of direct assignment of current->state.

Also applied, thanks.

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: [PATCH 2.6.9-rc2 3/4] pci hotplug/pciehp:

[Greg KH]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

On Fri, Sep 24, 2004 at 04:19:59PM -0700, Nishanth Aravamudan wrote:
> Any comments would be appreciated.
> 
> Description: Use msleep_interruptible() instead of
> schedule_timeout() to guarantee the task delays as expected.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

Applied, thanks.

greg k-h


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors