From: Andrea Arcangeli <andrea@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
riel@redhat.com, marcelo.tosatti@cyclades.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][5/?] count writeback pages in nr_scanned
Date: Thu, 6 Jan 2005 05:59:32 +0100 [thread overview]
Message-ID: <20050106045932.GN4597@dualathlon.random> (raw)
In-Reply-To: <20050105204706.0781d672.akpm@osdl.org>
On Wed, Jan 05, 2005 at 08:47:06PM -0800, Andrew Morton wrote:
> That's my point. blk_congestion_wait() will always sleep, regardless of
Since I've no pending bugs at all with the mainline codebase I rate this
just a theoretical issue: but even sleeping for a fixed amount of time
is unreliable there, for example if the storage is very slow. That's why
using io_schedule_timeout for that isn't going to be a fix.
The fix is very simple and it is to call wait_on_page_writeback on one
of the pages under writeback. That guarantees some _writeback_ progress
has been made before retrying. That way some random direct-io or a too
short timeout, can't cause malfunction.
next prev parent reply other threads:[~2005-01-06 4:59 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-03 17:25 [PATCH][5/?] count writeback pages in nr_scanned Rik van Riel
2005-01-05 10:08 ` Andrew Morton
2005-01-05 18:06 ` Andrea Arcangeli
2005-01-05 18:50 ` Rik van Riel
2005-01-05 17:49 ` Marcelo Tosatti
2005-01-05 21:44 ` Andrew Morton
2005-01-05 20:32 ` Marcelo Tosatti
2005-01-05 23:51 ` Nick Piggin
2005-01-06 1:27 ` Rik van Riel
2005-01-06 1:33 ` Nick Piggin
2005-01-06 1:37 ` Andrew Morton
2005-01-06 1:40 ` Nick Piggin
2005-01-06 1:52 ` Andrea Arcangeli
2005-01-06 1:36 ` Andrew Morton
2005-01-06 3:42 ` Rik van Riel
2005-01-06 3:50 ` Nick Piggin
2005-01-06 4:26 ` Andrew Morton
2005-01-06 4:35 ` Nick Piggin
2005-01-06 4:47 ` Andrew Morton
2005-01-06 4:55 ` Nick Piggin
2005-01-06 5:03 ` Andrea Arcangeli
2005-01-06 8:06 ` Jens Axboe
2005-01-06 8:16 ` memory barrier in ll_rw_blk.c (was Re: [PATCH][5/?] count writeback pages in nr_scanned) Nick Piggin
2005-01-06 8:32 ` Jens Axboe
2005-01-06 8:53 ` Nick Piggin
2005-01-06 12:00 ` Jens Axboe
2005-01-06 4:59 ` Andrea Arcangeli [this message]
2005-01-06 5:05 ` [PATCH][5/?] count writeback pages in nr_scanned Andrew Morton
2005-01-06 5:17 ` Andrea Arcangeli
2005-01-06 5:19 ` Nick Piggin
2005-01-06 5:25 ` Andrea Arcangeli
2005-01-06 5:36 ` Nick Piggin
2005-01-06 5:44 ` Nick Piggin
2005-01-06 5:37 ` Andrew Morton
2005-01-06 5:59 ` Andrea Arcangeli
2005-01-06 13:28 ` Rik van Riel
2005-01-06 5:32 ` Andrew Morton
2005-01-06 5:46 ` Andrea Arcangeli
2005-01-06 5:59 ` Andrew Morton
2005-01-06 6:16 ` Andrea Arcangeli
2005-01-06 5:06 ` Nick Piggin
2005-01-06 5:21 ` Andrea Arcangeli
2005-01-05 23:26 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050106045932.GN4597@dualathlon.random \
--to=andrea@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=nickpiggin@yahoo.com.au \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.