All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-ia64@vger.kernel.org, Linas Vepstas <linas@austin.ibm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	long <tlnguyen@snoqualmie.dp.intel.com>,
	linux-pci@atrey.karlin.mff.cuni.cz,
	linuxppc64-dev <linuxppc64-dev@ozlabs.org>
Subject: Re: [PATCH 04/10] IOCHK interface for I/O error handling/detecting
Date: Thu, 09 Jun 2005 16:57:58 +0000	[thread overview]
Message-ID: <20050609165758.GD9597@kroah.com> (raw)
In-Reply-To: <42A83BC8.2010500@jp.fujitsu.com>

On Thu, Jun 09, 2005 at 09:53:28PM +0900, Hidetoshi Seto wrote:
> +	/* there is no bridge */
> +	if (!dev->bus->self) return NULL;

Put the "return NULL;" on it's own line please.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-ia64@vger.kernel.org, Linas Vepstas <linas@austin.ibm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	long <tlnguyen@snoqualmie.dp.intel.com>,
	linux-pci@atrey.karlin.mff.cuni.cz,
	linuxppc64-dev <linuxppc64-dev@ozlabs.org>
Subject: Re: [PATCH 04/10] IOCHK interface for I/O error handling/detecting
Date: Thu, 9 Jun 2005 09:57:58 -0700	[thread overview]
Message-ID: <20050609165758.GD9597@kroah.com> (raw)
In-Reply-To: <42A83BC8.2010500@jp.fujitsu.com>

On Thu, Jun 09, 2005 at 09:53:28PM +0900, Hidetoshi Seto wrote:
> +	/* there is no bridge */
> +	if (!dev->bus->self) return NULL;

Put the "return NULL;" on it's own line please.

thanks,

greg k-h

  reply	other threads:[~2005-06-09 16:57 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-09 12:39 [PATCH 00/10] IOCHK interface for I/O error handling/detecting Hidetoshi Seto
2005-06-09 12:39 ` Hidetoshi Seto
2005-06-09 12:48 ` [PATCH 01/10] " Hidetoshi Seto
2005-06-09 12:48   ` Hidetoshi Seto
2005-06-09 16:53   ` Greg KH
2005-06-09 16:53     ` Greg KH
2005-06-10 10:29     ` Hidetoshi Seto
2005-06-10 10:29       ` Hidetoshi Seto
2005-06-09 12:50 ` [PATCH 02/10] " Hidetoshi Seto
2005-06-09 12:50   ` Hidetoshi Seto
2005-06-09 12:51 ` [PATCH 03/10] " Hidetoshi Seto
2005-06-09 12:51   ` Hidetoshi Seto
2005-06-09 16:57   ` Greg KH
2005-06-09 16:57     ` Greg KH
2005-06-10 10:31     ` Hidetoshi Seto
2005-06-10 10:31       ` Hidetoshi Seto
2005-06-09 17:20   ` Matthew Wilcox
2005-06-09 17:20     ` Matthew Wilcox
2005-06-10 10:31     ` Hidetoshi Seto
2005-06-10 10:31       ` Hidetoshi Seto
2005-06-09 12:53 ` [PATCH 04/10] " Hidetoshi Seto
2005-06-09 12:53   ` Hidetoshi Seto
2005-06-09 16:57   ` Greg KH [this message]
2005-06-09 16:57     ` Greg KH
2005-06-09 12:54 ` [PATCH 05/10] " Hidetoshi Seto
2005-06-09 12:54   ` Hidetoshi Seto
2005-06-09 12:56 ` [PATCH 06/10] " Hidetoshi Seto
2005-06-09 12:56   ` Hidetoshi Seto
2005-06-09 12:58 ` [PATCH 07/10] " Hidetoshi Seto
2005-06-09 12:58   ` Hidetoshi Seto
2005-06-09 17:40   ` David Mosberger
2005-06-09 17:40     ` David Mosberger
2005-06-10 10:29     ` Hidetoshi Seto
2005-06-10 10:29       ` Hidetoshi Seto
2005-06-10 17:25       ` David Mosberger
2005-06-10 17:25         ` David Mosberger
2005-06-13  6:54         ` Hidetoshi Seto
2005-06-13  6:54           ` Hidetoshi Seto
2005-06-09 13:00 ` [PATCH 08/10] " Hidetoshi Seto
2005-06-09 13:00   ` Hidetoshi Seto
2005-06-09 13:02 ` [PATCH 09/10] " Hidetoshi Seto
2005-06-09 13:02   ` Hidetoshi Seto
2005-06-09 13:04 ` [PATCH 10/10] " Hidetoshi Seto
2005-06-09 13:04   ` Hidetoshi Seto
2005-06-09 16:59 ` [PATCH 00/10] " Greg KH
2005-06-09 16:59   ` Greg KH
2005-06-09 17:13 ` Matthew Wilcox
2005-06-09 17:13   ` Matthew Wilcox
2005-06-09 22:26   ` Benjamin Herrenschmidt
2005-06-09 22:26     ` Benjamin Herrenschmidt
2005-06-10 10:31     ` Hidetoshi Seto
2005-06-10 10:31       ` Hidetoshi Seto
2005-06-10 10:30   ` Hidetoshi Seto
2005-06-10 10:30     ` Hidetoshi Seto
2005-06-09 17:34 ` Matthew Wilcox
2005-06-09 17:34   ` Matthew Wilcox
2005-06-10 10:32   ` Hidetoshi Seto
2005-06-10 10:32     ` Hidetoshi Seto
2005-06-10 23:25     ` Benjamin Herrenschmidt
2005-06-10 23:25       ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050609165758.GD9597@kroah.com \
    --to=greg@kroah.com \
    --cc=benh@kernel.crashing.org \
    --cc=linas@austin.ibm.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=tlnguyen@snoqualmie.dp.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.