All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-ia64@vger.kernel.org
Cc: Linas Vepstas <linas@austin.ibm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	long <tlnguyen@snoqualmie.dp.intel.com>,
	linux-pci@atrey.karlin.mff.cuni.cz,
	linuxppc64-dev <linuxppc64-dev@ozlabs.org>
Subject: [PATCH 01/10] IOCHK interface for I/O error handling/detecting
Date: Thu, 09 Jun 2005 12:48:15 +0000	[thread overview]
Message-ID: <42A83A8F.9020503@jp.fujitsu.com> (raw)
In-Reply-To: <42A8386F.2060100@jp.fujitsu.com>

[This is 1 of 10 patches, "iochk-01-generic.patch"]

- It defines:
     a pair of function  : iochk_clear and iochk_read
     a function for init : iochk_init
     type of control var : iocookie
   and describe "no-ops" as its "generic" action.

- HAVE_ARCH_IOMAP_CHECK allows us to change whole definition
   of these functions and type from generic one to specific one.
   See next patch (2 of 10).

Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>

---

  drivers/pci/pci.c           |    2 ++
  include/asm-generic/iomap.h |   16 ++++++++++++++++
  lib/iomap.c                 |   26 ++++++++++++++++++++++++++
  3 files changed, 44 insertions(+)

Index: linux-2.6.11.11/lib/iomap.c
=================================--- linux-2.6.11.11.orig/lib/iomap.c
+++ linux-2.6.11.11/lib/iomap.c
@@ -210,3 +210,29 @@ void pci_iounmap(struct pci_dev *dev, vo
  }
  EXPORT_SYMBOL(pci_iomap);
  EXPORT_SYMBOL(pci_iounmap);
+
+/*
+ * Clear/Read iocookie to check IO error while using iomap.
+ *
+ * Note that default iochk_clear-read pair interfaces don't have
+ * any effective error check, but some high-reliable platforms
+ * would provide useful information to you.
+ * And note that some action may be limited (ex. irq-unsafe)
+ * between the pair depend on the facility of the platform.
+ */
+#ifndef HAVE_ARCH_IOMAP_CHECK
+void iochk_init(void) { ; }
+
+void iochk_clear(iocookie *cookie, struct pci_dev *dev)
+{
+	/* no-ops */
+}
+
+int iochk_read(iocookie *cookie)
+{
+	/* no-ops */
+	return 0;
+}
+EXPORT_SYMBOL(iochk_clear);
+EXPORT_SYMBOL(iochk_read);
+#endif /* HAVE_ARCH_IOMAP_CHECK */
Index: linux-2.6.11.11/include/asm-generic/iomap.h
=================================--- linux-2.6.11.11.orig/include/asm-generic/iomap.h
+++ linux-2.6.11.11/include/asm-generic/iomap.h
@@ -60,4 +60,20 @@ struct pci_dev;
  extern void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long max);
  extern void pci_iounmap(struct pci_dev *dev, void __iomem *);

+/*
+ * IOMAP_CHECK provides additional interfaces for drivers to detect
+ * some IO errors, supports drivers having ability to recover errors.
+ *
+ * All works around iomap-check depends on the design of "iocookie"
+ * structure. Every architecture owning its iomap-check is free to
+ * define the actual design of iocookie to fit its special style.
+ */
+#ifndef HAVE_ARCH_IOMAP_CHECK
+typedef unsigned long iocookie;
+#endif
+
+extern void iochk_init(void);
+extern void iochk_clear(iocookie *cookie, struct pci_dev *dev);
+extern int  iochk_read(iocookie *cookie);
+
  #endif
Index: linux-2.6.11.11/drivers/pci/pci.c
=================================--- linux-2.6.11.11.orig/drivers/pci/pci.c
+++ linux-2.6.11.11/drivers/pci/pci.c
@@ -782,6 +782,8 @@ static int __devinit pci_init(void)
  	while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
  		pci_fixup_device(pci_fixup_final, dev);
  	}
+
+	iochk_init();
  	return 0;
  }


WARNING: multiple messages have this Message-ID (diff)
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
To: Linux Kernel list <linux-kernel@vger.kernel.org>,
	linux-ia64@vger.kernel.org
Cc: Linas Vepstas <linas@austin.ibm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	long <tlnguyen@snoqualmie.dp.intel.com>,
	linux-pci@atrey.karlin.mff.cuni.cz,
	linuxppc64-dev <linuxppc64-dev@ozlabs.org>
Subject: [PATCH 01/10] IOCHK interface for I/O error handling/detecting
Date: Thu, 09 Jun 2005 21:48:15 +0900	[thread overview]
Message-ID: <42A83A8F.9020503@jp.fujitsu.com> (raw)
In-Reply-To: <42A8386F.2060100@jp.fujitsu.com>

[This is 1 of 10 patches, "iochk-01-generic.patch"]

- It defines:
     a pair of function  : iochk_clear and iochk_read
     a function for init : iochk_init
     type of control var : iocookie
   and describe "no-ops" as its "generic" action.

- HAVE_ARCH_IOMAP_CHECK allows us to change whole definition
   of these functions and type from generic one to specific one.
   See next patch (2 of 10).

Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>

---

  drivers/pci/pci.c           |    2 ++
  include/asm-generic/iomap.h |   16 ++++++++++++++++
  lib/iomap.c                 |   26 ++++++++++++++++++++++++++
  3 files changed, 44 insertions(+)

Index: linux-2.6.11.11/lib/iomap.c
===================================================================
--- linux-2.6.11.11.orig/lib/iomap.c
+++ linux-2.6.11.11/lib/iomap.c
@@ -210,3 +210,29 @@ void pci_iounmap(struct pci_dev *dev, vo
  }
  EXPORT_SYMBOL(pci_iomap);
  EXPORT_SYMBOL(pci_iounmap);
+
+/*
+ * Clear/Read iocookie to check IO error while using iomap.
+ *
+ * Note that default iochk_clear-read pair interfaces don't have
+ * any effective error check, but some high-reliable platforms
+ * would provide useful information to you.
+ * And note that some action may be limited (ex. irq-unsafe)
+ * between the pair depend on the facility of the platform.
+ */
+#ifndef HAVE_ARCH_IOMAP_CHECK
+void iochk_init(void) { ; }
+
+void iochk_clear(iocookie *cookie, struct pci_dev *dev)
+{
+	/* no-ops */
+}
+
+int iochk_read(iocookie *cookie)
+{
+	/* no-ops */
+	return 0;
+}
+EXPORT_SYMBOL(iochk_clear);
+EXPORT_SYMBOL(iochk_read);
+#endif /* HAVE_ARCH_IOMAP_CHECK */
Index: linux-2.6.11.11/include/asm-generic/iomap.h
===================================================================
--- linux-2.6.11.11.orig/include/asm-generic/iomap.h
+++ linux-2.6.11.11/include/asm-generic/iomap.h
@@ -60,4 +60,20 @@ struct pci_dev;
  extern void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long max);
  extern void pci_iounmap(struct pci_dev *dev, void __iomem *);

+/*
+ * IOMAP_CHECK provides additional interfaces for drivers to detect
+ * some IO errors, supports drivers having ability to recover errors.
+ *
+ * All works around iomap-check depends on the design of "iocookie"
+ * structure. Every architecture owning its iomap-check is free to
+ * define the actual design of iocookie to fit its special style.
+ */
+#ifndef HAVE_ARCH_IOMAP_CHECK
+typedef unsigned long iocookie;
+#endif
+
+extern void iochk_init(void);
+extern void iochk_clear(iocookie *cookie, struct pci_dev *dev);
+extern int  iochk_read(iocookie *cookie);
+
  #endif
Index: linux-2.6.11.11/drivers/pci/pci.c
===================================================================
--- linux-2.6.11.11.orig/drivers/pci/pci.c
+++ linux-2.6.11.11/drivers/pci/pci.c
@@ -782,6 +782,8 @@ static int __devinit pci_init(void)
  	while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
  		pci_fixup_device(pci_fixup_final, dev);
  	}
+
+	iochk_init();
  	return 0;
  }


  reply	other threads:[~2005-06-09 12:48 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-09 12:39 [PATCH 00/10] IOCHK interface for I/O error handling/detecting Hidetoshi Seto
2005-06-09 12:39 ` Hidetoshi Seto
2005-06-09 12:48 ` Hidetoshi Seto [this message]
2005-06-09 12:48   ` [PATCH 01/10] " Hidetoshi Seto
2005-06-09 16:53   ` Greg KH
2005-06-09 16:53     ` Greg KH
2005-06-10 10:29     ` Hidetoshi Seto
2005-06-10 10:29       ` Hidetoshi Seto
2005-06-09 12:50 ` [PATCH 02/10] " Hidetoshi Seto
2005-06-09 12:50   ` Hidetoshi Seto
2005-06-09 12:51 ` [PATCH 03/10] " Hidetoshi Seto
2005-06-09 12:51   ` Hidetoshi Seto
2005-06-09 16:57   ` Greg KH
2005-06-09 16:57     ` Greg KH
2005-06-10 10:31     ` Hidetoshi Seto
2005-06-10 10:31       ` Hidetoshi Seto
2005-06-09 17:20   ` Matthew Wilcox
2005-06-09 17:20     ` Matthew Wilcox
2005-06-10 10:31     ` Hidetoshi Seto
2005-06-10 10:31       ` Hidetoshi Seto
2005-06-09 12:53 ` [PATCH 04/10] " Hidetoshi Seto
2005-06-09 12:53   ` Hidetoshi Seto
2005-06-09 16:57   ` Greg KH
2005-06-09 16:57     ` Greg KH
2005-06-09 12:54 ` [PATCH 05/10] " Hidetoshi Seto
2005-06-09 12:54   ` Hidetoshi Seto
2005-06-09 12:56 ` [PATCH 06/10] " Hidetoshi Seto
2005-06-09 12:56   ` Hidetoshi Seto
2005-06-09 12:58 ` [PATCH 07/10] " Hidetoshi Seto
2005-06-09 12:58   ` Hidetoshi Seto
2005-06-09 17:40   ` David Mosberger
2005-06-09 17:40     ` David Mosberger
2005-06-10 10:29     ` Hidetoshi Seto
2005-06-10 10:29       ` Hidetoshi Seto
2005-06-10 17:25       ` David Mosberger
2005-06-10 17:25         ` David Mosberger
2005-06-13  6:54         ` Hidetoshi Seto
2005-06-13  6:54           ` Hidetoshi Seto
2005-06-09 13:00 ` [PATCH 08/10] " Hidetoshi Seto
2005-06-09 13:00   ` Hidetoshi Seto
2005-06-09 13:02 ` [PATCH 09/10] " Hidetoshi Seto
2005-06-09 13:02   ` Hidetoshi Seto
2005-06-09 13:04 ` [PATCH 10/10] " Hidetoshi Seto
2005-06-09 13:04   ` Hidetoshi Seto
2005-06-09 16:59 ` [PATCH 00/10] " Greg KH
2005-06-09 16:59   ` Greg KH
2005-06-09 17:13 ` Matthew Wilcox
2005-06-09 17:13   ` Matthew Wilcox
2005-06-09 22:26   ` Benjamin Herrenschmidt
2005-06-09 22:26     ` Benjamin Herrenschmidt
2005-06-10 10:31     ` Hidetoshi Seto
2005-06-10 10:31       ` Hidetoshi Seto
2005-06-10 10:30   ` Hidetoshi Seto
2005-06-10 10:30     ` Hidetoshi Seto
2005-06-09 17:34 ` Matthew Wilcox
2005-06-09 17:34   ` Matthew Wilcox
2005-06-10 10:32   ` Hidetoshi Seto
2005-06-10 10:32     ` Hidetoshi Seto
2005-06-10 23:25     ` Benjamin Herrenschmidt
2005-06-10 23:25       ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42A83A8F.9020503@jp.fujitsu.com \
    --to=seto.hidetoshi@jp.fujitsu.com \
    --cc=benh@kernel.crashing.org \
    --cc=linas@austin.ibm.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=tlnguyen@snoqualmie.dp.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.