All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Khapyorsky <sashak@smlink.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@lists.sourceforge.net
Subject: [patch] no templated index for mc97 controls
Date: Tue, 13 Sep 2005 03:45:59 +0300	[thread overview]
Message-ID: <20050913004559.GA1682@tecr> (raw)
In-Reply-To: <s5hzmqifa6e.wl%tiwai@suse.de>

On 19:49 Mon 12 Sep     , Takashi Iwai wrote:
> 
> But I think we should fix the driver side rather than this
> configuration.  The index should be zero because it's the only one.

Like in the patch below? (please don't say that you fixed it already :) ).

Sasha.


No index is templated for mdoem controls.

Signed-off-by: Sasha Khapyorsky <sashak@smlink.com>

Index: alsa-kernel/pci/ac97/ac97_codec.c
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/pci/ac97/ac97_codec.c,v
retrieving revision 1.197
diff -u -p -r1.197 ac97_codec.c
--- alsa-kernel/pci/ac97/ac97_codec.c	9 Sep 2005 13:21:46 -0000	1.197
+++ alsa-kernel/pci/ac97/ac97_codec.c	13 Sep 2005 00:18:43 -0000
@@ -1557,7 +1557,7 @@ static int snd_ac97_modem_build(snd_card
 
 	/* build modem switches */
 	for (idx = 0; idx < ARRAY_SIZE(snd_ac97_controls_modem_switches); idx++)
-		if ((err = snd_ctl_add(card, snd_ac97_cnew(&snd_ac97_controls_modem_switches[idx], ac97))) < 0)
+		if ((err = snd_ctl_add(card, snd_ctl_new1(&snd_ac97_controls_modem_switches[idx], ac97))) < 0)
 			return err;
 
 	/* build chip specific controls */


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

  parent reply	other threads:[~2005-09-13  0:45 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-05 17:48 Mo' better modem support Takashi Iwai
2005-09-05 23:29 ` Sasha Khapyorsky
2005-09-06 13:29   ` Takashi Iwai
2005-09-07 16:03     ` Sasha Khapyorsky
2005-09-11 16:36       ` [alsa-lib patch] src/pcm/pcm_hooks.c : fix segfault then hooks list is empty Sasha Khapyorsky
2005-09-12 10:37         ` Takashi Iwai
2005-09-12  0:27       ` [conf patch] modem's pcm "two device" config [was: Re: Mo' better modem support] Sasha Khapyorsky
2005-09-12 10:38         ` Takashi Iwai
2005-09-12 17:49           ` Takashi Iwai
2005-09-12 22:10             ` Sasha Khapyorsky
2005-09-13  9:34               ` Takashi Iwai
2005-09-13 14:35                 ` Sasha Khapyorsky
2005-09-13 12:43                   ` Takashi Iwai
2005-09-13 15:36                     ` Sasha Khapyorsky
2005-09-13 17:27                       ` Sasha Khapyorsky
2005-09-13  0:45             ` Sasha Khapyorsky [this message]
2005-09-13  1:06               ` [patch] no templated index for si3036 modem controls Sasha Khapyorsky
2005-09-13 10:24               ` [patch] no templated index for mc97 controls Takashi Iwai
2005-09-12 17:05       ` [conf patch] modem config for HDA-Intel Sasha Khapyorsky
2005-09-12 15:08         ` Takashi Iwai
2005-09-13  0:18       ` [patch] "empty" generic mfg-only codec Sasha Khapyorsky
2005-09-13 10:26         ` Takashi Iwai
2005-09-06  8:37 ` Mo' better modem support Raymond
2005-09-06 14:29   ` Sasha Khapyorsky
2005-09-06 13:19     ` Raymond
2005-09-06 20:43       ` Sasha Khapyorsky
2005-09-07  0:42     ` Raymond
2005-09-07  6:44       ` Philipp Matthias Hahn
2005-09-07 10:05         ` Raymond
2005-09-07 13:15           ` Philipp Matthias Hahn
2005-09-07 17:16             ` Sasha Khapyorsky
2005-09-08 16:10               ` Raymond
2005-09-07 16:10           ` Sasha Khapyorsky
2005-09-09 15:36             ` Raymond
2005-09-10 14:49               ` Sasha Khapyorsky
2005-09-07 16:33         ` Sasha Khapyorsky
2005-09-09 16:17         ` Raymond
2005-09-11 12:45           ` Philipp Matthias Hahn
2005-09-12 16:36             ` Raymond
2005-09-13  0:09               ` au88x0 modem [was: Re: Mo' better modem support] Sasha Khapyorsky
2005-09-13  8:55                 ` Philipp Matthias Hahn
2005-09-13 17:35                   ` Re: au88x0 modem Sasha Khapyorsky
2005-09-13 17:49                     ` Philipp Matthias Hahn
2005-09-13 21:44                       ` Sasha Khapyorsky
2005-09-14  7:02                         ` Philipp Matthias Hahn
2005-09-14  9:47                           ` [Openvortex-dev] " Maarten Vanraes
2005-09-14 12:47                             ` Raymond
2005-09-14 21:03                             ` Sasha Khapyorsky
2005-09-15  7:25                               ` Philipp Matthias Hahn
2005-09-14  8:06                       ` Raymond
2005-09-14 20:56                         ` Sasha Khapyorsky
2005-09-15  9:11                           ` Philipp Matthias Hahn
2005-09-15  9:21                             ` Philipp Matthias Hahn
2005-09-15 11:10                               ` Raymond
2005-09-15 14:35                               ` Sasha Khapyorsky
2005-09-15 15:34                                 ` Raymond
2005-09-15 21:25                                   ` Alien
2005-09-16  2:17                                     ` Raymond
2005-09-16  2:26                                       ` Lee Revell
2005-09-16 18:05                                   ` Sasha Khapyorsky
2005-09-15 20:43                                 ` Sasha Khapyorsky
2005-09-16  4:33                                   ` Raymond
2005-09-16  7:53                                     ` Philipp Matthias Hahn
2005-09-16  9:24                                       ` Raymond
2005-09-16  8:21                                   ` Raymond
2005-09-16 18:20                                     ` Sasha Khapyorsky
2005-09-16  8:46                                   ` Philipp Matthias Hahn
2005-09-16  8:55                                     ` Raymond
2005-09-16 10:36                                       ` Philipp Matthias Hahn
2005-09-16 12:04                                         ` Raymond
2005-09-16 14:42                                           ` Philipp Matthias Hahn
2005-09-16 14:49                                             ` Philipp Matthias Hahn
2005-09-16 18:47                                               ` Sasha Khapyorsky
2005-09-16 18:25                                     ` Sasha Khapyorsky
2005-09-19 15:00                                       ` Philipp Matthias Hahn
2005-09-19 15:32                                         ` Raymond
2005-09-20 13:21                                           ` Philipp Matthias Hahn
2005-09-21 22:12                                             ` Sasha Khapyorsky
2005-09-21 22:03                                         ` Sasha Khapyorsky
2005-09-22  6:24                                           ` Philipp Matthias Hahn
2005-09-22 20:19                                             ` Sasha Khapyorsky
2005-09-16 14:09                                   ` Raymond
2005-09-16 21:34                                     ` Manuel Jander
2005-09-17  3:52                                       ` Raymond
2005-09-13  9:12                 ` au88x0 modem [was: Re: Mo' better modem support] Raymond
2005-09-13 18:40                   ` au88x0 modem Sasha Khapyorsky
2005-09-14 18:07                   ` au88x0 modem [was: Re: Mo' better modem support] Philipp Matthias Hahn
2005-09-13  9:22               ` Mo' better modem support Philipp Matthias Hahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050913004559.GA1682@tecr \
    --to=sashak@smlink.com \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.