Re: Re: au88x0 modem

[Sasha Khapyorsky <sashak@smlink.com>]

On 23:34 Thu 15 Sep     , Raymond wrote:
> Sasha Khapyorsky wrote:
> >
> >
> >Great, the secondary modem codec is there. The valid codec id bits are
> >24:25 (AC97 interface supports up to four codecs):
> >
> >#define VORTEX_CODEC_ID_SHIFT 24
> >
> >I will send cleaned codec access patch separately and will look what is
> >next.
> 
> 
> It would be more easy to debug/maintain the driver if using different
> read/write routines for audio and modem codec.
> 
> Audio codec is always primary in sound card and audio/modem combo
> 
> The existing vortex_codec_read() and vortex_codec_write() can remain
> unchanged.

Don't think so. It is about chip support (ac97 controller) and not about
cards, current codec_read/write are not correct since ignore ac97.num
value. And it is not about modem, but about secondary codec(s).

Request secondary codec initialization or not is different story, this
may be card specific.

Sasha.


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. 
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php